barry » Mon Oct 24, 2022 9:41 am wrote:Steve,
Great results here, congratulations. I'm getting ready to start a Monthly Trading demo on Nov 1st. I added xauusd to the Pairs to Trade in the Send trades in monthly direction script. It placed forex trades as intended but it placed 5 xauusd trades, instead of one. I closed all trades and applied the script again - same result. If this happens on Nov 1, I can close the 4 unwanted xauusd trades, so no great problem. But xauusd is doing very well in your 2276025 results, so you probably want to change your setfile as I did, to ensure that you keep getting trades in that pair, so I thought I'd pass on this feedback, in case you see the same issue, cheers.

Barcode » Sat Oct 29, 2022 1:31 am wrote:Steve, Might be worth adding XAGUSD to the list just in case it acts the same as XAUUSD

tomele » Fri Oct 28, 2022 4:38 pm wrote:Hi Steve.

Your montly trading is the most promising Forex strategy I have seen for a long time.



I was tired of Forex trading for quite some time, but am now back on fire. I will try to contribute a bit. Coming very soon ... Paycheck EA, available for Empty4 and MT5.



In the meantime, if there are any EXPERIENCED members wanting to help in beta testing - drop me a PM.

Cheers

• Data is only called for from the server when needed - in this case the open and close prices of the previous candle.
  Said data can take a while to arrive in our history but Empty4 ignores this fact and works with the next best thing - in this case often the open/close prices of two candles ago.

void getDirection(string symbol, int tf, int pairIndex)
{

   //Ascertain the direction of movement of the previous candle
   
   //double copen = iOpen(symbol, tf, 1);
   //double cclose = iClose(symbol, tf, 1);
   
   //////////////////////////////////////////////////
   //Thomas provided this section of code. Here is why, from his
   //pm to me:
   /*
   As I know, history will get loaded as soon as you access data, but that takes a while and Empty4 
   doesn't wait for the data to arrive. Instead it throws a 4066 or 4073 error which the programmer is 
   entitled to handle. In MT5 this might work better.
   Here is what I have added to my EA. You can easily adapt it to your variables:
   */
   ResetLastError();
   double copen=iOpen(symbol,PERIOD_MN1,1);
   while(GetLastError()!=0)
   {
      Sleep(10);
      ResetLastError();
      copen=iOpen(symbol,PERIOD_MN1,1);
   }
     
   ResetLastError();
   double cclose=iClose(symbol,PERIOD_MN1,1);
   while(GetLastError()!=0)
   {
      Sleep(10);
      ResetLastError();
      cclose=iClose(symbol,PERIOD_MN1,1);
   }
   //////////////////////////////////////////////////
    
   
   direction = none;
   if (cclose > copen)
   {
      direction = long;
      return;
   }//if (cclose > copen)
   
   if (cclose < copen)
   {
      direction = short;
      return;
   }//if (cclose > copen)
   

}//End void getDirection(string symbol, int tf, int pairIndex)

tomele » Wed Nov 02, 2022 10:58 am wrote:Hi Steve.

Glad it worked. Can we have investor access to the new demo?

Cheers

renexxxx wrote:Subject: Monthly trading

SteveHopwood wrote:
Do us all a favour please, fellow coders. Remember that I do not have a logical brain and that starting iterations from 0 instead of 1 confuses the Hell out of me. Please have a look at void extractPairs() in the script and see if you can spot anything wrong in the coding.

Hi Steve,

You have probably figured it out yourself already, but if not, here goes:

You have to remove the last line of the extractPairs() function, i.e. comment out the ArrayResize like so:

Code: Select all

   // Resize the arrays appropriately
   //ArrayResize(tradePair, noOfPairs);

The tradePair[] array gets already resized for every symbol in the tempTradePair[] array that has a bid-value. You don't want to add additional empty strings in the tradePair[] array for those pairs that are in the PairsToTrade string, but are not in the MarketWatch panel (and therefore have no bid-value). Because, if you do, and you run this script on a XAUUSD-chart, these empty strings are translated to the current symbol (i.e. XAUUSD) in the other functions (MarketInfo, OrderSend etc).

Hope this makes sense.

Rene.