grimweasel wrote:Ok, so I keep getting the Error 130: Invalid Stops every second? I thought this was linked to Crim being an ECN or not, but I have tried both on/off and I still get the error?

EllisEdi wrote:

grimweasel wrote:Ok, so I keep getting the Error 130: Invalid Stops every second? I thought this was linked to Crim being an ECN or not, but I have tried both on/off and I still get the error?

I was getting this as well...

I made some changes and no longer get these errors. Basically I added a return of Null to CalculateStopLoss if no stop Loss calculation occurs. then I added a check to not do any calculation with the stop variable if it was null. this sends a null in the stoploss to the SendSingleTrade method therefore no stoploss.

I also changed a couple of default settings ... I am new to this forum and I am not sure about the rules on re-posting someones ea that i modified. so the changes are documented below (but no attached file)

--Mark

I changed this:
double CalculateStopLoss(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double stop, price;

to:
double CalculateStopLoss(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double stop, price = NULL;


And this
double CalculateTakeProfit(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double take, price;

to this:
double CalculateTakeProfit(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double take, price = NULL;

And This (in if (SendLong)):
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(price, NormalizeDouble(stop, Digits) );


To this:

if (stop != NULL)
{
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(price, NormalizeDouble(stop, Digits) );
}

And This: (in if (SendShort))
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(NormalizeDouble(stop, Digits), price);


To This:
if (stop != NULL)
{
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(NormalizeDouble(stop, Digits), price);
}

EllisEdi wrote:

grimweasel wrote:Ok, so I keep getting the Error 130: Invalid Stops every second? I thought this was linked to Crim being an ECN or not, but I have tried both on/off and I still get the error?

I was getting this as well...

I made some changes and no longer get these errors. Basically I added a return of Null to CalculateStopLoss if no stop Loss calculation occurs. then I added a check to not do any calculation with the stop variable if it was null. this sends a null in the stoploss to the SendSingleTrade method therefore no stoploss.

I also changed a couple of default settings ... I am new to this forum and I am not sure about the rules on re-posting someones ea that i modified. so the changes are documented below (but no attached file)

--Mark

I changed this:
double CalculateStopLoss(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double stop, price;

to:
double CalculateStopLoss(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double stop, price = NULL;


And this
double CalculateTakeProfit(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double take, price;

to this:
double CalculateTakeProfit(int type)
{
//Returns the stop loss for use in LookForTradingOpps and InsertMissingStopLoss
double take, price = NULL;

And This (in if (SendLong)):
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(price, NormalizeDouble(stop, Digits) );


To this:

if (stop != NULL)
{
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(price, NormalizeDouble(stop, Digits) );
}

And This: (in if (SendShort))
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(NormalizeDouble(stop, Digits), price);


To This:
if (stop != NULL)
{
//Lot size calculated by risk
if (RiskPercent > 0) SendLots = CalculateLotSize(NormalizeDouble(stop, Digits), price);
}

SteveHopwood wrote: Mark, I started to make the changes tonight then realised they do not make any sense. Declaring price as as NULL is irrelevant, because the function assigns the Bid or Ask to price, depending on the order type. What am I missing?

garyfritz wrote:Mark, either you're confused, or Steve and I are...

You originally said you set *price* to NULL, and as Steve said, the first thing those functions do is set price to Bid or Ask. I think you intended to set *stop* to NULL? Then if StopLoss == 0, stop returns NULL, and you test stop for NULL later.

Personally I would not initialize a double value to NULL. NULL isn't really a double value. I would initialize it explicitly to 0.0. Then you could check for 0.0 instead of checking for NULL -- except it turns out you don't really have to. If stop == 0, CalculateLotSize() returns Lot, and that's probably the right LotSize if there is no SL. But it would be more clear to explictly check for if (stop > 0 && RiskPercent > 0).

So at a minimum you should set stop to NULL instead of price -- but I'd just set it to 0.0 and forget the other changes.

EllisEdi wrote:I am crazy old man ...

grimweasel wrote:Thanks Ellis and Steve for trying. I was only getting the error once the trade went into profit and tried to adjust the stop, looking at the charts. I have turned off ALL stop loss functions in the EA and have no problems (of course) at the moment. Maybe it's a criminal issue? I'm using FXCM in the UK?