ironrick wrote:

gaheitman wrote: Some options I've come up with to trigger a stop for the day:

The obvious ones:

• MaxTrades, MaxLosingTrades, MaxWinningTrades
  MaxPipGain, MaxPipLoss
  MaxBalanceGain, MaxBalanceLoss
  MaxPercentGain, MaxPercentLoss

For the options above, there will be a switch for UseEquity or UseBalance as well as combinable options for UseMagicNumber and UseCurrencyPair. That way the code works for multi-currency bots as well as allows people running the same EA across several currencies. All the options make calculating percents difficult, but there it is...

The less obvious (need more idea here):

• MaxADRPercent //generally if it's a big move day signals are out of whack
  HardStopDateTime //For example, hard coding to stop on next Thursday at 2:15 GMT
  StrategyDoneForTheDay() //a strategy specific procedure that the user modifies that by default just returns false

Now back to the subject at hand...

Because it has been on mind, I was thinking of other trade-length time-based options.

Rather then just a clock time -- End trade at 2:30pm, end the trade/trading after a certain AMOUNT of time -- Start at 7:00am/x signal/MA cross/whatever and end after 5.5 hours.

Just a thought.

Rick

dietcoke wrote:Super stuff George.

I noticed one thing in the ADR function.

Code: Select all

double CalculateADR(int i, int Days) {
   double sum=0;
   double cnt=0;
   int offset=0;
   int day=0;
   
   while (cnt<Days) {
      offset = iBarShift(NULL,PERIOD_D1,Time[i]);
      if(TimeDayOfWeek(iTime(NULL,PERIOD_D1,day+1+offset)) != 0) {
         sum += iHigh(NULL,PERIOD_D1,day+1+offset)-iLow(NULL,PERIOD_D1,day+1+offset);
         cnt++;
      }//if(TimeDayOfWeek(iTime(NULL,PERIOD_D1,day+1+offset)) != 0) 
      day++;
   }
   return(sum/cnt);

}

Maybe I'm mixed up. I assume this bit should be dropping from offset back to zero
day+1+offset

Should it not be

offset+1-day?

Can you think of a good way to, incorporate Sunday stub bars into Mondays range(if outside?) into this function.

SteveHopwood wrote:Latest update in post 1.

For those of a delicate disposition, here is the sanitised rationale:
It appears that the markets can sometimes be moving so quickly that ECN criminals will be unable to allow modifications of trades that update stop losses and take profits. I have added code to CountOpenTrades() that will detect when this happens, and further call functions that will replace the missing tp/sl.


Now, here is what I really mean. Do not read on if bad language offends you.

Only a total tit fails to recognise that some bastard criminals have rabidly adopted ECN in the hope that this will happen:

• Naive trader sends a trade.
  Platform freezes up before there is time to send the modification of the trade that adds a sl/tp.
  Said platform freeze can be encouraged/simulated by all sorts of thingies that are 'out of control of the criminal. Please be assured that we continue to develop our services to the benefit of our valued clients '.

Total shits.

So, these mindless, turd-brained (and I use the term 'brained' with reservation), manipulative fucking bastards are forcing those of us daft enough to play their game to accept that:

• We can send trades without stops
  The stops we try to send as a second stage, will not be accepted. Ok, so they all offer that bloody silly order form that allow us to input stops, but it seems there is not guarantee that the stop modifications will actually happen

So, the latest mod tells the bot to keep on trying to add stops etc even though the fucking bastard wanking shits have done their best to stop this happening.

I will defeat these bastards.

• DLLs Enabled
• Connection to server
• Experts Enabled
• Lot size is > Min Lot size for pair
• Criminal is ECN is checked if STOP_LEVEL = 0 (I am fairly sure this is a valid test for ECN)
• Account Balance = 0

void CheckForCommonErrors() {


   string msg = "";
  
   if (!IsDllsAllowed()) msg = msg + "DLLs are disabled. See <F7> | Common Tab | Allow DLL Imports.\n";
   if (!IsConnected()) msg = msg + "No connection to server.\n";
   if (!IsExpertEnabled()) msg = msg + "Experts are not enabled. See <Ctrl-O> | Expert Advisors tab.\n";
   
   if (Lot < MarketInfo(Symbol(),MODE_MINLOT)) msg = msg + "Lotsize is set too low for your account.  Min Lotsize allowed is " + DoubleToStr(MarketInfo(Symbol(),MODE_MINLOT),2) + " lots.\n";
   if (MarketInfo(Symbol(),MODE_STOPLEVEL) == 0 && CriminalIsECN == False) msg = msg + "You probably have an ECN, but have not set CriminalIsECN = true.\n";

   //zero account balance
   if (AccountBalance() == 0) msg = msg + "You have a ZERO account balance.\n";
   
   if (IsDllsAllowed()) {
      if (msg != "")
         MessageBox("Important, possible errors detected in configuration. \n\n" + msg + "\n EA will likely not work correctly.",WindowExpertName()+" - Configuration Errors Found",MB_ICONWARNING);
   }else
      Alert("Important, possible errors detected in configuration. \n\n" + msg + "\n EA will NOT work.");
}