stevehopwoodforex.com • Multi_Stoch_Rsi_Trader

Author:

Lifesys [ Wed Nov 14, 2012 6:48 am ]

Post subject:

Re: Multi_Stoch_Rsi_Trader

Hi Andrew
MSRT has a problem with the CloseAll function in that it closes ALL trades, even those not it's own.
I like to try most of the 'sensible' robots on Steve's forum & this one made some sense.
For me so far MSRT has not made a profitable trade set, but today 4 open hit -100 pip (OOTB stoploss) CloseAll and closed it's own + 4 well-in-profit trades from another EA (which I find continually profitable).
Never been keen on these esoteric magic number formulas/routines.
ie MagicNumber = CreateMagicNumber();
personally a simple preset integer makes far more sense.

Problem - all close routines have such as -

Code: Select all

	if (BasketPipsStopLoss < 0 ..............
		CloseAll(7, -1);

but CloseAll is non-descriminating.

Code: Select all

void CloseAll(int Slippage, int MagicNumber)
..............
   if (OrderType() == OP_BUY && (MagicNumber == OrderMagicNumber() || MagicNumber == -1)) {

I am removing the CreateMagicNumber() function and see how it goes - at least I now have control.

Code: Select all

//	MagicNo = CreateMagicNumber();

Author:	phil_trade [ Tue Nov 13, 2012 8:02 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
VirtualFM wrote: MrLong wrote:Hello Traders, Latest version on page 1. Sht... OK, 2 things: First: I'm an idiot. An I-D-I-O-T!*! I usually have several Empty4 opened, some for demo accounts, one for real stuff. Doing several things at once, I messed up and put this on a real account. Result: I was having a pretty good day, with +100€ pocked but some -400€ in drawdown. I knew why and they were controlled. As sson as I dropped this EA there, it started to close every single trade, and I ended up with -300€ of loss. For real. I am an IDIOT, again! IDIOTA! Second: So, this had a severe problem. Checking in, it seems that the code that esured the EA owned the trades, right after this: //Ensure the EA 'owns' this trade was commented. Just to warn someone as idiot as me. Probably noone else will fall for it, but still... I feel sorry! A good use is to desactive the button " Expert Enable " before any manip. to have time to estimate her own stupid things:)

Author:	MrLong [ Tue Nov 13, 2012 8:40 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
acostafulano wrote:Hi MR Long, what settings are you testing? I'm testing 2 demos ATM, http://www.myfxbook.com/members/acostaf ... -v1/400603 http://www.myfxbook.com/members/acostaf ... -v2/400605 Both are with basket closures=0 (That is, every trade for itself) First one has default factors (0.61 and 0.50) Second one hald (0.32 and 0.25) Diego MrLong wrote:Hello Traders, Latest version on page 1. I've added Adaptive stoploss and takeprofit, there are now 3 different methods to control, stoploss and takeprofit. 1) Calculated by the ADR, in which case the takeprofit and stoploss is calculated on the timeframe entered in, TP_SLtimeframe . 2) Adaptive, which is as I understand it adaptive pips * open trades. 2) Basket, which you set your basket pips and hope all the trades make it. LockedInPips is the amount to lock in when takeprofit hits LockedInLevel, then the EA will trail the pips. I removed quite a bit of junk code and had a general tidy up, I've had it running all day and seems ok. The EA seems to be doing quite well at the moment, lets hope that continues. Andy Hello, Default settings, just as it was uploaded. Andy

Author:	MrLong [ Tue Nov 13, 2012 8:47 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
VirtualFM wrote: MrLong wrote:Hello Traders, Latest version on page 1. Sht... OK, 2 things: First: I'm an idiot. An I-D-I-O-T!*! I usually have several Empty4 opened, some for demo accounts, one for real stuff. Doing several things at once, I messed up and put this on a real account. Result: I was having a pretty good day, with +100€ pocked but some -400€ in drawdown. I knew why and they were controlled. As sson as I dropped this EA there, it started to close every single trade, and I ended up with -300€ of loss. For real. I am an IDIOT, again! IDIOTA! Second: So, this had a severe problem. Checking in, it seems that the code that esured the EA owned the trades, right after this: //Ensure the EA 'owns' this trade was commented. Just to warn someone as idiot as me. Probably noone else will fall for it, but still... I'm sorry this happened, I'm sure you don't need me to tell you, this EA is still in the testing period and this will happen. I will add some code, so the EA will only close trades it owns. Andy

Author:	chobbes [ Tue Nov 13, 2012 8:49 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
Thanks MrLong - I have just updated to your latest version 1.04 from 1.03. I am running OOTB settings on Alpari. My results are below: sorry refer to trades from 12th Nov onwards - ps anyone know how I can filter older trades out for others not to see? VirtualFM you must be gutted - I've messed up with bigger amounts for more subtle reasons before.

Author:	MrLong [ Tue Nov 13, 2012 9:50 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
version 1.05: uploaded to page,1. Will only close trades owned by this EA, but the buttons will close all open trades, that represent what it say's on the label. Andy

stevehopwoodforex.com https://www.stevehopwoodforex.com/phpBB3/ Print view

Multi_Stoch_Rsi_Trader https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=945	Page 4 of 16

Author:	JulesvH [ Tue Nov 13, 2012 9:54 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
chobbes wrote: sorry refer to trades from 12th Nov onwards - ps anyone know how I can filter older trades out for others not to see? In Myfxbook, click on portfolio. Then the account/system name (MultiStochRSI). In the right top you can click on custom analysis (under the contest button) There you can select a start date, click analyse and then "pin" the date with the red pin button at the right (when hovering over that buttom with the mouse it says "custom start"with a explanation. Good luck

Author:	chobbes [ Tue Nov 13, 2012 10:01 pm ]
Post subject:	Re: Multi_Stoch_Rsi_Trader
Thanks JulesvH for the quick response, have done that now.

Author:	MrLong [ Wed Nov 14, 2012 7:45 am ]
Post subject:	Re: Multi_Stoch_Rsi_Trader_V1.04
VirtualFM wrote: MrLong wrote: I'm sorry this happened, I'm sure you don't need me to tell you, this EA is still in the testing period and this will happen. Like I said, I was multitasking with several MT4s opened (and dozens of other things) and I thought I was putting it on a Empty4 with a demo account. This doesn't happen a lot, in fact I don't remember this ever happening before. Guess I had some bad luck! In fact, I was just standing there waiting for the tick to see the information on the screen and didn't even care much when I saw the trades closing... only then I realized it was the real account. Otherwise I could have stopped the thing before. MrLong wrote:I will add some code, so the EA will only close trades it owns. I wonder why you took out that code in the first place. I clearly remember it was there in version 1.03 and it made sense. And I think that the "Close All" etc buttons should also only deal with the positions owned by this EA, because the basket generated by it should be independent from whatever else is going on on other trades. I wonder why you took out that code in the first place. I clearly remember it was there in version 1.03 and it made sense. <== I removed it for testing and forgot to replace it.

All times are UTC	Page 4 of 16
Powered by phpBB® Forum Software © phpBB Limited