stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Bob and Shelley Again
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=2759		 Page 33 of 120
Author:  SteveHopwood [ Thu Sep 26, 2013 2:23 pm ]
Post subject:  Re: Bob and Shelley Again
fxozgirl wrote:So with that in mind, is Dave's suggestion able to be incorporated into the EA for both main & re-entry trades as some extra protection without affecting the existing money management features?
Done. V 1y in post 1.

BASA runs the check at the open of the second candle after the trade candle, and only if the trade is not in profit.

:D
Author:  spotdespot [ Thu Sep 26, 2013 4:03 pm ]
Post subject:  Re: Bob and Shelley Again
Excellent - updated thanks.
Cheers,
Dave.
Author:  fxozgirl [ Thu Sep 26, 2013 8:28 pm ]
Post subject:  Re: Bob and Shelley Again
SteveHopwood wrote:
fxozgirl wrote:So with that in mind, is Dave's suggestion able to be incorporated into the EA for both main & re-entry trades as some extra protection without affecting the existing money management features?
Done. V 1y in post 1.

BASA runs the check at the open of the second candle after the trade candle, and only if the trade is not in profit.

:D
Thanks again Steve, this should help us cut our (almost) certain losers quickly saving significant pips and will then allow us to recover much quicker. I will update my platforms today!

Thanks Dave for your contributions

:D
Author:  fchaman [ Thu Sep 26, 2013 9:21 pm ]
Post subject:  Re: Bob and Shelley Again
Thanks for the update.

Is it advisable to close all open positions for the weekends? These large gap opennings can sometimes be very brutal on your open positions...
Author:  fxdaytrader [ Thu Sep 26, 2013 10:10 pm ]
Post subject:  Re: Bob and Shelley Again
fchaman wrote: Is it advisable to close all open positions for the weekends?
Try it out, see attached. It is the version 1y (the current version) with the following modifications (just a few, search for "fxdaytrader" to find them in the code):

extern bool StopOpenPositionsFridayEvening, extern bool CloseAllOpenTradesAlso added. This allows to user to let the EA stop opening positions and/or close all open positions on friday at the specified LOCAL (!) hour.

It should be obvious that "CloseAllOpenTradesAlso" only makes sense if StopOpenPositionsFridayEvening" is TRUE ...

Further I have implemented the NormalizeLots-function (see also http://forum.mql4.com/45425#564188) and an retry if OrderClose() by OrderClosePrice() fails (it will then try to close BUYS at BID and SELLS at ASK price, and if this fails return false). The Ordercloseprice-failure maybe very rare, but it can happen and happened. The bid/ask-alternative may be redundant, but why not, in the rare cases the error occurs it will help closing the position faster ...

Try on demo first!
8-)
Author:  milanese [ Thu Sep 26, 2013 10:25 pm ]
Post subject:  Re: Bob and Shelley Again
Thank you :)

Cheers

Tommaso
Author:  SteveHopwood [ Thu Sep 26, 2013 10:30 pm ]
Post subject:  Re: Bob and Shelley Again
fxdaytrader wrote:
fchaman wrote: Is it advisable to close all open positions for the weekends?
Try it out, see attached. It is the version 1y (the current version) with the following modifications (just a few, search for "fxdaytrader" to find them in the code):

extern bool StopOpenPositionsFridayEvening, extern bool CloseAllOpenTradesAlso added. This allows to user to let the EA stop opening positions and/or close all open positions on friday at the specified LOCAL (!) hour.

It should be obvious that "CloseAllOpenTradesAlso" only makes sense if StopOpenPositionsFridayEvening" is TRUE ...

Further I have implemented the NormalizeLots-function (see also http://forum.mql4.com/45425#564188) and an retry if OrderClose() by OrderClosePrice() fails (it will then try to close BUYS at BID and SELLS at ASK price, and if this fails return false).

Try on demo first!
8-)
I have a busy teaching day on Friday, so I have done my last coding for this week. Please:
  • ensure your coding is accurate.
  • have added relevant appreciations of your work (you have read my code and understand how grateful I am for the input of so many other coders)
then I can make your latest into whatever version is the latest. Actually, could you do that for me, please?

And the final killer. The real bugger with this kind of thread is maintaining the User Guide. The odt file for this is housed on my coding machine, which I turned off because it is my bedtime, and so I cannot attach the UG here. I have turned said machine back on and am about to send the UG to you via pm. Could you update it in light of your recent developments, please, so I can update the pdf in post 1?

Sorry. I know I am asking a lot but you know what you have done here and so are best positioned to add to the UG.

Does it help if I make you my Best Friend Ever?

We are all really grateful for your efforts here. You are a star.

:D
Author:  fchaman [ Thu Sep 26, 2013 10:31 pm ]
Post subject:  Re: Bob and Shelley Again
Many thanks fxdaytrader...will try it out!
Author:  fxdaytrader [ Thu Sep 26, 2013 10:37 pm ]
Post subject:  Re: Bob and Shelley Again
SteveHopwood wrote: Please:
  • ensure your coding is accurate.
  • have added relevant appreciations of your work (you have read my code and understand how grateful I am for the input of so many other coders)
(...)
Actually, could you do that for me, please?

(...) I have turned said machine back on and am about to send the UG to you via pm. Could you update it in light of your recent developments, please, so I can update the pdf in post 1?
Of course, I will do that. 8-)
Author:  SteveHopwood [ Thu Sep 26, 2013 10:44 pm ]
Post subject:  Re: Bob and Shelley Again
fxdaytrader wrote:
SteveHopwood wrote: Please:
  • ensure your coding is accurate.
  • have added relevant appreciations of your work (you have read my code and understand how grateful I am for the input of so many other coders)
(...)
Actually, could you do that for me, please?

(...) I have turned said machine back on and am about to send the UG to you via pm. Could you update it in light of your recent developments, please, so I can update the pdf in post 1?
Of course, I will do that. 8-)
Thank you my friend. I have sent you the UG. I am going to bed now and am busy tomorrow, so please do not be offended if I do not respond immediately to your posts.

:D
All times are UTC Page 33 of 120

Powered by phpBB® Forum Software © phpBB Limited