Gertje » Sat Oct 21, 2017 6:12 pm wrote: This USDCAD trade is a textbook trade, according to this strategy.
Once it triggered NEARLY A MONTH AGO on the 25th of september, it never went in DD but stayed in floating profit.
A few times it nearly went to TP, reason for me to close it at this point.
Of course it will scream upwards mondaymorning....

capmojo » Wed Oct 25, 2017 10:54 pm wrote:
Hi everyone,
I had great success with PoS version 1e during the last couple of months, the one which is still in the first post.
However, since the beginning of October I was struggling with the new version 1f to get it work properly. The main issue was that, on one hand it fixed the multiple entries issue from 1e, but on the other side the recovery trades weren't working correctly anymore compared to the previous version.
After some headaches going through the code and formula validations, I found a potential error in the DoesStopOrderExist function. The pips calculations should be changed as below in the print, as "price" isn't the current market price, but instead the price of already open order + market distance pips. In this case the results were always the same = no pendings ...

Steve, If your ok with that, I am attaching here a version 1g with my suggested fix. It's tested and the recovery trades are working now correctly. I tested also market distance pips using one sixth for recovery trades and it seems also ok now. ATR I can't confirm yet. Please have a look ...

bool DoesStopOrderExist(string symbol, int type, double price, int dd)
{

   //Checks that there is not already a stop order in place before sending a gap filling trade.
   
   if (OrdersTotal() == 0)
      return(false);
   if (OpenTrades == 0)
      return(false);
   
   
   for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
   {
      if (!OrderSelect(cc, SELECT_BY_POS) ) continue;
      if (OrderSymbol() != symbol ) continue;
      if (OrderMagicNumber() != MagicNumbers[dd]) continue;
      if (OrderType() != type) continue;
      if (!CloseEnough(OrderOpenPrice(), price) ) continue;
      if (OrderComment() != TradeComments[dd] ) continue;
      
      //Got to here, so we have found a trade
      return(true);

   }//for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
   
   
   //Got this far, so no trade found
   return(false);   

}//End bool DoesStopOrderExist(int type, double price, int cc)

jade768 » Thu Oct 26, 2017 12:07 pm wrote:
Seems to spawn lots of trades EURAUD for me. I've taken the code from Awesome which seems to do the trick.

Code: Select all

bool DoesStopOrderExist(string symbol, int type, double price, int dd)
{

   //Checks that there is not already a stop order in place before sending a gap filling trade.
   
   if (OrdersTotal() == 0)
      return(false);
   if (OpenTrades == 0)
      return(false);
   
   
   for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
   {
      if (!OrderSelect(cc, SELECT_BY_POS) ) continue;
      if (OrderSymbol() != symbol ) continue;
      if (OrderMagicNumber() != MagicNumbers[dd]) continue;
      if (OrderType() != type) continue;
      if (!CloseEnough(OrderOpenPrice(), price) ) continue;
      if (OrderComment() != TradeComments[dd] ) continue;
      
      //Got to here, so we have found a trade
      return(true);

   }//for (int cc = OrdersTotal() - 1; cc >= 0; cc--)
   
   
   //Got this far, so no trade found
   return(false);   

}//End bool DoesStopOrderExist(int type, double price, int cc)

TraderJoeForex » Thu Nov 02, 2017 11:33 am wrote:Nice results Gertje