Kevin has been busy again whilst I have been out teaching. He has found a few more thingies in the trade closure function and worked out why DistanceBetweenTrades was resetting to 0. The fix for this was not quite right, so if you are one of the 4 who downloaded it before seeing this post, then you need to redownload.
V 2h in post 1.
For the smarty-pants do it yourselfers:
Go to line 4670, which should be a blank line, and insert this snippet:
Code: Select all if (!UseAtrForGrid)
{
DistanceBetweenTrades = DistanceBetweenTradesPips;
if (CloseEnough(DistanceBetweenTrades, 0) )
DistanceBetweenTrades=3;
}//if (!UseAtrForGrid)
if (UseAtrForGrid)
if (CloseEnough(DistanceBetweenTrades, 0) )
{
GridAtrVal = GetAtr(Symbol(), GridAtrTimeFrame, GridAtrPeriod, 1);
GridAtrVal*= factor;
GridAtrVal = NormalizeDouble(GridAtrVal * GridAtrMultiplier, 0);
DistanceBetweenTrades = NormalizeDouble(GridAtrVal / GridSize, 0);
}//if (CloseEnough(DistanceBetweenTrades, 0) )
DistanceBetweenTrades = DistanceBetweenTradesPips;
Delete that line.
Copy this over the top of the existing void ShouldTradesBeClosed(), starting at c. 3812:
Code: Select all void ShouldTradesBeClosed()
{
if (OpenTrades == 0)
return;//Nothing to do
int tries = 0;
//Semaforsignals
//We only want trades closing if the trades are based on a previous candle's signal
if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
{
//Opposite direction semafor
//Close buys
if (CloseTradesOnRelevantSemafor || CloseImmediatelySemaforAppears)//semafor
{
//SemStatus will only == highsemafor or highsemafornow if CloseImmediatelySemaforAppears is enabled
if (SemStatus == highsemafor || SemStatus == highsemafornow)
{
tries = 0;
//Close buys
if (BuyOpen && (!CloseOnlyInPositivePips || BuyPipsUpl > 0))
{
ForceTradeClosure = true;
while (ForceTradeClosure)
{
CloseAllTrades(OP_BUY);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
if (GridType == Stop_Orders_Only && (DeleteAndReplaceLosersGrid || !SellOpen))
CloseAllTrades(OP_SELLSTOP);
if (ForceTradeClosure)
Sleep(1000);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while (ForceTradeClosure)
//Replace the grids for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceWinnersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new buy stop orders ready in case market resumes its upward move
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceLosersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new sell stop orders much closer to the market
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}//if (BuyOpen)
}//if (SemStatus == highsemafor || SemStatus == highsemafornow)
//SemStatus will only == lowsemafor or lowsemafornow if CloseImmediatelySemaforAppears is enabled
if (SemStatus == lowsemafor || SemStatus == lowsemafornow)
{
tries = 0;
//Close sells
if (SellOpen && (!CloseOnlyInPositivePips || SellPipsUpl > 0))
{
ForceTradeClosure = true;
while (ForceTradeClosure)
{
CloseAllTrades(OP_SELL);
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if (GridType == Stop_Orders_Only && (DeleteAndReplaceLosersGrid || !BuyOpen))
CloseAllTrades(OP_BUYSTOP);
if (ForceTradeClosure)
Sleep(1000);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while (ForceTradeClosure)
//Replace the sell grid for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceWinnersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new sell stop orders ready in case market resumes its downward move
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceLosersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new buy stop orders much closer to the market
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}//if (SellOpen)
}//if (SemStatus == lowsemafor || SemStatus == lowsemafornow)
}//if (CloseTradesOnRelevantSemafor || CloseImmediatelySemaforAppears)//semafor
}//if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
//OppositeSignals
//We only want trades closing if the trades are based on a previous candle's signal
if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
{
//Buy signal
if (BuySignal)
if (OriginalSignal != OP_SELL)
{
tries = 0;
//Close sells
if (SellOpen && (!OnlyCloseProfitableOppositePositions || SellPipsUpl > 0))
{
ForceTradeClosure = true;
while(ForceTradeClosure)
{
CloseAllTrades(OP_SELL);
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if(GridType == Stop_Orders_Only && (DeleteAndReplaceOppositeSignalLosersGrid || !BuyOpen))
CloseAllTrades(OP_BUYSTOP);
if (ForceTradeClosure)
Sleep(1000);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
//Replace the grids for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceOppositeSignalWinnersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new sell stop orders ready in case market resumes its downward move
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceOppositeSignalLosersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new buy stop orders much closer to the market
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}// if (SellOpen)
}//if (OriginalSignal != OP_SELL)
//Sell signal
if (SellSignal)
if (OriginalSignal != OP_BUY)
{
tries = 0;
//Close buys
if (BuyOpen && (!OnlyCloseProfitableOppositePositions || BuyPipsUpl > 0))
{
ForceTradeClosure = true;
while(ForceTradeClosure)
{
CloseAllTrades(OP_BUY);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
if (GridType == Stop_Orders_Only && (DeleteAndReplaceOppositeSignalLosersGrid || !SellOpen))
CloseAllTrades(OP_SELLSTOP);
if(ForceTradeClosure)
Sleep(1000);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
//Replace the grids for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceOppositeSignalWinnersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new buy stop orders ready in case market resumes its upward move
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceOppositeSignalLosersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new sell stop orders much closer to the market
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}//if (BuyOpen)
}//if (OriginalSignal != OP_BUY)
}//if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
//Yellow wavy range signal
//We only want trades closing if the trades are based on a previous candle's signal
if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
{
if (CloseOnYellowRangeWave)
{
if (WaveStatus == Waverange)
{
tries = 0;
//Close buys
if (BuyOpen && (!OnlyCloseProfitablePositions || BuyPipsUpl > 0))
{
ForceTradeClosure = true;
while(ForceTradeClosure)
{
CloseAllTrades(OP_BUY);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
if(GridType == Stop_Orders_Only && (DeleteAndReplaceWavyLosersGrid || !SellOpen))
CloseAllTrades(OP_SELLSTOP);
if (ForceTradeClosure)
Sleep(1000);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
//Replace the grids for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceWavyWinnersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new buy stop orders ready in case market resumes its upward move
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceWavyLosersGrid)
if (SellOpen)//open sells means the cycle has not ended and we want new sell stop orders much closer to the market
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}//if (BuyOpen)
//Close sells
if (SellOpen && (!OnlyCloseProfitablePositions || SellPipsUpl > 0))
{
ForceTradeClosure = true;
while(ForceTradeClosure)
{
ForceTradeClosure = false;
CloseAllTrades(OP_SELL);
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if (GridType == Stop_Orders_Only && (DeleteAndReplaceWavyLosersGrid || !BuyOpen))
CloseAllTrades(OP_BUYSTOP);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
//Replace the grids for the stop orders method
if (GridType == Stop_Orders_Only)
{
if (ReplaceWavyWinnersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new sell stop orders ready in case market resumes its downward move
SendSellGrid(Symbol(), OP_SELLSTOP, NormalizeDouble(Bid - (DistanceBetweenTrades / factor), Digits), Lot);
if (DeleteAndReplaceWavyLosersGrid)
if (BuyOpen)//open buys means the cycle has not ended and we want new buy stop orders much closer to the market
SendBuyGrid(Symbol(), OP_BUYSTOP, NormalizeDouble(Ask + (DistanceBetweenTrades / factor), Digits), Lot);
}//if (GridType == Stop_Orders_Only)
return;//Nothing more for this function to do
}//if (SellOpen)
}// if (WaveStatus == Waverange)
}//if (CloseOnYellowRangeWave)
} //if (LatestTradeTime < iTime(Symbol(), TradingTimeFrame, 0) )
//Hedged position. Has it hit tp?
if (Hedged)
{
bool ClosePosition = false;
//Have we hit pips upl
if (HedgeProfitPips > 0)
if (PipsUpl >= HedgeProfitPips)
ClosePosition = true;
//Have we hit cash upl
if (!ClosePosition)
if (HedgeProfitCash > 0)
if (CashUpl >= HedgeProfitCash)
ClosePosition = true;
if (ClosePosition)
{
tries = 0;
ForceTradeClosure = true;
while(ForceTradeClosure)
{
ForceTradeClosure = false;
if (BuyOpen)
CloseAllTrades(OP_BUY);
if (SellOpen)
CloseAllTrades(OP_SELL);
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
}//if (ClosePosition)
}//if (Hedged)
//No trade signal. Delete existing pendings if none of them have filled.
if (LatestTradeTime >= iTime(Symbol(), TradingTimeFrame, 0) )
if (HgiSignalStatus == hginosignal)
if (!BuyOpen)
if (!SellOpen)
{
tries = 0;
ForceTradeClosure = true;
while(ForceTradeClosure)
{
ForceTradeClosure = false;
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
}//if (!SellOpen)
//All market trades have hit tp
if (PendingTradesTotal <= GridSize)//There should be up to GridSize * 2
if (MarketTradesTotal == 0)//And all the market trades have hit tp or sl
{
ForceTradeClosure = true;
while(ForceTradeClosure)
{
tries = 0;
ForceTradeClosure = false;
if (SellStopOpen)
CloseAllTrades(OP_SELLSTOP);
if (SellLimitOpen)
CloseAllTrades(OP_SELLLIMIT);
if (BuyStopOpen)
CloseAllTrades(OP_BUYSTOP);
if (BuyLimitOpen)
CloseAllTrades(OP_BUYLIMIT);
tries++;
if (tries >= 100)
{
ForceTradeClosure = false;
break;
}//if (tries >= 100)
}//while(ForceTradeClosure)
}//if (MarketTradesTotal == 0)//And all the market trades have hit tp or sl
}//End void ShouldTradesBeClosed()
#define version "Version 2g"
to
#define version "Version 2h"
Thanks again Kevin. 
 |
Todays trades 
