SteveHopwood » Wed Sep 25, 2019 11:00 pm wrote:

taipan » Wed Sep 25, 2019 12:56 pm wrote:
Here you go:

I am thrashing around in the dark here. It is just like the ole days.

I have added a bit more code, in hope rather than faith. Post 1 as usual.

I have added some code to: void canWeSendTrades(string symbol, int pairIndex, int signal)

Scroll down to: getBasics(symbol); Insert this just above:

Code: Select all

   //Just in case a buy/sell signal has been left when it should have been cancelled
   //and the signal has changed to untradable.
   if (signal == FLAT || signal == NONE)
      return;
 

I have added an extra check to the line of code I added earlier. Do a search for: if (!DeletePendingOrdersOnFlatSignal || signal != FLAT)

Edit to include an extra check:
if (!DeletePendingOrdersOnFlatSignal || (signal != FLAT && signal != NONE))

No idea if it will work.

The closure is a 2 pass process, closing the market orders first and then deleting stop/limit orders. Sing out if this does not work.

Does your problem apply to the, "Close all trades this pair only script.mq4" script as well?

Sojourner » 26 Sep 2019, 23:22 wrote:We need to put the designer in a locked room with all sharp objects removed to make sure he can update the expirations.

taipan » Thu Sep 26, 2019 1:18 pm wrote:
Hi Steve,
After upated with the latest Desky, the problems still happened but not that frequent anymore. I can live with that as long as the expert log does not occurred so freqent that will not causing the GP Demo got deleted.

Thanks for the bug hunting.

taipan

   /*
   LUC was proving to be a sodding nightmare when I coded this next snippet.
   DeletePendingOrdersOnFlatSignal is deleting stop/limit orders as soon as
   they are being sent and I have no idea why. This code snippet is me thrashing
   around in the dark, trying to fix this.
   */
   if (signal != LONG)
      if (signal != SHORT)
         return;

SteveHopwood » Sun Sep 29, 2019 9:01 pm wrote:

taipan » Thu Sep 26, 2019 1:18 pm wrote:
Hi Steve,
After upated with the latest Desky, the problems still happened but not that frequent anymore. I can live with that as long as the expert log does not occurred so freqent that will not causing the GP Demo got deleted.

Thanks for the bug hunting.

taipan

I am still trying. Post 1, as usual.

OR:

Go to: void fillTheGap(string symbol)

Add an extra parameter thus:
void fillTheGap(string symbol, int signal)

Add this to the top of the function:

Code: Select all

   /*
   LUC was proving to be a sodding nightmare when I coded this next snippet.
   DeletePendingOrdersOnFlatSignal is deleting stop/limit orders as soon as
   they are being sent and I have no idea why. This code snippet is me thrashing
   around in the dark, trying to fix this.
   */
   if (signal != LONG)
      if (signal != SHORT)
         return;

Press F7 to compile and follow the resulting error message to: fillTheGap(symbol);

Replace that line of code with: fillTheGap(symbol, signal);

Cross your fingers.

• Trading only after a reversal: this is a brilliant idea added by Ehrenmat. Thganks Mat. The idea is to wait for x candles to go in the 'wrong direction' after TDesk generates a LONG or SHORT signal i.e. falling candles following a LONG and rising candles following a SHORT. This is another example of the 'buy low, sell high' principle of trading espoused elsewhere by Peaky. This is applied to all trades including grid trades. The inputs are:
  • AllTradesWaitForAReversal: turns this feature on/off. Note it is off by default.
  • ReversalTimeFrame: this is the time frame for the candles to reverse.
  • NoOfCandlesInReversal: the number of candles that must have travelled in the 'wrong' direction before Desky will send a trade. For example:
    • You have this feature turned on, with ReversalTimeFrame = the H1 and NoOfCandlesInReversal = 2.
    • TDesk generates a LONG signal, so Desky waits for the market to fall two candles on the H1 before sending a trade.

• some inputs
• a couple of lines of display code
• an entire function to copy/paste (bool waitForCandleReversal(string direction, string symbol) )
• many additions to void canWeSendTrades(string symbol, int pairIndex, int signal), so the easiest thing to do is to copy Mat's function over the top of the existing one
• the bloop fix in bool haveEnoughcandlesReversed(string direction, string symbol)
• ignore the one in void fillTheGap(string symbol, int signal) - I left out an upper case letter in the comment so there is nothing to edit

SteveHopwood » Yesterday, 19:06 wrote:V 3w is in post 1.

Ehrenmat pm'd me earlier with a fix for a bloop in the counter-trend scalping code that was preventing sells - one of my usual copy-paste-didn't-edit-properly bloops.

Mat also added a potentially useful feature to make Desky wait for a reversal before reacting to a LONG/SHORT trading signal. From the updated user guide, in the 'Trading styles' inputs section:

Thanks Mat. Wonderful stuff.

You can DIY by doing downloding 3v and doing a match whole word and case search for: //stop. This will take you to everything that needs adding to your version. There are:

• some inputs
• a couple of lines of display code
• an entire function to copy/paste (bool waitForCandleReversal(string direction, string symbol) )
• many additions to void canWeSendTrades(string symbol, int pairIndex, int signal), so the easiest thing to do is to copy Mat's function over the top of the existing one
• the bloop fix in bool haveEnoughcandlesReversed(string direction, string symbol)
• ignore the one in void fillTheGap(string symbol, int signal) - I left out an upper case letter in the comment so there is nothing to edit

By the by folks, I have uploaded a new version of the Nuclear Option script after I noticed it was not responding to a MagicNumber=-1 input. There was a line of code I forgot to add.