stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Bob and Shelley Again
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=2759		 Page 35 of 120
Author:  SteveHopwood [ Sun Sep 29, 2013 10:25 pm ]
Post subject:  Re: Bob and Shelley Again
fxozgirl wrote:At the risk of copping a walloping for this time/day related question from Steve, FXDayTrader can you please clarify what settings are required for a Saturday close to trading. Down here in Oz, trading stops at 7am (AEST) Saturday morning...looks like this isn't accounted for in your settings

ie. Monday=1, Tuesday=2, I'm assuming Wednesday=3, Thursday=4, then Friday=5, Sunday=6

Apologies if I am being daft and remember it is Monday morning here ;)
StopTradingDay The day the market closes in your timezone (5=friday, 1=monday, 2=tuesday,..., 6=sunday), up to 99.9% you do not have to change that
Hehe. You will not ever cop a walloping from me.

Best guess is the relevant answer to your question is 6 as crims with Sat and Sun candles will have both as 6. Not certain, mind. :lol:

FXDayTrader, welcome to my world. Guess why I long ago refused to get involved with time zone stuff and absolutely insist that everyone using my bots use their own local time?

:D
Author:  fxdaytrader [ Mon Sep 30, 2013 12:52 am ]
Post subject:  Re: Bob and Shelley Again
What the fu** - > It seems I just arrived in your world @ Steve :mrgreen:

my explanation was/is wrong: "default: 5=friday (1=monday,2=tuesday,...,6=sunday)"

sunday is =0, so saturday is=6 ...

hours are local time, please consider that when running the ea on vps.

I am sorry, but, hey, I was wondering myself "what, marc is simple coding but no bloops?".

@Steve: I am sorry, could you replace the line (310):
"extern string tra3="default: 5=friday (1=monday,2=tuesday,...,6=sunday)";"

with

Code: Select all

extern string  tra3="default: 5=friday (0=sunday,1=monday,2=tuesday,...,6=saturday)";
I am sorry and will pay you some drinks (if we should meet somewhen, but who knows?) :P
Author:  trader689 [ Mon Sep 30, 2013 1:21 am ]
Post subject:  Re: Bob and Shelley Again
have loaded v1z, lets see what this week brings
Author:  fxozgirl [ Mon Sep 30, 2013 11:24 am ]
Post subject:  Re: Bob and Shelley Again
fxdaytrader wrote:What the fu** - > It seems I just arrived in your world @ Steve :mrgreen:

my explanation was/is wrong: "default: 5=friday (1=monday,2=tuesday,...,6=sunday)"

sunday is =0, so saturday is=6 ...

hours are local time, please consider that when running the ea on vps.

I am sorry, but, hey, I was wondering myself "what, marc is simple coding but no bloops?".

@Steve: I am sorry, could you replace the line (310):
"extern string tra3="default: 5=friday (1=monday,2=tuesday,...,6=sunday)";"

with

Code: Select all

extern string  tra3="default: 5=friday (0=sunday,1=monday,2=tuesday,...,6=saturday)";
I am sorry and will pay you some drinks (if we should meet somewhen, but who knows?) :P
thanks for checking fxdaytrader...I thought I was going a bit silly :lol:
Author:  fxozgirl [ Mon Sep 30, 2013 9:08 pm ]
Post subject:  Re: Bob and Shelley Again
Not sure if anyone else has noticed but v1z is not moving to breakeven and the jumping stops are not working either.
This has occurred on all my demo's and live accounts.
Please see screenshots below from my live GP account where I have just manually moved my stops on 3 trades which hit +30 overnight.
I am changing back to 1y for now
basa_trades_manually_moved_to_breakeven_131001.png
eurusdh4_131001.png
eurcadh4_131001.png
gbpjpyh4_131001.png
Author:  fxdaytrader [ Mon Sep 30, 2013 9:24 pm ]
Post subject:  Re: Bob and Shelley Again
fxozgirl wrote:Not sure if anyone else has noticed but v1z is not moving to breakeven and the jumping stops are not working either.

Code: Select all

if (OrderProfit() > 0)
         if (!FirstTime) 
            if (PreviousOpenTrades == 1)             
               TradeManagementModule();

FirstTime is never =false I think (countopentrades(): static bool FirstTime = true; ), so the trademanagementmodule will not be called ?

:?:

edit:
Steve, what do you think about giving stacktrades a different magicnumber?
Maybe it would be easier to filter and (if running on different pairs) summarize all stacktrades (= larger basket). ?
Author:  SteveHopwood [ Mon Sep 30, 2013 9:38 pm ]
Post subject:  Re: Bob and Shelley Again
fxozgirl wrote:Not sure if anyone else has noticed but v1z is not moving to breakeven and the jumping stops are not working either.
This has occurred on all my demo's and live accounts.
Please see screenshots below from my live GP account where I have just manually moved my stops on 3 trades which hit +30 overnight.
I am changing back to 1y for now
basa_trades_manually_moved_to_breakeven_131001.png
eurusdh4_131001.png
eurcadh4_131001.png
gbpjpyh4_131001.png
Nice one Shelley. I had not noticed.

Telling an EA on restart where it left off can be a highly complex thingy, and I left a step out of 1z.

Go to the very bottom of void CountOpenTrades() and add this line of code:
FirstTime = false;

then recompile.

Doesn't matter whether if you understand or not, just do it. It works.

I will put up a full version fix in the morning but my coding machine is turned off and takes about 10 minutes to wake up and I am going to bed soon. I have worked out the fix from my trading machine but have learned that only chaos ensues if I try to post fully-fixed versions from here. I frequently forget to download fixes, and so am adding a fix to a previously faulty version............................................

:D
Author:  SteveHopwood [ Mon Sep 30, 2013 9:42 pm ]
Post subject:  Re: Bob and Shelley Again
fxdaytrader wrote:
fxozgirl wrote:Not sure if anyone else has noticed but v1z is not moving to breakeven and the jumping stops are not working either.

Code: Select all

if (OrderProfit() > 0)
         if (!FirstTime) 
            if (PreviousOpenTrades == 1)             
               TradeManagementModule();

FirstTime is never =false I think (countopentrades(): static bool FirstTime = true; ), so the trademanagementmodule will not be called ?

:?:
Thanks. Yours and my posts must have waved, "Ehup" to each other as they passed in the ether. Dead right, as usual.
edit:
Steve, what do you think about giving stacktrades a different magicnumber?
Maybe it would be easier to filter and (if running on different pairs) summarize all stacktrades (= larger basket). ?
You think this stuff is not complicated enough already? Why not make it harder still? :lol:

:D
Author:  fxdaytrader [ Mon Sep 30, 2013 10:23 pm ]
Post subject:  Re: Bob and Shelley Again
attached the version with the fix, replaced '}//End void CountOpenTrades();' with

Code: Select all

FirstTime = false;
}//End void CountOpenTrades();
Further I fixed my moronic mistake (the hint-text for the stoptradingday) ... ;)
Author:  plateman [ Tue Oct 01, 2013 9:13 am ]
Post subject:  Re: Bob and Shelley Again
My preferred way of running BASA is to have an extra blank chart window open, one half is iexposure tickets which gives a good at a glance summary of open positions, the other half is the full version of MPTM managing all trades (a proven bombproof trade manager), all trade management options in the actual EA are obviously turned off.
All times are UTC Page 35 of 120

Powered by phpBB® Forum Software © phpBB Limited