stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

James16: the EA
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=377		 Page 5 of 8
Author:  blahn [ Thu Mar 15, 2012 3:15 am ]
Post subject:  Re: James16: the EA
Ya, that's what I figured. D1 is pretty smooth. On the other hand, my 16 h1 trades at $45 have increased to 18 floating trades at over $80 profit. it's been a while since i've had a demo acct show roughly 800 pips profit in 1 day. will have to wait to see how it handles the closures tho.
james floating 2.gif
Author:  fx800 [ Thu Mar 15, 2012 4:36 am ]
Post subject:  Re: James16: the EA
blahn wrote:Ya, that's what I figured. D1 is pretty smooth. On the other hand, my 16 h1 trades at $45 have increased to 18 floating trades at over $80 profit. it's been a while since i've had a demo acct show roughly 800 pips profit in 1 day. will have to wait to see how it handles the closures tho.
james floating 2.gif
Very impressive results. The big gains all come from JPY pairs, quite several of them.

The reverse might happen if they all lose at the same time.
Author:  fxozgirl [ Thu Mar 15, 2012 6:16 am ]
Post subject:  Re: James16: the EA
blahn wrote:Ya, that's what I figured. D1 is pretty smooth. On the other hand, my 16 h1 trades at $45 have increased to 18 floating trades at over $80 profit. it's been a while since i've had a demo acct show roughly 800 pips profit in 1 day. will have to wait to see how it handles the closures tho.
james floating 2.gif

Very nice...what are you using as your exit strategy?
Author:  fxozgirl [ Thu Mar 15, 2012 6:24 am ]
Post subject:  Re: James16: the EA
fxozgirl wrote:USDCAD DBLHC - Potential set up

This is the first potential set up for the EA to take a dblhc trade, entry parameters are in line with the rules...just waiting for the new candle

Hi Steve,

Trade wasn't taken, double low bars were 1.4 pips apart, looking for a buy trade at open of new candle, no trade taken.
(I have since opened the trade manually)
Not sure if there is a bloop in the code or is there something else I'm not considering?
usdcad_dblhc001a.gif
Author:  fxozgirl [ Thu Mar 15, 2012 6:34 am ]
Post subject:  Re: James16: the EA
fxozgirl wrote: BTW...the usdjpy trade is now +65 pips (with 40 pips locked in)

This trade has just closed at +100 pips profit :D
MPTM followed the action all the way, price went as high as 128 pips and closed on the retrace.
I would say this was as close as perfect a trade as could be!
Author:  blahn [ Thu Mar 15, 2012 7:27 pm ]
Post subject:  Re: James16: the EA
fxozgirl wrote:
blahn wrote:Ya, that's what I figured. D1 is pretty smooth. On the other hand, my 16 h1 trades at $45 have increased to 18 floating trades at over $80 profit. it's been a while since i've had a demo acct show roughly 800 pips profit in 1 day. will have to wait to see how it handles the closures tho.
james floating 2.gif

Very nice...what are you using as your exit strategy?
haven't figured that out yet. right now i'm just occasionally glancing at it from work. going to move the test to a fxdd acct tho, i forgot oanda uses the comment box and doesn't let the ea post comments. I'll probably just use mptm with really loose break evens and jumps depending how strong the signals are.
Author:  fxozgirl [ Thu Mar 15, 2012 7:38 pm ]
Post subject:  Re: James16: the EA
fxozgirl wrote:
fxozgirl wrote:USDCAD DBLHC - Potential set up

This is the first potential set up for the EA to take a dblhc trade, entry parameters are in line with the rules...just waiting for the new candle
usdcad_dblhc001a.gif

Hi Steve,

Trade wasn't taken, double low bars were 1.4 pips apart, looking for a buy trade at open of new candle, no trade taken.
(I have since opened the trade manually)
Not sure if there is a bloop in the code or is there something else I'm not considering?
I put the EA on a 4H chart to try and get it to trigger at dbc trade and it did, on audjpy.
The trade was a dblhc (as per the usdcad) and the 2 low's were actually 3 pips apart (EA default is 2) and it took the buy trade, whereas the usdcad lows were 1.4 pips apart and no trade.
audjpy_dblhc_4h001.gif
Hmmm...I feel like I am missing something here :?
Author:  fxozgirl [ Thu Mar 15, 2012 7:57 pm ]
Post subject:  Re: James16: the EA
fxozgirl wrote:
fxozgirl wrote:
fxozgirl wrote:USDCAD DBLHC - Potential set up

This is the first potential set up for the EA to take a dblhc trade, entry parameters are in line with the rules...just waiting for the new candle

Hi Steve,

Trade wasn't taken, double low bars were 1.4 pips apart, looking for a buy trade at open of new candle, no trade taken.
(I have since opened the trade manually)
Not sure if there is a bloop in the code or is there something else I'm not considering?
I put the EA on a 4H chart to try and get it to trigger at dbc trade and it did, on audjpy.
The trade was a dblhc (as per the usdcad) and the 2 low's were actually 3 pips apart (EA default is 2) and it took the buy trade, whereas the usdcad lows were 1.4 pips apart and no trade.

Hmmm...I feel like I am missing something here :?
Ok, I've taken a look at the code (please forgive me if my comments below are ignorant as I am not very good at reading code :oops: )

But I saw this
//2nd bar must close higher than first
if (iClose(NULL, Dbc.TimeFrame, 1) <= iClose(NULL, Dbc.TimeFrame, 2)) SendLong = false;
}//if (SendLong)
if (SendLong)
{
//2nd bar must close no higher than 2 pips above the first
if (iClose(NULL, Dbc.TimeFrame, 2) - iClose(NULL, Dbc.TimeFrame, 1) > (Dbc.Pips * Point) ) SendLong = false;
}//if (SendLong)
and then this:
//2nd bar must close lower than first
if (iClose(NULL, Dbc.TimeFrame, 1) >= iClose(NULL, Dbc.TimeFrame, 2)) SendShort = false;
}//if (SendShort)
if (SendShort)
{
//2nd bar must close no lower than 2 pips above the first
if (iClose(NULL, Dbc.TimeFrame, 2) - iClose(NULL, Dbc.TimeFrame, 1) > (Dbc.Pips * Point) ) SendShort = false;
}//if (SendShort)
The comments highlighted in red...I don't think it matters if the candle closes within 2 pips of each other, the main indentification criteria is that the double lows (or highs) are within 2 pips. Once that is determined than as long as the close is higher or lower than the previous candle the trade should be taken.

Again, please accept my apologies if I have misread this :)
Author:  fxozgirl [ Thu Mar 15, 2012 8:17 pm ]
Post subject:  Re: James16: the EA
AUDUSD TMH - Potential set up

Looks like there is a TMH setting up for audusd, current and previous candle's highs are within 2 pips of each other, so if the current candle's high remains within the 2 pips and then continues up and breaks the high, we should be looking at a buy trade...

These trades seem to be fairly rare, so we will see what happens
audusd_tmh001.gif
Author:  SteveHopwood [ Fri Mar 16, 2012 10:48 pm ]
Post subject:  Re: James16: the EA
fxozgirl wrote:Ok, I've taken a look at the code (please forgive me if my comments below are ignorant as I am not very good at reading code :oops: )

But I saw this

etc
Shelley, that is just plain awesome.

What I coded was a misunderstanding of the idea, so the correction is in post 1. At least it should be. I have had a busy day, am tired, and made the correction under The Affluence. It might need checking in the sober light of tomorrow. :lol:

Note to fledgling coders: despite being a non-coder, Shelley was able to spot my error because of the comment that showed what I had coded. Ok, so she clearly has a brain the size of Jupiter, but the comment merely made it easier for her to spot the error. So, comment everything you do. I am not the greatest commenter in the world, but am getting better. I once read some advice from a pro programmer who said that his comments were always longer than his code. I am gradually coming to understand why.

If you look at code produced by the likes of squalou, the comments are both extensive and comprehensive. So yep; comment everything.

Nice one Shelley.

:D
All times are UTC Page 5 of 8

Powered by phpBB® Forum Software © phpBB Limited