Angat » Sun Jan 11, 2015 5:12 pm wrote:
If anyone is wondering, I had another look in the HA indicator code and just realised what it meant.

Code: Select all

      if(open[0]<close[0])
        {
         ExtLowHighBuffer[0]=low[0];
         ExtHighLowBuffer[0]=high[0];
        }
      else
        {
         ExtLowHighBuffer[0]=high[0];
         ExtHighLowBuffer[0]=low[0];
        }

     

Damn Heiken Ashi, such a pretty indicator but so weirdly coded.

Angat » Sat Jan 17, 2015 2:43 pm wrote:I'm currently trying to move my working EA into Steve's bare bones shell.

I had all my signal variables within the int start() in my old ea. There were a lot of them as I was predefining sets of Heiken Ashi Candles.

I was hoping I can move all my signal variables to the top under the other EA variables. But what I'm finding is I cant call them from within functions like "LookForTradingOpportunities();"

Now if I were to move them all down to within the above function, I'm sure it would work, but is there a way to keep them up the top and still be able to call them from within functions?

//start of your code 
// here you put all your global variable stuff
double yourIndivalue_1=0.0;
double yourIndivalue_2=0.0;
bool doLong=false;
bool doShort=false;

//Here you get the indicator values

 void ReadIndicators() {
//fictiv iCustom call
yourIndivalue_1=iCustom(Symbol(), 0, IndiName, MaMetod, MaPeriod, MaMetod2, MaPeriod2, 4, shift);
yourIndivalue_2=iCustom(Symbol(), 0, IndiName, MaMetod, MaPeriod, MaMetod2, MaPeriod2, 2, shift);

}
//ok now we look for possibilities to open a position

void LookForTradingOpportunities() {
doLong=false;//resetting 
doShort=false;// resetting
ReadIndicators();//we need to get the latest indi_values
if (yourIndivalue_1 > yourIndivalue_2) {
doLong=true;
}
else if (yourIndivalue_1 < yourIndivalue_2) {
doShort=true;
}
}

AnotherBrian » Sat Jan 17, 2015 4:33 pm wrote:Variables that are initialise outside of all functions, including start(), are accessible from all functions. If you initialise inside start(), then only start() will see them.
Also - globalevariables can be used, but thats more for communicating between charts.

from a web [age, edited to make more sense

Global Variable

A global variable is a variable that can be accessed in multiple functions. This means that wherever you are in the program you can use that variable: get its current value or set its value to something else. Global variables are created using the initialize global name to block found in the Variables drawer.

Local Variable

A local variable is a variable that is declared within a function or it is an argument passed into a function. This means that you can only access these variables in that specific function where they are declared or passed in as an argument.

Here is an example

Code: Select all

//start of code
bool var;

start(){
bool small;
some code;
//we can access variables 'small' and 'var'
}

myfunction(){
bool myvariable;
somecode;
//we can access variables 'var' and myvariable
}

Hope this is what you were asking? I know it took me a while to figure this out when I started.

bool LineDetectABZERO = ((ObjectFind(0,"AlphaLine_0")==0) || (ObjectFind(0,"BetaLine_0")==0));

If(LineDetectABZERO) 
 SendShort = true;

milanese » Sat Jan 17, 2015 6:04 pm wrote:

Angat » Sat Jan 17, 2015 2:43 pm wrote:I'm currently trying to move my working EA into Steve's bare bones shell.

I had all my signal variables within the int start() in my old ea. There were a lot of them as I was predefining sets of Heiken Ashi Candles.

I was hoping I can move all my signal variables to the top under the other EA variables. But what I'm finding is I cant call them from within functions like "LookForTradingOpportunities();"

Now if I were to move them all down to within the above function, I'm sure it would work, but is there a way to keep them up the top and still be able to call them from within functions?

Steve's shell uses a good structure to understand what all functions do, it is coded, because so it is easy adaptable to nearly all requested strategies.
In LookForTradingOpportunities() is all that is needed for make the trading decissions for opening positions, if the strategy useses indicators, the ReadIndicators() part is the modul for getting the indicator values. I will give you an example how to handle his:

Code: Select all

//start of your code 
// here you put all your global variable stuff
double yourIndivalue_1=0.0;
double yourIndivalue_2=0.0;
bool doLong=false;
bool doShort=false;

//Here you get the indicator values

 void ReadIndicators() {
//fictiv iCustom call
yourIndivalue_1=iCustom(Symbol(), 0, IndiName, MaMetod, MaPeriod, MaMetod2, MaPeriod2, 4, shift);
yourIndivalue_2=iCustom(Symbol(), 0, IndiName, MaMetod, MaPeriod, MaMetod2, MaPeriod2, 2, shift);

}
//ok now we look for possibilities to open a position

void LookForTradingOpportunities() {
doLong=false;//resetting 
doShort=false;// resetting
ReadIndicators();//we need to get the latest indi_values
if (yourIndivalue_1 > yourIndivalue_2) {
doLong=true;
}
else if (yourIndivalue_1 < yourIndivalue_2) {
doShort=true;
}
}

Hope this helps somewhat..


Cheers

Tommaso