SteveHopwood wrote:Ehup Rene

I hope you are keeping well.

My OnDeinit() functions have a lot of code such as this:

ArrayFree(TradePair);
ArrayResize(TradePair, 0);
ArrayFree(tradingStatus);
ArrayResize(tradingStatus, 0);

Once the memory is released by the ArrayFree(), is the ArrayResize() achieving anything?

Cheers

renexxxx wrote:
Hi Steve,

No, i don't think it does. ArrayFree() already resizes the array to 0, as this script attests:

Code: Select all

int dynamicArray[];

void OnStart() {

   ArrayResize( dynamicArray, 100 );
   PrintFormat( "The size of dynamicArray = %d", ArraySize(dynamicArray) );
   ArrayFree( dynamicArray );
   PrintFormat( "The size of dynamicArray = %d", ArraySize(dynamicArray) );
}

Furthermore, whilst on the topic of freeing dynamic arrays, this: I think that Empty4 is freeing global dynamic memory automatically in the Deinit phase. However, in my programs I don't want to rely on that, as you never know for sure with Empty4. So, I think that it is a good practise to have the ArrayFree()'s in the Deinit(). However, in other functions that use global dynamic memory, you must use ArrayFree() to free the old memory, eg.

Code: Select all

int orderTickets[];

void getOrders() {

   ArrayFree(orderTickets);

   for(int iOrder=OrdersTotal()-1; iOrder >= 0; iOrder--) {
   
      if ( !OrderSelect(iOrder, SELECT_BY_POS, MODE_TRADES) ) continue;
   
      int currentSize = ArraySize(orderTickets);
      ArrayResize(orderTickets, currentSize+1);
      orderTickets[currentSize] = OrderTicket();
   }
}

In this code, getOrders() can be called many times in the program, and it won't autmatically free the old memory. If you would use ArrayResize(orderTickets,0) instead of ArrayFree(orderTickets) at the start of the routine, it would merely set the index to the end of the orderTickets to zero, without freeing the elements beyond that. Anyway, that it as far as I understand the mysteries of Empty4....

Have a good weekend!

Rene.

   ArrayResize(GridOrderBuyTickets, 0);
   ArrayInitialize(GridOrderBuyTickets, -1);

   ArrayFree(GridOrderBuyTickets);

• end of week 1: balance $325 and flat for the weekend.
• Tuesday of week 2: balance c. $340.
• Wednesday night: balance $292. You can see the main culprit in the picture.
• Thursday night: clawed back to a fraction over $300
• Friday night: back to a fraction over $340 and flat for the weekend.

Barcode » Mon Nov 27, 2017 9:39 pm wrote:Steve,

I am using your set file and I have CadPairsPositiveOnly=true and OnlyTradePositiveSwap=false. USDCAD Trading Status is ticked and it's opened a chart window but has not opened a trade. No messages in the logs. Everything looks ok so hopefully my heads not on the chopping block

Bob