dlewisfl wrote:There are other variables defined globally that should be defined locally, as well as other inefficiencies (e.g. not using arrays and copy/pasting code unnecessarily, the number of times he reads through the order pool each tick, using the error message function in the source instead of using an include, needlessly defining variables). The source file for this EA could easily be ~500 lines instead of the 1400+ and be much more efficient.

Baluda wrote:

dlewisfl wrote:There are other variables defined globally that should be defined locally, as well as other inefficiencies (e.g. not using arrays and copy/pasting code unnecessarily, the number of times he reads through the order pool each tick, using the error message function in the source instead of using an include, needlessly defining variables). The source file for this EA could easily be ~500 lines instead of the 1400+ and be much more efficient.

You are right, for a coder this EA looks like a spaghetti western. Keep in mind though that we are talking to non coders too. It is easier to just intialize the global variables locally. If this EA is any good someone should do a serious rewrite, I'm sure more issues, dare I say bugs, will surface.

Paul

Pooler wrote:Thanks all,

Here's that last GU trade after NFP. See what I mean re OR levels acting as S/R levels. Which kinda makes sense as they are derived from the Average Daily Range.

Just per info. For three months (April, May June) I demo-traded a $ 1000 account with 25 pairs with the aim of making $15 per day. My goal was 10 pairs to fill each day starting at .01 lots making an av of $ 1.50 per day (per pair) x av. of 20 trading days = $ 300 per month which is 30% growth per month. I ended on $1921 after the 3 months then upped my starting lot size to .02 and promptly *Eish* blew my account.

Therein I suppose is the lesson...what is the correct money management discipline here.

Baluda wrote:I found this code issue:

Code: Select all

void CalculateADR()
{
   int i=0;

   R1 =  (iHigh(NULL,PERIOD_D1,1)-iLow(NULL,PERIOD_D1,1))/Point;
   for(i=1;i<=5;i++)
      R5    =    R5  +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
   for(i=1;i<=10;i++)
      R10   =    R10 +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
   for(i=1;i<=20;i++)
      R20   =    R20 +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
...

Variables R5, R10 and R20 are NOT initialized. Please change to this:

Code: Select all

void CalculateADR()
{
   int i=0;
   R1 = 0;
   R5 = 0;
   R10 = 0;
   R20 = 0;

   R1 =  (iHigh(NULL,PERIOD_D1,1)-iLow(NULL,PERIOD_D1,1))/Point;
   for(i=1;i<=5;i++)
      R5    =    R5  +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
   for(i=1;i<=10;i++)
      R10   =    R10 +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
   for(i=1;i<=20;i++)
      R20   =    R20 +  (iHigh(NULL,PERIOD_D1,i)-iLow(NULL,PERIOD_D1,i))/Point;
...

and recompile.

Paul

Baluda wrote:

dlewisfl wrote:There are other variables defined globally that should be defined locally, as well as other inefficiencies (e.g. not using arrays and copy/pasting code unnecessarily, the number of times he reads through the order pool each tick, using the error message function in the source instead of using an include, needlessly defining variables). The source file for this EA could easily be ~500 lines instead of the 1400+ and be much more efficient.

You are right, for a coder this EA looks like a spaghetti western. Keep in mind though that we are talking to non coders too. It is easier to just intialize the global variables locally. If this EA is any good someone should do a serious rewrite, I'm sure more issues, dare I say bugs, will surface.

Paul

void subSaveValues() {
   CalculateADR();
   double Bdistance = BUY_OR,
          Sdistance = SELL_OR,
          Btp = Bdistance * (BTP_Percent * 0.01),
          Stp = Sdistance * (STP_Percent * 0.01);
   GlobalVariableSet(OP,NormalizeDouble(iOpen(Symbol(),0,0),Digits));
   GlobalVariableSet(BDIST,NormalizeDouble(Bdistance,0));
   GlobalVariableSet(SDIST,NormalizeDouble(Sdistance,0));
   GlobalVariableSet(BTP,Btp);
   GlobalVariableSet(STP,Btp);
   return;
}