| stevehopwoodforex.com https://www.stevehopwoodforex.com/phpBB3/ Print view |
|
| Shelley's multi-pair basket trader https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=583 |
Page 41 of 87 |
| Author: | forexripper [ Wed May 30, 2012 3:51 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
No I am not. I have around 23 charts open with no candles or indicators on them and just the EA. Still so slow. Why is JSL not working. Any thoughts? |
|
| Author: | maudur [ Wed May 30, 2012 4:10 pm ] |
| Post subject: | Possible Shelley's error |
Hi Steve, Thank you very much for all your kind cooperation. I have reviewed the EA Shelley and I think there is an error in the following code: //Detect previous slope if (ShelleyPlusGary) { double Slope = GetSlope(symbol, TimeFrame, 1); string PrevSlope = nottradable; if (Slope < 0.8) PrevSlope = buy; if (Slope > -0.8) PrevSlope = sell; }//if (ShelleyPlusGary) If the previous slope was for example 0.7, PrevSlope will be sell and not buy because 0.7 is greater than -0.8. I think the correct code should be: //Detect previous slope if (ShelleyPlusGary) { double Slope = GetSlope(symbol, TimeFrame, 1); string PrevSlope = nottradable; if (Slope < 0.8 && Slope > 0) PrevSlope = buy; if (Slope > -0.8 && Slope < 0) PrevSlope = sell; }//if (ShelleyPlusGary) Thank you very much. |
|
| Author: | mackaozy [ Wed May 30, 2012 4:26 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Hi.. I thought that in fact the forex market is in a ranging period at the moment..so this will only get better..someone please correct me if I am wrong.. |
|
| Author: | mackaozy [ Wed May 30, 2012 4:29 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Cheers SWG123..! I traded the US market open today at 1pm in an effort to break this bot...results below.. I'm stunned..Results below... |
|
| Author: | droland [ Wed May 30, 2012 4:33 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
I am having the same problem. No trades on the S+G settings. Same EA works great on the Shelley only settings. Very much interested in trying the S+G mode however. Good luck in tracking the problem. |
|
| Author: | SWG123 [ Wed May 30, 2012 4:47 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Well, the market both trends and ranges at all times - it just depends what timeframe you are looking at. Here, of course, we are mainly concerned with daily action. When a pair reverses direction, will the TMA Slope indi alert us quickly enough, or will we get caught on the wrong side of a series of trades? I think that is the question Caillou is asking. |
|
| Author: | Caillou [ Wed May 30, 2012 4:50 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
If Selley EA is closing baskets in profit no matter when you put it on the chart with the same pairs and the same order types (Sell EUR and GBP, Buy USD)..........sure the market is trending. |
|
| Author: | Armen [ Wed May 30, 2012 4:54 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Hello garyfritz, frankly speaking I have absolutely no experience in coding things in MQL. My question may appear silly but I thought this should be true for sell part also. Code: Select all |
|
| Author: | garyfritz [ Wed May 30, 2012 5:42 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Yup. That was the bug I mentioned earlier. Not quite -- as I understand it anyway, Slope should be >= 0.8 for a buy, <= -0.8 for a sell. But you ARE right that there's a bug in there that I didn't see before. Steve got the tests backwards: if (Slope < 0.8) PrevSlope = buy; I'm now running with both these fixes. They didn't open up a dozen trades instantly, so that's a good sign. I'll let you know if it seems to work. Remember, though, I don't think it makes a lot of sense to trade this approach as a basket, so I'm not sure how well this is going to work. Meanwhile if anybody else wants to test it, you can just replace LookForTradingOpportunities() with this code: Code: Select all |
|
| Author: | blahn [ Wed May 30, 2012 6:20 pm ] |
| Post subject: | Re: Shelley's multi-pair basket trader |
Since we're using slope triggers for S & G entries, we could use them for stacking as well. Enter at .8, stack at .9, stack at 1, again at 1.1, etc. |
|
| All times are UTC | Page 41 of 87 |
|
Powered by phpBB® Forum Software © phpBB Limited |
|