Those of you trying the Experimental version and Recovery already know that it is not working.
I returned to the code and found lots that was wrong. Here is a fully commented copy of the updated code. Would you codeslingers run your eyes over it, please, and see if you can spot anything obviously wrong? THe function is called just after the call to CountOpenTrades(symbol, PairIndex), so the bot has a picture of the open position.
Code: Select all bool HaveWeHitRecoveryTarget(string symbol, int type)
{
//Calculate the Recovery target and close the trades if the target price is reached.
GetBasics(symbol);//Probably not needed, but no harm to check.
int cc = 0;
RecoveryTargetPrice = 0;
if (type == OP_BUY)
{
//Add together the price of all the market trades
for (cc = 0; cc < ArraySize(BuyTickets); cc++)
{
if (!BetterOrderSelect(BuyTickets[cc], SELECT_BY_TICKET, MODE_TRADES) )
continue;//Just in case
//Buy ticket numbers are sorted in ascending order at the end of CountOpenTrades()
if (cc == 0)//Set RecoveryTargetPrice first time around the loop
RecoveryTargetPrice = OrderOpenPrice();
else
RecoveryTargetPrice+= OrderOpenPrice();//Add the next order price to RecoveryTargetPrice
}//for (cc = 0; cc < ArraySize(BuyTickets); cc++)
//Divide this figure by the ticket array size to arrivc at the breakeven price
RecoveryTargetPrice/= ArraySize(BuyTickets);
RecoveryTargetPrice+= (RecoveryProfitP / factor);//Add the lock-in profit pips
//Has the market reached this target? Using bid because buys close at the Bid
if (bid >= RecoveryTargetPrice)
return(true);
}//if (type == OP_BUY)
if (type == OP_SELL)
{
//Add together the price of all the market trades
for (cc = 0; cc < ArraySize(SellTickets); cc++)
{
if (!BetterOrderSelect(SellTickets[cc], SELECT_BY_TICKET, MODE_TRADES) )
continue;//Just in case
//Sell ticket numbers are sorted in descending order at the end of CountOpenTrades()
if (cc == 0)
RecoveryTargetPrice = OrderOpenPrice();
else
RecoveryTargetPrice+= OrderOpenPrice();//Subtract the next order price from RecoveryTargetPrice
}//for (cc = 0; cc < ArraySize(BuyTickets); cc++)
//Divide this figure by the ticket array size to arrivc at the breakeven price
RecoveryTargetPrice/= ArraySize(SellTickets);
RecoveryTargetPrice-= (RecoveryProfitP / factor);//Add the lock-in profit pips
//Has the market reached this target? Using ask because sells close at the Ask
if (ask <= RecoveryTargetPrice)
return(true);
}//if (type == OP_SELL)
//Got this far, so no closure
return(false);
}//bool HaveWeHitRecoveryTarget(string symbol, int type)
  |
