I adjusted BE to 250 +100 and Jump to 500

I just noticed that the most recent trade (6th) is continuously sending modify orders
changing the TP from 1.03105 to 1.56428 and back also SL from 1.65744 to 1.73682 and back

These orders are now closed. It opened 6 new orders.
It seems all pip settings are point settings. I need 500 between stacked orders not 50

Moving the TP green line (there are 6). This has no effect on 5 of the trades. Only the TP line for the last (most recent) order causes the TP for that order to change. (feature or bug?)

These trades are not sending the continuous modify orders.

Pat

Hy Pat,

Have the same issues with TP and the constant sending of modify orders. Currently trying to sort it out.

Cheers

trader689 wrote:fxozgirl are you still using the settings you posted a few pages back? if so how are they faring as you were having some really good trades. i am demoing that setfile and currently in drawdown, hope to recover

al3xx wrote:

I adjusted BE to 250 +100 and Jump to 500

I just noticed that the most recent trade (6th) is continuously sending modify orders
changing the TP from 1.03105 to 1.56428 and back also SL from 1.65744 to 1.73682 and back

These orders are now closed. It opened 6 new orders.
It seems all pip settings are point settings. I need 500 between stacked orders not 50

Moving the TP green line (there are 6). This has no effect on 5 of the trades. Only the TP line for the last (most recent) order causes the TP for that order to change. (feature or bug?)

These trades are not sending the continuous modify orders.

Pat[/

Hy Pat,

Have the same issues with TP and the constant sending of modify orders. Currently trying to sort it out.

Cheers

Hello Everobody,

I am new here and to fx in general. I have to say kudos for all the good work and am hoping to learn alot from here.

I encountered a similar problem with weird stop loss behaviour and 6 trades opening in quick succession. I am on a 5 digits demo.

I think I have seen the problem with opening many trades quickly even when MinStackTradePipsDistance is set reasonably, say to 50 and also the weird moving of the JumpingStop.

The thing is the code that sets the pips multiplier based on Digits from your criminal is commented out in the init function.

The intention was probably to use 'factor' (a different way to achieve the same thing) but this is not done in all parts of the code and many calculations still use Point.

The solution would now be to use factor in all the Pips calculation. I am going to try this modification and see what happens.

Regards.

Jemook wrote:I'm surprised people are still trying to trade this EA with it's lack of support. Steve is working on a new 10.2 EA and I believe focus will shift to maintaining the new one. Hang in there guys.

trader689 wrote:hey jemook have you got any more details about the new 10.2 ea, like what are the main changes and where we can read more about it? thanks

If you get the management functions sorted, can you post it? the bot is great for allowing me to sleep and not miss trades. It would be awesome to have the management functions working correctly.

if (OpenTrades > 0)
   {
      if (!OkToStack(type)) return;
   }//if (OpenTrades > 0)

if (bias == up)
      {
         if (Bid > BbLower)
         {
            if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
            {
               if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit * Point))
               {
                  SendLong = true;
                  TradeOrigin = BbRangeTrade;//TradeOrigin is used by CalculateTakeProfit()
                  magic = BbRangeTradeMN;
                  comment = BbRangeTradeComment;
               }//if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit * Point))                  
            }//if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
         }//if (Bid > BbLower)    
      }//if (bias == up)

if (Bid > BbLower)
         {
            if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
            {
               if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit / factor))
               {
                  SendLong = true;
                  TradeOrigin = BbRangeTrade;//TradeOrigin is used by CalculateTakeProfit()
                  magic = BbRangeTradeMN;
                  comment = BbRangeTradeComment;
               }//if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit / factor))                  
            }//if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
         }//if (Bid > BbLower)    

al3xx wrote:

If you get the management functions sorted, can you post it? the bot is great for allowing me to sleep and not miss trades. It would be awesome to have the management functions working correctly.

Here you have it. I changed all the places using Point to use factor instead. Will see in the coming week how it goes.

I also fixed the function LookForD1TrendTrade to check if it is okay to stack trades if a trade already exists just like it is done in LookForD1H4TrendTrade. I added this...

Code: Select all

if (OpenTrades > 0)
   {
      if (!OkToStack(type)) return;
   }//if (OpenTrades > 0)

Yes, this EA is great for not missing entries. Thanks Steve!

I think there is a bug in the LookForBbRangeTrade function that prevents the EA from entering any BB range trades when EnforcePivotIntegrity is enabled. Has anyone had such an entry from this EA?

I mean, for a Buy, it checks if bias is 'up'. That would mean price is above both monthly and weekly pivots. Then to enter, it will check if Bid is less than Weekly pivot and also check distance between lower B band and Weekly Pivot. That will never be true. The code ...

Code: Select all

if (bias == up)
      {
         if (Bid > BbLower)
         {
            if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
            {
               if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit * Point))
               {
                  SendLong = true;
                  TradeOrigin = BbRangeTrade;//TradeOrigin is used by CalculateTakeProfit()
                  magic = BbRangeTradeMN;
                  comment = BbRangeTradeComment;
               }//if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit * Point))                  
            }//if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
         }//if (Bid > BbLower)    
      }//if (bias == up)

Not in the attached EA, but I have changed it to ...

Code: Select all

if (Bid > BbLower)
         {
            if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
            {
               if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit / factor))
               {
                  SendLong = true;
                  TradeOrigin = BbRangeTrade;//TradeOrigin is used by CalculateTakeProfit()
                  magic = BbRangeTradeMN;
                  comment = BbRangeTradeComment;
               }//if (Bid < WeeklyPivot && WeeklyPivot - Bid >= (MinimumRangeTakeProfit / factor))                  
            }//if (iLow(NULL, BbTimeFrame, 0) < BbLower || iLow(NULL, BbTimeFrame, 1) < BbLower)
         }//if (Bid > BbLower)    

Will see if I get some BB trades in the coming week. Looking forward to see how the BB trades perform.

Kind Regards,

Alex

phil_trade wrote:Good job Alex

please, share mq4 file, so we can do backtest to verify if BB trade is ok