gaheitman wrote:Mike,

I think the issue is with your error filter. You currently have:

Code: Select all

            if (err!=0||err!=1)

With this, if err = 1, the err!=0 side will evaluate to true, which makes the whole statement true.

I think you want to say:

Code: Select all

            if (err!=0 && err!=1)

Or you could say:

Code: Select all

            if (!(err==0||err==1))

But that's not exactly easier to read. :> Perhaps a simple:

Code: Select all

            if (err>2)

I saw it quite a few times before the switch went off.

George

            if (err>1)

magft wrote:

gaheitman wrote:Mike,

I think the issue is with your error filter. You currently have:

Code: Select all

            if (err!=0||err!=1)

With this, if err = 1, the err!=0 side will evaluate to true, which makes the whole statement true.

I think you want to say:

Code: Select all

            if (err!=0 && err!=1)

Or you could say:

Code: Select all

            if (!(err==0||err==1))

But that's not exactly easier to read. :> Perhaps a simple:

Code: Select all

            if (err>2)

I saw it quite a few times before the switch went off.

George

George as usual your help has pointed out the obvious blunder in my logic, though i have chosen

Code: Select all

            if (err>1)

as i am not sure what error code 2 means. I had this running a few hrs now and no more errors

UPDATE in post #1.

Tex, i'll look into later on, i have had a few losing trades and now 3 winners, have you put a value in the ATR section as this overrides other settings?

Mike

magft wrote: George as usual your help has pointed out the obvious blunder in my logic, though i have chosen

Code: Select all

            if (err>1)

as i am not sure what error code 2 means. I had this running a few hrs now and no more errors


Mike

gaheitman wrote:

magft wrote: George as usual your help has pointed out the obvious blunder in my logic, though i have chosen

Code: Select all

            if (err>1)

as i am not sure what error code 2 means. I had this running a few hrs now and no more errors

Mike

I meant "err>1", I just mistyped. Though apparently error # 2 is ERR_COMMON_ERROR, which, as you probably guessed stands for "Common error." I think it means your crappy broker can't give you a good data feed so keeps disconnecting you. At least that is what I am getting from Cowboy IBFX this morning. grrrr.

George

magft wrote: Can you have a look at the Breakeven code as there is still an error. I have a loop now that the is changing the SL from the early one to the updated one i think. Some thing in the logic is wrong but
i cant look at it now, got to do the day job!

Also, i think in LookForTradingOpportunities where we set the price based on high/low of previous candle, i'm wondering if tex's problem is to do with how we add the sl/tp to the calculated price for POs.

I really must get on, but this is more fun than thermodynamic calculations

Mike

I like the way the profits run if we go further on, nice addition Dragos from spider ea.

DragosDanescu wrote:

I like the way the profits run if we go further on, nice addition Dragos from spider ea.

No, it's not from Spider. But can be implemented into any EA. It was just an ideea I implemented for testing. It's useful, in situations like this one, when price is climbing like crazy. But sometimes, ExtendTP prevent you to close a trade at full TP.

tex wrote:Dragos, Mike,

i think theres a bug in the new 2.5 EA. Look at screenshots. In my EU trade i set the TP=20 and SL=25 acording to the rules. The EA opened a trade but the TP was set to about 14,9P only. Same in the recent EJ trade.
I set the EA to Tp=20, SL = 20. But the EA opened the trade with TP = 15,6p, SL = 32,4p ??

Can u check this please.

thanks