glabbeek wrote:Recently you added the trailpercent exit. This method of exit already locked in many profits for us and is a good addition to the strategy.

I'm wondering why you opted for using the basket method. I never understood the use of using baskets and nobody has ever been able to show me the advantage of using baskets.

You only should manage your account, that is your basket!

If I would say to you: "The AUDCAD is up 5%, so buy GBPCHF, NZDUSD and EURJPY", would you think is logical? probably not. So why would you accept this on the exit side?

Let's say you have a basket that is performing good. It has 5 pairs in the basket and 4 are each up 4 percent and rising. (so 16 percent total) One stock is going down 5 percent. What would you like to happen? Close the whole basket, or just the one losing pair?

MrLong wrote: You could try GridMethod set to 1.

Andy

simplex wrote: Linus,

could you try the following and give me some feedback about the error:

In the globals declaration section:

Code: Select all

int    wide = 9;
int    wide2 = 5;      // insert this line
string headerString[] = { "PAIR:", "CHART:", "TREND:", "AO:", "STOCH:", "PRO:", "STOP-TRADES:", "" , "  OPEN-TRADES:"  , "                CORRELATED PAIRS:"};
string headerString2[] = { "LOTS:","PIPS:", "CASH:", "B-EVEN:", "ASK:"};

and in function CreateGrid:

Code: Select all

    for (int x = 0; x < wide + 1; x++)
    {
        sObj = "textheader" + x;
        LabelCreate(sObj, corner, gridCol1[x] + offsetX2, offsetY - 20);
        LabelSetText(sObj, headerStr[x], fontSize, headerfont, headertextColor);
    }

    for (x = 0; x < wide2 + 1; x++)       // change from wide to wide2
    {
        sObj = "header2" + x;
        LabelCreate(sObj, corner, gridCol2[x] + offsetX2, offsetY - 20);
        LabelSetText(sObj, headerStr2[x], fontSize, headerfont, headertextColor);
    }

Background:
Andy used variable wide for his loops over both arrays headerstring and headerstring2. headerstring2 actually has only 5 elements. I adopted this method without thinking about possible consequences (copy and paste ... ). IMO this should lead to more runtime errors than we are actually facing. Why only Linus?

@Andy: maybe it would be better to change this in DisplayGrid() also.

@Linus: hoping for your feedback about this hack.

simplex

glabbeek wrote:Hi Andy,

I'm still following your efforts on this complex EA.

Recently you added the trailpercent exit. This method of exit already locked in many profits for us and is a good addition to the strategy.

I'm wondering why you opted for using the basket method. I never understood the use of using baskets and nobody has ever been able to show me the advantage of using baskets.

You only should manage your account, that is your basket!

If I would say to you: "The AUDCAD is up 5%, so buy GBPCHF, NZDUSD and EURJPY", would you think is logical? probably not. So why would you accept this on the exit side?

Let's say you have a basket that is performing good. It has 5 pairs in the basket and 4 are each up 4 percent and rising. (so 16 percent total) One stock is going down 5 percent. What would you like to happen? Close the whole basket, or just the one losing pair?

Just my thought.

simplex wrote:

linuspoon wrote:

simplex wrote:Hi Linus,

I never faced this error - neither on my development machine nor on test.

Can you provide ANY information about the circumstances this error occurs? Only on EA startup? On every tick? After trade open? After trade close? ... etc. The more detail you can provide the better. Already did a code review, found nothing ...

Cheers, simplex

This error only occurs in one of my demo Empty4 but not on another one. The error occurs once the EA starts. On every tick (may not be every tick but there are a number of errors within 1 min interval), the same error will appear in the Expert tab one line after another continuously until either I stopped the EA or change the GridMethod to 1 or if I set showDisplay to false.

Linus

Linus,

could you try the following and give me some feedback about the error:

In the globals declaration section:

Code: Select all

int    wide = 9;
int    wide2 = 5;      // insert this line
string headerString[] = { "PAIR:", "CHART:", "TREND:", "AO:", "STOCH:", "PRO:", "STOP-TRADES:", "" , "  OPEN-TRADES:"  , "                CORRELATED PAIRS:"};
string headerString2[] = { "LOTS:","PIPS:", "CASH:", "B-EVEN:", "ASK:"};

and in function CreateGrid:

Code: Select all

    for (int x = 0; x < wide + 1; x++)
    {
        sObj = "textheader" + x;
        LabelCreate(sObj, corner, gridCol1[x] + offsetX2, offsetY - 20);
        LabelSetText(sObj, headerStr[x], fontSize, headerfont, headertextColor);
    }

    for (x = 0; x < wide2 + 1; x++)       // change from wide to wide2
    {
        sObj = "header2" + x;
        LabelCreate(sObj, corner, gridCol2[x] + offsetX2, offsetY - 20);
        LabelSetText(sObj, headerStr2[x], fontSize, headerfont, headertextColor);
    }

Background:
Andy used variable wide for his loops over both arrays headerstring and headerstring2. headerstring2 actually has only 5 elements. I adopted this method without thinking about possible consequences (copy and paste ... ). IMO this should lead to more runtime errors than we are actually facing. Why only Linus?

@Andy: maybe it would be better to change this in DisplayGrid() also.

@Linus: hoping for your feedback about this hack.

simplex

slipshod wrote:

taggie11 wrote:I loaded v2 yesterday OOTB onto an FXCM demo and it had a very bad day - over 5% down. IS this
a) usual variance and I just turned on wrong day or
b) an error somewhere in my set up ie did anyone else have a negative day yesterday?

Hi Doc, I've got it running on several demo accounts, one of which is linked in my sig below. Yesterday wasn't great, and so far today's been no picnic either - but on the other hand there's been days where it's gone gangbusters. I haven't experienced 8% DD yet though, but as each Empty4 instance seems to take different trades its certainly possible - and that's the one thing I don't feel comfortable about with this EA, the fact that the trades taken seem to vary so much. For instance, about an hour ago my Cowboy IBFX demo went long on USDCHF at 0.948 and is now 30 pips in profit, whereas my other demos only have buy stops higher up at 0.952.

Anyway, my guess is you started on a bad day. I'm expecting this will need weeks/months of solid forward testing to get a real feel for whether or not it'll be consistently profitable.

slipshod wrote:

taggie11 wrote:I loaded v2 yesterday OOTB onto an FXCM demo and it had a very bad day - over 5% down. IS this
a) usual variance and I just turned on wrong day or
b) an error somewhere in my set up ie did anyone else have a negative day yesterday?

Hi Doc, I've got it running on several demo accounts, one of which is linked in my sig below. Yesterday wasn't great, and so far today's been no picnic either - but on the other hand there's been days where it's gone gangbusters. I haven't experienced 8% DD yet though, but as each Empty4 instance seems to take different trades its certainly possible - and that's the one thing I don't feel comfortable about with this EA, the fact that the trades taken seem to vary so much. For instance, about an hour ago my Cowboy IBFX demo went long on USDCHF at 0.948 and is now 30 pips in profit, whereas my other demos only have buy stops higher up at 0.952.

Anyway, my guess is you started on a bad day. I'm expecting this will need weeks/months of solid forward testing to get a real feel for whether or not it'll be consistently profitable.

SWG123 wrote:

MrLong wrote: You could try GridMethod set to 1.

Andy

Nope, that doesn't work either, still not picking up the second trade.