cla4ss wrote:Hi Steve. Thank you for the EA. Get this error all the time while testing "Graeme EURUSD,H1: OrderModify error 130". Can you plese fix it?

• At the start of each new CatTimeFrame candle, move the stop of an open trade one candle to the right - low of the candle for a buy, and high for a sell. This means the stops of a basket of trade will move along caterpillar style, rather than all bunching x pips below the price (buy) or above (sell).
  G uses Global Variables to keep track of the open time of the relevant candle so it knows which shift value to use. G cannot apply a cat stop to existing trades, as they do not have a GV.

MichaelM wrote:Hi Steve,

Been playing around with the Risk based lot size code.

I've got it working for G so that the lot size is always divisible by 2:

Add the following external variable:

Code: Select all

extern int     LotDivider = 2;   // <<---- MichaelM ADD (don't change the value for Graeme!)

...then UNcomment the "Stop Loss calculator" line in both HasBuyFilled() and HasSellFilled()
i.e. HasBuyFilled()

Code: Select all

//Stop loss calculator
if (StopLoss > 0) stop = NormalizeDouble(price - (StopLoss * Point), Digits);  // <<---- MichaelM MOD (removed comment symbols)

...then add the following line after the "Risk based lot calculator" line as follows

Code: Select all

//Risk based lot calculator
if (RiskPercent > 0) SendLot = CalculateLotSize(stop, price);
stop = 0;  // <<---- MichaelM ADD (To preserve the hidden SL feature)

...and finally modify the CalculateLotSize function as follows:

Code: Select all

double CalculateLotSize(double price1, double price2)
{
   //Calculate the lot size by risk. Code kindly supplied by jmw1970. Nice one jmw.
   
   if (price1 == 0 || price2 == 0) return(Lot);//Just in case
   
   double FreeMargin = AccountFreeMargin();
   double TickValue = MarketInfo(Symbol(),MODE_TICKVALUE) ;
   double LotStep = MarketInfo(Symbol(),MODE_LOTSTEP);
   
   double SLPts = MathAbs(price1 - price2);
   SLPts/= Point;
   
   double Exposure = SLPts * TickValue; // Exposure based on 1 full lot

   double AllowedExposure = (FreeMargin * RiskPercent) / 100;
   
   int TotalSteps = ((AllowedExposure / Exposure) / LotStep);
   double LotSize = TotalSteps * LotStep;
   
   /** MichaelM ADD START **/
   if (LotDivider > 0) {
     TotalSteps = MathFloor(TotalSteps / LotDivider) * LotDivider;
     LotSize = TotalSteps * LotStep;
   }
   /** MichaelM ADD END **/
   
   double MinLots = MarketInfo(Symbol(), MODE_MINLOT);
   double MaxLots = MarketInfo(Symbol(), MODE_MAXLOT);
   
   if (LotSize < MinLots) LotSize = MinLots;
   if (LotSize > MaxLots) LotSize = MaxLots;
   
   return(LotSize);

}//double CalculateLotSize(double price1, double price1)

To see the actual lotsize G wants to use, modify the EA comments code as follows:

Code: Select all

/** MichaelM MOD START **/
if (RiskPercent > 0) {
   ScreenMessage = StringConcatenate(ScreenMessage,Gap, "Lot size based on ", StopLoss, " points and ", RiskPercent, "% risk: ", CalculateLotSize(Bid, Bid+(StopLoss*Point)));
} else {
   ScreenMessage = StringConcatenate(ScreenMessage,Gap, "Lot size: ", Lot);
}
ScreenMessage = StringConcatenate(ScreenMessage," (Criminal's minimum lot size: ", MarketInfo(Symbol(), MODE_MINLOT), ")", NL);
/** MichaelM MOD END **/

MichaelM wrote:No worries.

I also found an issue that's somehow related to the crappiness of Empty4.

This code here inside init():

Code: Select all

   StopLoss*= multiplier;
   .
   .
   .
   MaxPendingPipsFromMarket*= multiplier;
   MinPipsBetweenTrades*= multiplier;
   TpAdjustment*= multiplier;
   MinTp*= multiplier;

will keep multiplying and multiplying each time you bring up the Expert properties and press okay, because they are not external variables.

To see this for yourself, implement my Risk based lot size code mods above and use a RiskPercent > 0
Then open up the expert properties and press okay and repeat.
You will notice each time you do this the *= multiplier; code will add an extra 0 say from, "Lot size based on 1000 points" (where 1000 points is the StopLoss variable hardcoded to 100 pips)...

...to instead making it say, "1000000 points" after you repeat the step three times.

To get around this, you will need to modify that code as follows:

Code: Select all

   StopLoss = 100;
   StopLoss*= multiplier;

   MaxPendingPipsFromMarket=150;
   MaxPendingPipsFromMarket*= multiplier;
   
   MinPipsBetweenTrades=90;
   MinPipsBetweenTrades*= multiplier;
   
   TpAdjustment=100;
   TpAdjustment*= multiplier;
   
   MinTp=50;
   MinTp*= multiplier;

MichaelM wrote:No worries.

I also found an issue that's somehow related to the crappiness of Empty4.

This code here inside init():

Code: Select all

   StopLoss*= multiplier;
   .
   .
   .
   MaxPendingPipsFromMarket*= multiplier;
   MinPipsBetweenTrades*= multiplier;
   TpAdjustment*= multiplier;
   MinTp*= multiplier;

will keep multiplying and multiplying each time you bring up the Expert properties and press okay, because they are not external variables.

To see this for yourself, implement my Risk based lot size code mods above and use a RiskPercent > 0
Then open up the expert properties and press okay and repeat.
You will notice each time you do this the *= multiplier; code will add an extra 0 say from, "Lot size based on 1000 points" (where 1000 points is the StopLoss variable hardcoded to 100 pips)...

...to instead making it say, "1000000 points" after you repeat the step three times.

To get around this, you will need to modify that code as follows:

Code: Select all

   StopLoss = 100;
   StopLoss*= multiplier;

   MaxPendingPipsFromMarket=150;
   MaxPendingPipsFromMarket*= multiplier;
   
   MinPipsBetweenTrades=90;
   MinPipsBetweenTrades*= multiplier;
   
   TpAdjustment=100;
   TpAdjustment*= multiplier;
   
   MinTp=50;
   MinTp*= multiplier;

MichaelM wrote:Hi Steve,

Just noticed that this line will be affected by my risk based lot size code mod as it's directly referencing the variable "Lot"

Code: Select all

if (Bid >= take && take > 0 && OrderLots() == Lot) HalfCloseThisTrade = true;

My quick fix is the following as Empty4 changes the order comment when partially closing a trade:

Code: Select all

if (Bid >= take && take > 0 && OrderComment() == TradeComment) HalfCloseThisTrade = true;

Don't forget to do this for the Sell trade section as well!

MichaelM