Holy Graily Bob

Post by **art** » Fri Mar 13, 2015 3:07 pm

maybe you should cut back on the pairs, i'm using al's pairs, minus eurgbp,

Amanecer · Post by **Amanecer** » Fri Mar 13, 2015 5:20 pm

I have been looking at the Holy Graily Bob v1b EA implementation recently and I noticed a few minor issues with the code.

Line 1329. IsPairTradable() – wrong check on counters?

It seems that the current implementation does not match the comment in the beginning of the method and is error-prone in non-standard situations. Perhaps it should be replaced with

if (c1open + c2open >= 2)

Line 802. MultiTradeLot check is missing

The code makes “idiot checks” if the MainTradeLot is less than the min lot size. However a similar check is not made for MultiTradeLot.

The lot size parameters are specified in points while everything else is in pips

I trade with a 5-digit broker. So in my case 1pip = 10 points. While the code handles all money management parameters in pips, the lot size is not adjusted and passed to the broker as is when placing an order. So the lot sizes are effectively in points. In my case it means that the default lot size of 0.01 becomes 0.001/pip, which is less than the min lot size allowed by most brokers. Perhaps, it makes sense to treat the lot size parameters as if they are in pips for consistency between different brokers.

Line 1974. Extra GetNext20() call

There is GetNext20() call at the line 1974. However there is no matching call in the corresponding “long” section around line 1933. Is it intentional?

Foreverforex · Post by **Foreverforex** » Fri Mar 13, 2015 5:26 pm

Good learning first week. Trade 14 pairs. 4hr TF. ATC Demo.

Up 500+ pips, $100+ dollars on $4k demo account. Would have been $300+ if I hadn't typoed lot sizing on AUDNZD and taken big dollar loss. Friday pulled through with a lot of wins. Will keep on demo for several more weeks to see how to handle the markets and continue to make my own stupid mistakes with paper money!

031315_closed.jpg

Post by **tonyharmony** » Fri Mar 13, 2015 9:21 pm

martyw » Sat Mar 14, 2015 12:49 am wrote:I have different results with HGB, OOTB 4H 28pairs, last 3 days -900 pips, broker is Global Prime.
are there any other people with negative results last few days ?

G'day martyw, how are you mate?

What I have found in my experience is the GBPNZD a bit too volatile so I don't trade it on HGB.
It's fine when you are winning with it, but when the market reverses it can easily move 400 pips in the opposite direction...

I noticed your biggest loser was GBPNZD?

Try omitting it and see how you go next week!

Good luck!
Tony

Post by **SteveHopwood** » Fri Mar 13, 2015 10:01 pm

Amanecer » Fri Mar 13, 2015 5:20 pm wrote:I have been looking at the Holy Graily Bob v1b EA implementation recently and I noticed a few minor issues with the code.

Line 1329. IsPairTradable() – wrong check on counters?

It seems that the current implementation does not match the comment in the beginning of the method and is error-prone in non-standard situations. Perhaps it should be replaced with

if (c1open + c2open >= 2)

This code has worked seamlessly and flawlessly for years and was provided by a coder who was (then at least) far better than me. Question if it you want. I don't care what you think.

Line 802. MultiTradeLot check is missing

The code makes “idiot checks” if the MainTradeLot is less than the min lot size. However a similar check is not made for MultiTradeLot.

Ok, so I might include the extra idiot check at some point if I think about it. Tonight, I am in the mood that anybody stupid enough to get that wrong deserves all they get. The original idiot check was a part of my shell code; I added it a long time ago; I no longer think about it. Thanks anyhow.

The lot size parameters are specified in points while everything else is in pips

No they aren't and thank your lucky stars that I am in a good mood tonight. I do not take kindly to having bog-basic code that has worked flawlessly and seamlessly for years questioned by...... Let's leave it their, for your sake ok? Argue if you want, but there is only ever one result from arguing with the forum owner.

Line 1974. Extra GetNext20() call

There is GetNext20() call at the line 1974. However there is no matching call in the corresponding “long” section around line 1933. Is it intentional?

Seems to work. Don't know why it works because I do not understand the code - another thingy donated to me by a far more clever coder than I am.

Thanks for trying to help, but until thingies are proven to be broken here I am not going to fix them. Been down that route already. It helps your cause if you don't actually insult me when posting as well - bear this in mind.

AnotherBrian · Post by **AnotherBrian** » Sat Mar 14, 2015 3:28 am

Amanecer » Fri Mar 13, 2015 12:20 pm wrote:I have been looking at the Holy Graily Bob v1b EA implementation recently and I noticed a few minor issues with the code.

I see you have not posted very much here. I'll give you some heads up, if you want Steve to take heed of your coding suggestions he needs to know you are a master coder, not a tinkerer (like me). There are guys on this board that have been coding for 20 or more years and do it for a living. So you need to be an actual coding "expert" for these guys to take notice. You know what they say, it takes 10,000 hours to be an expert at any one thing.

Post by **renexxxx** » Sat Mar 14, 2015 7:23 am

martyw » Sat Mar 14, 2015 12:49 am wrote:I have different results with HGB, OOTB 4H 28pairs, last 3 days -900 pips, broker is Global Prime.
are there any other people with negative results last few days ?

This is a very strange result and it puzzles me. Below is my final result for last week trading HGB second edition, OOTB (except for HGI_Name=HGI_v16.04 and HgiReadDelaySeconds=30), on all the majors + GJ, also with Global Prime:

Selection_042.jpg

Since my report on Thursday, it did drop back to +1700 PIPs, but recovered to finish the week with +2500 PIPs. May be you just started and finished your test at the time the market was giving back some PIPs, I don't know. Did you have your history loaded properly? Were you using Steve's second edition HGB? It is not normal that one person looses 900 PIPs whilst another person wins 2500 PIPs, in the same period, at the same broker, with the same EA, with the same settings. Something is different. I accept that the feed is slightly different, but that can not explain the difference of 3400 PIPs.

AGT · Post by **AGT** » Sat Mar 14, 2015 8:27 am

Hmmm .. you use only the majors - he uses all 28 pairs ... ?

Post by **renexxxx** » Sat Mar 14, 2015 8:41 am

AGT » Sat Mar 14, 2015 6:27 pm wrote:Hmmm .. you use only the majors - he uses all 28 pairs ... ?

I knew somebody would come up with this thought. That's why I already prepared my answer:

He got for EURUSD: -108 PIPs, I got: +616 PIPs
He got for GBPUSD: -81 PIPs, I got: +397 PIPs
He got for EURJPY: +157 PIPs, I got: +217 PIPs (reasonable)
He got for NZDUSD: -64 PIPs, I got: +150 PIPs
He got for AUDUSD: -64 PIPs, I got +102 PIPs

These are the pairs we both have in common. Still a discrepancy of +1600 PIPs. Makes you wonder.

Post by **SteveHopwood** » Sat Mar 14, 2015 9:21 pm

spgandau spent a lot of time debugging my original HGB with all the bells and whistles.

More to the point, he did a lot of work on the trouble caused to our US members by FIFO - he is a US resident. US citizens might care to take a look at what he is getting up to: http://www.stevehopwoodforex.com/phpBB3 ... 60#p117460

Ditto those of you who wanted all the bells and whistles that I could not make work.

Thanks spgandau. Your work is in the best tradition of SHF.