stevehopwoodforex.com • Gann SQ9 EA

Author:

jjgengis [ Tue May 01, 2012 5:32 pm ]

Post subject:

Re: Gann SQ9 EA

hi AG,

first, thank you very much for this great EA and for all your efforts.

I would suggest a little modify, not substantial but useful.
I feel very uncomfortable when I use money instead of Pips in EA profit input. This because, if I want to change the lotsize, I'm forced to recalculate the Amount34/37 variables, if I want to keep unchanged the exits condition.
So, I wrote this simple modify:

Code: Select all

if (PipsOrBills)
        {
            if (Bid - OrderOpenPrice() >= Amount34 * PipValue * point)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }    
        else
        {        
            if (OrderProfit() >= Amount34)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }

PipsOrBills is an External Bool that switch your choice.

Thus , the closeorder function become so:

Code: Select all

void CloseOrderIf34()
{
    int orderstotal = OrdersTotal();
    int orders = 0;
    int ordticket[30][2];
    for (int i = 0; i < orderstotal; i++)
    {
        OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
        if (OrderType() != OP_BUY || OrderSymbol() != Symbol() || OrderMagicNumber() != 0)
        {
            continue;
        }
        if (PipsOrBills)  // ********************************JJ modify********************************
        {
            if (Bid - OrderOpenPrice() >= Amount34 * PipValue * Point)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }    
        else
        {        
            if (OrderProfit() >= Amount34)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }  // ********************************JJ modify********************************
    }
    if (orders > 1)
    {
        ArrayResize(ordticket,orders);
        ArraySort(ordticket);
    }
    for (i = 0; i < orders; i++)
    {
        if (OrderSelect(ordticket[i][1], SELECT_BY_TICKET) == true)
        {
            bool ret = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 4, Red);
            if (ret == false)
            Print("OrderClose() error - ", ErrorDescription(GetLastError()));
        }
    }
    
}

for the Sell section (37) is enough change the row "if (Bid - OrderOpenPrice() >= Amount34 * PipValue * Point)" with "if (OrderOpenPrice() - Ask >= Amount37 * PipValue * Point)".

Is only a little suggestion.

stevehopwoodforex.com https://www.stevehopwoodforex.com/phpBB3/ Print view

Gann SQ9 EA https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=476	Page 8 of 15

Author:	tamersaid81 [ Fri Apr 27, 2012 10:37 am ]
Post subject:	Re: Gann SQ9 EA
spybreak wrote:It's a very calm week, only 3 trades (AUDJPY, EURJPY and CADJPY) total + 205 pips v4.3.1 205 pips and very calm week hhhhh ok i just need 200 every week

Author:	Kenboi [ Sat Apr 28, 2012 4:54 am ]
Post subject:	Re: Gann SQ9 EA
spybreak wrote: 205 pips and very calm week hhhhh ok i just need 200 every week Kenboi wrote:200-300 pips a week is very good trading. If this keeps going consistently, you will make a lot of money, my friend. Lets keep testing and see Yes , you're right I think i'm too greedy in fact, this is probably because i had nice trades (only profits until now) and i want more ... I prefer less trades but more accurate, for sure, I follow closely this thread for the v4.4 , as the v4.3.1 is great, i imagine the next version ! (Thanks to AG2012 ) Many green pips to all ! Great to hear that from you. Once we get greedy, we will give all the hard earned profit back to the market. It happened to me almost all the time. I am still trading v4.3 CAFA. So far, it's doing pretty good.

Author:	AG2012 [ Tue May 01, 2012 1:50 am ]
Post subject:	Re: Gann SQ9 EA
Hi everyone. I hope that the trades keep going well for you. I have been concentrating all my efforts on (trying) to modify the Gann indi, to suit the new ea's trade trigger inputs. The idea is (for example a BUY order) to have the EA send a trade when it detects that the price has moved up from the "base line" of the indi, and visa-verse. I still have a LONG way to go, so please be patient. Below is a screenshot of how it looks so far.... GannIndiTests.JPG The only problem now is, how to render the "most recent" base line value (the one it displays, is always the very first one at the beginning of the "level" sections paintings). I'm not sure if it's the right "buffer" I'm using, or maybe it needs a object delete "refresh" ? I'm not that good a coder, and this is my first time even trying to mess around with an indi.... Wish me luck, I hope I can do this.... AG

Author:	Kenboi [ Tue May 01, 2012 4:22 am ]
Post subject:	Re: Gann SQ9 EA
AG2012 wrote:Hi everyone. I hope that the trades keep going well for you. I have been concentrating all my efforts on (trying) to modify the Gann indi, to suit the new ea's trade trigger inputs. The idea is (for example a BUY order) to have the EA send a trade when it detects that the price has moved up from the "base line" of the indi, and visa-verse. I still have a LONG way to go, so please be patient. Below is a screenshot of how it looks so far.... GannIndiTests.JPG The only problem now is, how to render the "most recent" base line value (the one it displays, is always the very first one at the beginning of the "level" sections paintings). I'm not sure if it's the right "buffer" I'm using, or maybe it needs a object delete "refresh" ? I'm not that good a coder, and this is my first time even trying to mess around with an indi.... Wish me luck, I hope I can do this.... AG AG, Good idea. I have always thought this EA opens a trade reaches the baseline at the bottom for BUY and at the top for SELL. I am not a coder so I can't really throw in any helpful hints or ideas that I wish I can. I am here wishing you the best of luck on your new idea. Try to ask Steve or other gurus on here. So far, your EA is doing very well. I am going to put this baby on Live very soon. How's your live trading going along?

Author:	AG2012 [ Tue May 01, 2012 12:02 pm ]
Post subject:	Re: Gann SQ9 EA
Kenboi wrote: AG2012 wrote:Hi everyone. I hope that the trades keep going well for you. I have been concentrating all my efforts on (trying) to modify the Gann indi, to suit the new ea's trade trigger inputs. The idea is (for example a BUY order) to have the EA send a trade when it detects that the price has moved up from the "base line" of the indi, and visa-verse. I still have a LONG way to go, so please be patient. Below is a screenshot of how it looks so far.... GannIndiTests.JPG The only problem now is, how to render the "most recent" base line value (the one it displays, is always the very first one at the beginning of the "level" sections paintings). I'm not sure if it's the right "buffer" I'm using, or maybe it needs a object delete "refresh" ? I'm not that good a coder, and this is my first time even trying to mess around with an indi.... Wish me luck, I hope I can do this.... AG AG, Good idea. I have always thought this EA opens a trade reaches the baseline at the bottom for BUY and at the top for SELL. I am not a coder so I can't really throw in any helpful hints or ideas that I wish I can. I am here wishing you the best of luck on your new idea. Try to ask Steve or other gurus on here. So far, your EA is doing very well. I am going to put this baby on Live very soon. How's your live trading going along? Hi Ken. I haven't been trading at all. Just concentrating on this project, but late last night I finally found the right buffer to use. It definitely is the correct signal to use. Now there is another small problem, the Indi works almost perfectly by itself, but when the EA calls it to use it, the numbers disappear, and nothing happens... Don't worry, I'll fix that soon (I hope). Also the finished Indi, probably won't look the same (big numbers labels) as in the picture I posted. Soon now I think.... Soon....

Author:	Kenboi [ Tue May 01, 2012 9:51 pm ]
Post subject:	Re: Gann SQ9 EA
JJ, It's great to see you chime in with nice changes in the coding. Lets see what AG has to say about this changes. I hope you can help AG out to improve this EA because this EA is very solid after my 2 months of demo testing. I have a question regarding high impact news like FMOC, NFP, and Bank's decision. Do you guys think we should close out the trade a few hours before the high impact news come in live? Last night, I saw a huge drop on the RBA decision. That's only because there's a change in rate, otherwise, things weren't as bad. Thanks and cheers!

Author:	goodpip [ Wed May 02, 2012 5:10 am ]
Post subject:	Re: Gann SQ9 EA
Dear AG, Thanks for your effort to create this powerful EA. I'm your follower from WWI and I using 4.3 CAFA, so far it giving me good result on demo. I think I will be trade in live acc soon. Can't wait to test your v4.4 Have a nice day and all the best to you.

Author:	spybreak [ Wed May 02, 2012 7:06 am ]
Post subject:	Re: Gann SQ9 EA
billv wrote:Hi AG V4.31 is the most profitable but only when we change Amount25=25; Amount33=25 It looks like if we don't close the trades at $25, some of them will later reverse and close at a loss. I've done several 15 month tests on EUR/USD and EUR/JPY with 3 criminals and got similar results. I haven't tested it with lower TP values. I'm guessing that if we take profit earlier our success rate will go up. Hi, I wondered if you have changed too the value for the trailingstop 43 (defaut 70) Thanks in advance

All times are UTC	Page 8 of 15
Powered by phpBB® Forum Software © phpBB Limited