stevehopwoodforex.com • Fratelli EA by Dragos and magft

Author:

gaheitman [ Mon Nov 28, 2011 4:12 pm ]

Post subject:

Re: Fratelli EA by Dragos and magft

magft wrote: There is still a bug that needs fixing, maybe to do with BE or TS. If you get a trade context busy it sends the trade, if using ECN, but doesn't set the SL/TP which i think is to do with what George described in earlier post. I'll try and look at this tonight once i have this work finished as the EA is performing well so far but i am keeping an eye on it. If left i'd have had 4 trades with no sl/tp!!!!

I dropped the EA on the 1 minute, 5 minute and 15 minute EURJPY to make sure I generated some trades quickly. I had quite a few errors at initial startup, because the actual arrow candle happened so far from the current price. My BUY_STOP had the TP and SL entered correctly, but my BUY either failed with an error or had them in the wrong place. I modified the code to set the price equal to Ask when the code identifies that price is too close to our target (or past it) and then the TP and SL are calculated from there.

Code: Select all

      if(Ask > NormalizeDouble(price-stoplevel*Point,Digits)) { type = OP_BUY; price = Ask;}     

//and later

      if(Bid < NormalizeDouble(price+stoplevel*Point,Digits)) { type = OP_SELL; price = Bid;}

Once I did that, no more errors.

I'm curious, though, should our target price be set from the high of the arrow bar, or should it be on the high of the first bar where all requirements are met? Wouldn't that always be the previous bar (except in the case of taking a trade the first bar of the day, the signal could have been valid for a while but we weren't trading yet)?

George

stevehopwoodforex.com https://www.stevehopwoodforex.com/phpBB3/ Print view

Fratelli EA by Dragos and magft https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=77	Page 8 of 23

Author:	dynel14 [ Mon Nov 28, 2011 1:36 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
PETE wrote:Hi Dragos/Magft Loaded Version 2.5 but trades are getting error(131) invalid trade volume ,any ideas? maybe the risk is to high for your account balance, try to trade with fixed lots

Author:	magft [ Mon Nov 28, 2011 1:54 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
PETE wrote:Hi Dragos/Magft Loaded Version 2.5 but trades are getting error(131) invalid trade volume ,any ideas? Could also be that your trying to set 0.01 and broker minimum is 0.1 maybe? Or maybe Lotstep is 0.1 and not 0.01. Fixed lot size should solve this. Mike

Author:	magft [ Mon Nov 28, 2011 2:02 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
Well, the wrong ej entry has turned into a winner fortunately. Still needs to be fixed though. Just had a GU PO Buy and a EU Buy open whilst writing this. Mike

Author:	garyfritz [ Mon Nov 28, 2011 2:45 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
gaheitman wrote: DragosDanescu wrote:Why not removing indicator from indicators folder and restart? That's a much better solution. Obviously time for me to make some coffee! I agree George, that was entirely too obvious!! But it wasn't at midnight last night. Thanks Dragos and George!

Author:	PETE [ Mon Nov 28, 2011 2:49 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
Thanks Dynel thats sorted it

Author:	PETE [ Mon Nov 28, 2011 2:50 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
And thanks Magft

Author:	garyfritz [ Mon Nov 28, 2011 3:03 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
PETE, I have the same problem, but ONLY in EURJPY !? I tried setting UseMoneyMgmt to false and that does seem to have fixed it. But I don't understand why -- it was only using a lotsize of 1.93 on a $25k demo account. Furthermore I was getting those order errors in EURJPY when it was heading down with green candles & green MACD so it couldn't have been issuing an entry order. Maybe an exit?? Why am I getting this on EURJPY and not on the other 3?

Author:	magft [ Mon Nov 28, 2011 3:14 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
garyfritz wrote:PETE, I have the same problem, but ONLY in EURJPY !? I tried setting UseMoneyMgmt to false and that does seem to have fixed it. But I don't understand why -- it was only using a lotsize of 1.93 on a $25k demo account. Furthermore I was getting those order errors in EURJPY when it was heading down with green candles & green MACD so it couldn't have been issuing an entry order. Maybe an exit?? Why am I getting this on EURJPY and not on the other 3? There is still a bug that needs fixing, maybe to do with BE or TS. If you get a trade context busy it sends the trade, if using ECN, but doesn't set the SL/TP which i think is to do with what George described in earlier post. I'll try and look at this tonight once i have this work finished as the EA is performing well so far but i am keeping an eye on it. If left i'd have had 4 trades with no sl/tp!!!!

Author:	garyfritz [ Mon Nov 28, 2011 4:17 pm ]
Post subject:	Re: Fratelli EA by Dragos and magft
My understanding is it's on the first bar where all conditions are met. So e.g. if you get a down arrow but the candle is green, you wait until the candle turns red -- then you calculate your PO off the low of the first red candle.

All times are UTC	Page 8 of 23
Powered by phpBB® Forum Software © phpBB Limited