snailbeard wrote:Perhaps instead of adding more and more controls to the current user interface, which is already quite busy, the additional reasons to enable/disable trading could be abstracted, so that users could pass parameters by either file or global variables.
e.g.
"AUDJPY[buy:off;sell:on;r:news]"
"AUDNZD[buy:off;sell:off;r:time]"
"GBPUSD[buy:off;sell:off;r:stophunt]"
"GBPJPY[buy:off;sell:off;r:holiday]"
"USDCHF[buy:off;sell:off;r:SR]"

The main EA could read these parameters
a) on start-up,
b) before submitting a pending order
c) and every minute if there are pending orders or open trades.
(change time frame to force an immediate check)

For example
user A wants disable sell but not buy on several pairs for reason 1
user B wants to disable sells and buys on a number of pairs for reason 2

does the EA need to know why the user wants to set these choices - not necessarily - only if the EA has to log why trading was disabled.

This would allow different users to experiment with different scripts, indicators or EAs for enabling and disabling trading.

Someone might have a script that disables all pairs on Mondays,
someone else might have a script which enables trading only between 5 and 6 am then 10 and 11 am etc

Someone might have a script/EA to enable Asian crosses in one time pair and Euro crosses in another time pair.

So all manner of controls can be met externally without adding more and more complexity to main EA.
This would allow the main EA to stabilise and focus on its core functionality.
Timelords, news trackers and fox hunters could experiment separately and independently without changes to the main EA.

The lessons of these separate controls could eventually be brought together into a sister EA which switches pair trading on and off in the main EA when conditions are not favourable for particular pairs.

candletiger wrote:

veeyem wrote: 2013.04.04 10:09:51 Multi_10_4_EAv1.09 USDSGDm,H4: object name passed to ObjectSetText function cannot be an uninitialized or empty string

Andy,
I think I spotted the problem:

Code: Select all

void UpdateGrid() {
	string sLine = "_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ";		// const on local scope
	string sSig = "signal";																	// "
	string sObj = "";
	string sTxt = "";
	for (int y = 0; y < PairIndex + 1; y++) {
		if ( OrderSelect ( GetTicket( Pairs[y]), SELECT_BY_TICKET) == true )
			sObj = "line" + 1 + y;
			double dMarketInfoBid = MarketInfo (Pairs[y], MODE_BID );
			if (  OrderSymbol() == Pairs[y] && 	OrderType() == OP_BUYSTOP && 	dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) && 	dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )        // select the master Trades
				ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BullishColor);
			else if ( 	OrderSymbol() == Pairs[y] && 	OrderType() == OP_SELLSTOP && dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) && 	dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )  // select the master Trades
				ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BearishColor);
				else
					ObjectSetText ( sObj, "", fontSize + 8, displayfont, gridBackColor); // added to remove the line when conditions are not met.// added mr Long

sObj is empty:

Code: Select all

string sObj = "";

sObj only gets a value if true

Code: Select all

if ( OrderSelect ( GetTicket( Pairs[y]), SELECT_BY_TICKET) == true )
			sObj = "line" + 1 + y;

If result is false, still ObjectSetText() is used.
{}missing after first if()?

/ct

if ( OrderSelect ( GetTicket( Pairs[y]), SELECT_BY_TICKET) == true ) {		// brackets!
	sObj = "line" + 0 + y;
	double dMarketInfoBid = MarketInfo (Pairs[y], MODE_BID );
	if (  OrderSymbol() == Pairs[y] 
			&& OrderType() == OP_BUYSTOP 
			&& dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
			&& dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )        // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BullishColor);
	else if ( OrderSymbol() == Pairs[y] 
				 && OrderType() == OP_SELLSTOP 
				 && dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
				 && dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )  // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BearishColor);
	else
		ObjectSetText ( sObj, "", fontSize + 8, displayfont, gridBackColor); // added to remove the line when conditions are not met.// added mr Long
}

simplex wrote:candletiger,

Great work! I think you are right. IMO brackets should be set like this:

Code: Select all

if ( OrderSelect ( GetTicket( Pairs[y]), SELECT_BY_TICKET) == true ) {		// brackets!
	//sObj = "line" + 0 + y;
	sObj = oName ( "line", 0, y );
	double dMarketInfoBid = MarketInfo (Pairs[y], MODE_BID );
	if (  OrderSymbol() == Pairs[y] 
			&& OrderType() == OP_BUYSTOP 
			&& dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
			&& dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )        // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BullishColor);
	else if ( OrderSymbol() == Pairs[y] 
				 && OrderType() == OP_SELLSTOP 
				 && dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
				 && dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )  // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BearishColor);
	else
		ObjectSetText ( sObj, "", fontSize + 8, displayfont, gridBackColor); // added to remove the line when conditions are not met.// added mr Long
}

Works fine for me.

- simplex

linuspoon wrote:

simplex wrote:candletiger,

Great work! I think you are right. IMO brackets should be set like this:

Code: Select all

if ( OrderSelect ( GetTicket( Pairs[y]), SELECT_BY_TICKET) == true ) {		// brackets!
	//sObj = "line" + 0 + y;
	sObj = oName ( "line", 0, y );
	double dMarketInfoBid = MarketInfo (Pairs[y], MODE_BID );
	if (  OrderSymbol() == Pairs[y] 
			&& OrderType() == OP_BUYSTOP 
			&& dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
			&& dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )        // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BullishColor);
	else if ( OrderSymbol() == Pairs[y] 
				 && OrderType() == OP_SELLSTOP 
				 && dMarketInfoBid > OrderOpenPrice() - 10 / PFactor(Pairs[y]) 
				 && dMarketInfoBid < OrderOpenPrice() + 10 / PFactor(Pairs[y]) )  // select the master Trades
		ObjectSetText ( sObj, sLine, fontSize + 8, displayfont, BearishColor);
	else
		ObjectSetText ( sObj, "", fontSize + 8, displayfont, gridBackColor); // added to remove the line when conditions are not met.// added mr Long
}

Works fine for me.

- simplex

Hi simplex,

Your code has a new function oName which is not defined in the EA. Can you also provide the code for this function? Thanks.

Linus

	sObj = "line" + 0 + y;

if(  RunningTrades(Pairs[y]) > 1 && !useAverageBE )
	ObjectSetText("be" + y,"("+FormatPrice(Pairs[y], calculateBE(Pairs[y]), 2)+")", fontSize, displayfont, Gold);
else if(  RunningTrades(Pairs[y]) > 1 && useAverageBE )
	ObjectSetText("be" + y,"("+FormatPrice(Pairs[y], calculateBE(Pairs[y]), 2)+")", fontSize, displayfont, BearishColor); 
else
	ObjectSetText("be" + y, "", fontSize + 2, "Wingdings", Black);

• What is the logic behind the colours? No BullishColor used?
  Under which condition should BE be displayed? I never noticed this column in forward test.

simplex wrote:Hi Andy,

I have some trouble understanding the following code (line 2863 ff in v2.00):

Code: Select all

if(  RunningTrades(Pairs[y]) > 1 && !useAverageBE )
	ObjectSetText("be" + y,"("+FormatPrice(Pairs[y], calculateBE(Pairs[y]), 2)+")", fontSize, displayfont, Gold);
else if(  RunningTrades(Pairs[y]) > 1 && useAverageBE )
	ObjectSetText("be" + y,"("+FormatPrice(Pairs[y], calculateBE(Pairs[y]), 2)+")", fontSize, displayfont, BearishColor); 
else
	ObjectSetText("be" + y, "", fontSize + 2, "Wingdings", Black);

• What is the logic behind the colours? No BullishColor used?
  Under which condition should BE be displayed? I never noticed this column in forward test.

simplex

MrLong wrote:

simplex wrote:Hi Andy,

I have some trouble understanding the following code (line 2863 ff in v2.00):
...

• What is the logic behind the colours? No BullishColor used?
  Under which condition should BE be displayed? I never noticed this column in forward test.

simplex

haha, sorry that was just to confirm that the break even function was active, gold, not active red is active, but forget that function because I coded that when I was usining fixed lots, I have to re-code when I arrive home.