Your coder will have to be happy to have his/her work circulated widely. Please ask him/her to add an appreciation of his/her work to the code. If it works, I will adopt it into my version in post 1 and I always want coding contributions from outside sources to gain their recognition.

It will have to be proven to be robust first.

   
//extern bool    Trade1PositiveSwapTradesOnly=true;
  extern double  Trade1MinSwapToTrade= -5.0;


   //Look for a sell.
   if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[pairIndex] == shortdirection) //Market must be falling from a PH.
         if (SixthsTradingStatus[pairIndex] == tradableshort)//And must be in the trading area.
            if (TradeShort)//User can control the trading direction
               if (shortSwap >= MinSwapToTrade[pairIndex])
                  if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendShort = true;
                  }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.
               
   //Look for a buy.
   if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[pairIndex] == longdirection) //Market must be rising from a PL.
         if (SixthsTradingStatus[pairIndex] == tradablelong)//And must be in the trading area.
            if (TradeLong)//User can control the trading direction
               if (longSwap >= MinSwapToTrade[pairIndex])
                  if (BrokerAllowsHedging || MarketSellsCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendLong = true;
                  }

PaulBeck » Mon Aug 20, 2018 3:03 am wrote:

Your coder will have to be happy to have his/her work circulated widely. Please ask him/her to add an appreciation of his/her work to the code. If it works, I will adopt it into my version in post 1 and I always want coding contributions from outside sources to gain their recognition.

It will have to be proven to be robust first.

Hi Steve

May I request then for the attached version become the official. It has PositiveSwapOnly removed and replaced with MinSwapToTrade. Something that has helped me in the past few months and no doubt will help in the current climate where most are experiencing DD.

Code: Select all

   
//extern bool    Trade1PositiveSwapTradesOnly=true;
  extern double  Trade1MinSwapToTrade= -5.0;


   //Look for a sell.
   if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[pairIndex] == shortdirection) //Market must be falling from a PH.
         if (SixthsTradingStatus[pairIndex] == tradableshort)//And must be in the trading area.
            if (TradeShort)//User can control the trading direction
               if (shortSwap >= MinSwapToTrade[pairIndex])
                  if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendShort = true;
                  }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.
               
   //Look for a buy.
   if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[pairIndex] == longdirection) //Market must be rising from a PL.
         if (SixthsTradingStatus[pairIndex] == tradablelong)//And must be in the trading area.
            if (TradeLong)//User can control the trading direction
               if (longSwap >= MinSwapToTrade[pairIndex])
                  if (BrokerAllowsHedging || MarketSellsCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendLong = true;
                  }

Does this version contain Gertje's ideas from earlier?

PaulBeck » 21 Aug 2018, 00:19 wrote:

I also have tried to post my results to the test DB, I get a success message on upload but my results are never published. I assumed it was because I was not using an official version and thus being filtered.

PaulBeck » Mon Aug 20, 2018 11:19 pm wrote:

Does this version contain Gertje's ideas from earlier?

Hi Steve

I've looked back to start of June and cannot determine which of Gertje's ideas you are referring to. I also cannot locate my post where it was mentioned. Of my meager 5 posts, I can only locate 4.

The idea was discussed here in POS and in SPB in June and made it into SPB as MaximumAcceptableNegativeSwap June 18th but not POS. I've been adding to my POS since I started using and this version is simply my merge into the latest version "1L"

I also have tried to post my results to the test DB, I get a success message on upload but my results are never published. I assumed it was because I was not using an official version and thus being filtered.

Cheers

Hi Paul,

nothing gets filtered in the database this way. Please PM me with details (template write statement, transmit dates etc.)

Cheers
Thomas

I am no taking this any further. The idea that I should replace my version with yours in post 1 is ridiculous

PaulBeck » Tue Aug 21, 2018 12:37 am wrote:

I am no taking this any further. The idea that I should replace my version with yours in post 1 is ridiculous

Steve

I'm just asking for a more flexible use of the swap filter that was agreed as a great idea in SPB to be included in POS.

//extern bool Trade1PositiveSwapTradesOnly=true;
extern double Trade1MinSwapToTrade= -5.0;

Is the fact that I supplied modified code to save you the effort, a step too far? I'm confused, you request, encourage and promote user input. Accept and praised this improvement for SPB but not POS. Using DiffMerge or similar you can see I've changed nothing accept the parameters, the array processing and pre-trade checks.

No offense intended :hi:

Please point me to where I agreed to this. For sure, it is not a feature of SPB.

PaulBeck » Wed Aug 22, 2018 12:03 am wrote:

Please point me to where I agreed to this. For sure, it is not a feature of SPB.

Slopey Peaky Bob
Postby Redboros » Thu Jun 14, 2018 3:32 pm
Postby SteveHopwood » Thu Jun 14, 2018 7:21 pm
Postby PaulBeck » Fri Jun 15, 2018 3:34 pm
Postby SteveHopwood » Mon Jun 18, 2018 3:17 am

You just chose a different name "MaximumAcceptableNegativeSwap"

Like most, I'm not happy seeing a trade go south with a huge negative swap, but can live with small negative swap in the same situation.

I also use this in AwesomeSS_1d.mq4 if you and c1borg agree...