slipshod wrote:Hi Andy, great work - I'm going to try this out on demo simply because it looks so awesome

One thing I noticed immediately was a continual stream of the following error:-
Multi_10_4_EAv1.06 USDJPY_H4: invalid price for OrderSend function

Might I suggest adding the following three lines of code early in the SendSingleTrade function? The error went away once I inserted these & a slew of pending trades were created.

Code: Select all

	price = NormalizeDouble(price, Digits);
	stop = NormalizeDouble(stop, Digits);
	take = NormalizeDouble(take, Digits);

Also, what timeframe should this be run on, or does it not matter?

allisonmagic wrote:one good thing to add that i noticed it wasn't doing.. is when price moves against your pending, level after level, it should modify your pending up or down 1 level for every level price goes against you. up until it crosses the MA, then just close and recalculate. I've had to manually check these and update the pending orders every 8 to 16 hours

slipshod wrote:

fxdaytrader wrote:No, instead of using NormalizeDouble you should use the following (see HERE for further explanation):

Code: Select all

//Open price for pending order must be adjusted to be a multiple of ticksize, not point, and on metals they are not the same.
//see also http://forum.mql4.com/45425#564188
double NormalizePrice(double p){
  double ts = MarketInfo(Symbol(), MODE_TICKSIZE);
 return(MathRound(p/ts)*ts );
}

Even better ... thanks! Actually my "solution" would have been wrong anyway, as the "Digits" would have related to whatever pair you're running the EA from rather than the pair being traded.

Edit: The EA needs the symbol passed into it, hence the function would need to be...

Code: Select all

double NormalizePrice(string symbol, double p)
{
   double ts = MarketInfo(symbol, MODE_TICKSIZE);
   return(MathRound(p/ts)*ts );
}

and therefore its calls from SendSingleTrade() ...

Code: Select all

price = NormalizePrice(symbol, price);
stop = NormalizePrice(symbol, stop);
take = NormalizePrice(symbol, take);

Thanks, no more errors while sending XAU

Disclaimer: I'm too busy right now to see if this actually works.

ernest02 wrote:I have loaded the EA and am getting an interesting screen full of unexplained characters.

Can anyone help?