gaheitman wrote:Good catch. Yeah, the sequence of events after bringing up the Expert Properties is a bit of a mystery. Personally, I think it should do a complete restart of the application, but all it seems to do is allow you to modify the externs and then it runs deinit() followed by init(). It doesn't reset global variables to their initial values (as shown here) and doesn't reset static variables in any procedures.

George

MichaelM wrote:Hi Steve,

Been playing around with the Risk based lot size code.

I've got it working for G so that the lot size is always divisible by 2:

Add the following external variable:

Code: Select all

extern int     LotDivider = 2;   // <<---- MichaelM ADD (don't change the value for Graeme!)

...then UNcomment the "Stop Loss calculator" line in both HasBuyFilled() and HasSellFilled()
i.e. HasBuyFilled()

Code: Select all

//Stop loss calculator
if (StopLoss > 0) stop = NormalizeDouble(price - (StopLoss * Point), Digits);  // <<---- MichaelM MOD (removed comment symbols)

...then add the following line after the "Risk based lot calculator" line as follows

Code: Select all

//Risk based lot calculator
if (RiskPercent > 0) SendLot = CalculateLotSize(stop, price);
stop = 0;  // <<---- MichaelM ADD (To preserve the hidden SL feature)

...and finally modify the CalculateLotSize function as follows:

Code: Select all

double CalculateLotSize(double price1, double price2)
{
   //Calculate the lot size by risk. Code kindly supplied by jmw1970. Nice one jmw.
   
   if (price1 == 0 || price2 == 0) return(Lot);//Just in case
   
   double FreeMargin = AccountFreeMargin();
   double TickValue = MarketInfo(Symbol(),MODE_TICKVALUE) ;
   double LotStep = MarketInfo(Symbol(),MODE_LOTSTEP);
   
   double SLPts = MathAbs(price1 - price2);
   SLPts/= Point;
   
   double Exposure = SLPts * TickValue; // Exposure based on 1 full lot

   double AllowedExposure = (FreeMargin * RiskPercent) / 100;
   
   int TotalSteps = ((AllowedExposure / Exposure) / LotStep);
   double LotSize = TotalSteps * LotStep;
   
   /** MichaelM ADD START **/
   if (LotDivider > 0) {
     TotalSteps = MathFloor(TotalSteps / LotDivider) * LotDivider;
     LotSize = TotalSteps * LotStep;
   }
   /** MichaelM ADD END **/
   
   double MinLots = MarketInfo(Symbol(), MODE_MINLOT);
   double MaxLots = MarketInfo(Symbol(), MODE_MAXLOT);
   
   if (LotSize < MinLots) LotSize = MinLots;
   if (LotSize > MaxLots) LotSize = MaxLots;
   
   return(LotSize);

}//double CalculateLotSize(double price1, double price1)

To see the actual lotsize G wants to use, modify the EA comments code as follows:

Code: Select all

/** MichaelM MOD START **/
if (RiskPercent > 0) {
   ScreenMessage = StringConcatenate(ScreenMessage,Gap, "Lot size based on ", StopLoss, " points and ", RiskPercent, "% risk: ", CalculateLotSize(Bid, Bid+(StopLoss*Point)));
} else {
   ScreenMessage = StringConcatenate(ScreenMessage,Gap, "Lot size: ", Lot);
}
ScreenMessage = StringConcatenate(ScreenMessage," (Criminal's minimum lot size: ", MarketInfo(Symbol(), MODE_MINLOT), ")", NL);
/** MichaelM MOD END **/

MichaelM wrote:On another note, how is your direction assisted RSI trend detection tracking?
Any "legs" or trades at BE yet?

MichaelM wrote:...EDIT: This little post of mine gave me a great idea to implement.

Let G start looking for trading opportunities only if price has broken either range high price or range low price.

Range high/low price can be user inputs.

Fingers are itching already to write the code