jjgengis wrote:hi AG,

first, thank you very much for this great EA and for all your efforts.

I would suggest a little modify, not substantial but useful.
I feel very uncomfortable when I use money instead of Pips in EA profit input. This because, if I want to change the lotsize, I'm forced to recalculate the Amount34/37 variables, if I want to keep unchanged the exits condition.
So, I wrote this simple modify:

Code: Select all

if (PipsOrBills)
        {
            if (Bid - OrderOpenPrice() >= Amount34 * PipValue * point)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }    
        else
        {        
            if (OrderProfit() >= Amount34)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }

PipsOrBills is an External Bool that switch your choice.

Thus , the closeorder function become so:

Code: Select all

void CloseOrderIf34()
{
    int orderstotal = OrdersTotal();
    int orders = 0;
    int ordticket[30][2];
    for (int i = 0; i < orderstotal; i++)
    {
        OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
        if (OrderType() != OP_BUY || OrderSymbol() != Symbol() || OrderMagicNumber() != 0)
        {
            continue;
        }
        if (PipsOrBills)  // ********************************JJ modify********************************
        {
            if (Bid - OrderOpenPrice() >= Amount34 * PipValue * Point)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }    
        else
        {        
            if (OrderProfit() >= Amount34)
            {
               ordticket[orders][0] = OrderOpenTime();
               ordticket[orders][1] = OrderTicket();
               orders++;
            }
        }  // ********************************JJ modify********************************
    }
    if (orders > 1)
    {
        ArrayResize(ordticket,orders);
        ArraySort(ordticket);
    }
    for (i = 0; i < orders; i++)
    {
        if (OrderSelect(ordticket[i][1], SELECT_BY_TICKET) == true)
        {
            bool ret = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 4, Red);
            if (ret == false)
            Print("OrderClose() error - ", ErrorDescription(GetLastError()));
        }
    }
    
}

for the Sell section (37) is enough change the row "if (Bid - OrderOpenPrice() >= Amount34 * PipValue * Point)" with "if (OrderOpenPrice() - Ask >= Amount37 * PipValue * Point)".

Is only a little suggestion.


JJ

AG2012 wrote:Thanks for the praise Ken, but I think that everyone will be even happier, if I can get the indi modded to the way I prefer, so the "new" EA will be able to trade from it....

Cheers

billv wrote:nkimandi,
Don't expect trades straight away.
You'll need to have Empty4 running continuously for several days because it needs to build up the history file.
First you will see some red and blue lines on the charts and after that it will do a few trades when the conditions are right. It doesn't trade every day.

Kenboi wrote:nkimandi,

Look at the expert tab and see if there's any error. If not, try to load more pairs so that you can get your first trade for an experiment. I have about 17 pairs opened.