stevehopwoodforex.com
https://www.stevehopwoodforex.com/phpBB3/
Print view

Gertje plus Squalou plus Forexhard EA
https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?t=485		 Page 9 of 18
Author:  acostafulano [ Tue Apr 24, 2012 6:37 am ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
Steve, even though the bot has been profitable on some pairs I've seen something that I'm not sure is on purpose:

Sometimes The boxrange gets drawn, the trade triggers, the grid develops, etc... and after the basket of trades hits its take profit, it inmmediately opens a new trade in the same direction it ended , messing up the grid and using the previous one for opposite direction entry (instead of resetting and re-drawing the box and waiting for a new breakout)...

This happens very often when after the initial breakout the basket closes for profit without the mid box opposite trigger line gets touched. the problem is that the grid line remains from the previous box, leaving a gap and causing DD.

It's hard to explain by words specially since this is not my first language. Hopefully the examples will clear this out:
GERTJE EURUSD.png
GERTJE AUDU.png
gert gbpznd.png

This is by far the EA with most potential I've seen by you here or in FF. All it needs is optimizing grid size and TP for each pair (working on that).
Author:  SteveHopwood [ Tue Apr 24, 2012 7:50 am ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
Looking into it.

Guys, when you post charts please remove that stupid grid from them (Ctrl + G). The damn thing serves no purpose whatsoever and makes some of your charts nigh impossible to make any sense of.

:D
Author:  SteveHopwood [ Tue Apr 24, 2012 8:47 am ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
The instant re-entry thingy is a design fault - I had omitted to code a check that the market is within the box before drawing the pending trade lines. The bot discovers they are missing and there are no open trades, so it draws the lines, which triggers a trade on the next tick. Well-behaved little bot; does as its told.

Fix in post 1. Coders, go to void ReadIndicatorValues() and find this block at the end of the function:

Code: Select all

   //Draw the pending price lines
   if ((BB0 != EMPTY_VALUE && BB1 != EMPTY_VALUE) || (BB2 != EMPTY_VALUE && BB3 != EMPTY_VALUE))
   {
      double pHigh, pLow;//High and low of the box
      if (BB0 != EMPTY_VALUE) pHigh = BB0;
      if (BB1 != EMPTY_VALUE) pLow = BB1;
      if (BB2 != EMPTY_VALUE) pHigh = BB2;
      if (BB3 != EMPTY_VALUE) pLow = BB3;
      
      
      if (OpenTrades == 0)
      {
         ObjectDelete(risetoline);
         CreateLine(risetoline, NormalizeDouble(pHigh, Digits), BuyLineColour);

         ObjectDelete(falltoline);
         CreateLine(falltoline, NormalizeDouble(pLow, Digits), SellLineColour);
      }//if (OpenTrades == 0) 
   }//if ((BB0 != EMPTY_VALUE && BB1 != EMPTY_VALUE) || BB2 != EMPTY_VALUE && BB3 != EMPTY_VALUE)
Add this:

Code: Select all

      //Only draw the lines if the market is within the box
      if (Bid > pHigh || Bid < pLow)
      {
         return;
      }//if (Bid > pHigh || Bid < pLow)
so that it looks like this:

Code: Select all

   //Draw the pending price lines
   if ((BB0 != EMPTY_VALUE && BB1 != EMPTY_VALUE) || (BB2 != EMPTY_VALUE && BB3 != EMPTY_VALUE))
   {
      double pHigh, pLow;//High and low of the box
      if (BB0 != EMPTY_VALUE) pHigh = BB0;
      if (BB1 != EMPTY_VALUE) pLow = BB1;
      if (BB2 != EMPTY_VALUE) pHigh = BB2;
      if (BB3 != EMPTY_VALUE) pLow = BB3;
      
      //Only draw the lines if the market is within the box
      if (Bid > pHigh || Bid < pLow)
      {
         return;
      }//if (Bid > pHigh || Bid < pLow)
      
      
      if (OpenTrades == 0)
      {
         ObjectDelete(risetoline);
         CreateLine(risetoline, NormalizeDouble(pHigh, Digits), BuyLineColour);

         ObjectDelete(falltoline);
         CreateLine(falltoline, NormalizeDouble(pLow, Digits), SellLineColour);
      }//if (OpenTrades == 0) 
   }//if ((BB0 != EMPTY_VALUE && BB1 != EMPTY_VALUE) || BB2 != EMPTY_VALUE && BB3 != EMPTY_VALUE)
:D
Author:  SteveHopwood [ Tue Apr 24, 2012 9:01 am ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
The fix appears to be working. I restarted the demo and the box hilo lines are only drawn when the Bid is inside the box.

:D
Author:  kwchau [ Tue Apr 24, 2012 11:42 am ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
I put it to a demo, the multiple thingy happens again. Steve, appreciate a lot if you can look into it.
Author:  acostafulano [ Tue Apr 24, 2012 12:15 pm ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
SteveHopwood wrote:The fix appears to be working. I restarted the demo and the box hilo lines are only drawn when the Bid is inside the box.

:D
Great. Thanks
Author:  SteveHopwood [ Tue Apr 24, 2012 12:15 pm ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
kwchau wrote:I put it to a demo, the multiple thingy happens again. Steve, appreciate a lot if you can look into it.
There is industrial strength code in all my bots to avoid this, plus enough advice all over these boards about what to do about it when your crim finds a way of defeating it.

Change criminals. There is nothing more I can do.

:D
Author:  SteveHopwood [ Tue Apr 24, 2012 12:17 pm ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
The fix is still not quite right. Some of my demo charts have triggered buys and the sell line has vanished.

:D
Author:  trader689 [ Tue Apr 24, 2012 12:42 pm ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
everything is OOTB default, apart from fixed lot size 0.1 and box length = 15 . so cashprofit target 1000, cashprofitperlot 0.0 and pipsprofit target 100. pip gap (pips between trades) is indeed 20.

demo is now up to $2260 with a -$50 floating drawdown at the moment. :)

nubika wrote:
trader689 wrote:WOW. this thing is on fire. with acostafulano's tip of using 15 box length my demo *in one day* has gone from $1000 to $2036, with -$41 floating open trade. 0.1 fixed lots, 20 pairs, 15m timeframe. we'll see how it holds up over this week

Hi Trader

What TP have you used on the pairs, and did you leave the pip gap at 20 as a default?

Frank
Author:  SteveHopwood [ Tue Apr 24, 2012 4:05 pm ]
Post subject:  Re: Gertje plus Squalou plus Forexhard EA
One more update in post 1, solving the disappearing pending trade line thingy.

I had coded the bot to delete these lines when the G++ is removed - even if all you do is close down your platform in order to download an update, Empty4 removed everything from the charts, then replaces them when you fir up again.

I have prevented the deletion if there are trades open. For the coders, go to int deinit()

Code: Select all

if (OpenTrades == 0)
   {
      ObjectDelete(risetoline);
      ObjectDelete(falltoline);
   }//if (OpenTrades == 0)
does the trick.

:D
All times are UTC Page 9 of 18

Powered by phpBB® Forum Software © phpBB Limited