Welcome and thanks for all this.jb68 wrote:Hi everybody,
I'm quite new here, however I have some forex experience especially countless screen hours. I did a few of my own EAs but I wanted to see what other people did so far in this area and I quite impressed by Steve's work. I'm still not decided if I should continue my work on my own libraries and EAs or just learn Steve's. Any way...
I loaded this EA and fired against the last 3 years of data. Before coming to an end screen was full of 130 errors so I stopped it, looked at the results. It looks like the modify works as it should and based on my experience I suspected it should be some crims crap so I decided to contribute a little. I looked at code where as I expected there is no check against crim's freeze level.
To save you from google it, each crims cand set it's own pair dependent "freeze level" variable and the distance between Sl/TP and Ask/Bid has to be bigger then this "freeze level". Some crims like Oanda has 0 while FXPro has 5pips, Alpari beeing in between.
this can be extracted with
double FreezeLevel=MarketInfo(Symbol(),MODE_STOPLEVEL);
Here are some changes..Plese note the SL and TP should be calculated using Bid when you buy and Ask when you sell.Code: Select all
//line 794 instead of modify = true; if (Bid- NewStop > MarketInfo(Symbol(),MODE_STOPLEVEL)) modify = true; // line 801 instead of modify = true; if (NewStop - Ask > MarketInfo(Symbol(),MODE_STOPLEVEL)) modify = true; // line 839 instead of: if (Bid >= sl + ((JumpingStopPips * 2) * Point) )//George if (Bid >= sl + ((JumpingStopPips * 2) * Point) && Bid - sl - (JumpingStopPips * Point) >MarketInfo(Symbol(),MODE_STOPLEVEL) )//George // line 855 instead of if (Bid <= sl - ((JumpingStopPips * 2) * Point) )//George if (Ask <= sl - ((JumpingStopPips * 2) * Point) && sl - (JumpingStopPips * Point) - Ask > MarketInfo(Symbol(),MODE_STOPLEVEL)) //George // line 896 instead of if (Bid >= sl + (TrailingStopPips * Point) )//George if (Bid >= sl + (TrailingStopPips * Point) && Bid - sl - (JumpingStopPips * Point) >MarketInfo(Symbol(),MODE_STOPLEVEL))//George // line 912 instead of if (Bid <= sl - (TrailingStopPips * Point))//George if (Ask <= sl - (TrailingStopPips * Point) && sl - (JumpingStopPips * Point) - Ask > MarketInfo(Symbol(),MODE_STOPLEVEL))//George // line 956 instead of modify = true; if (Bid- NewStop > MarketInfo(Symbol(),MODE_STOPLEVEL)) modify = true; // line 966 instead of modify = true; if (NewStop - Ask > MarketInfo(Symbol(),MODE_STOPLEVEL)) modify = true;
The idea is simple, to buy you pay the Ask price, when you close you get the Bid.
2-3 pips between Ask and Bid will not make a difference when we want 100 but.. who knows...
I did these changes and 130 errors are gone. I don't know from resource point of view on Empty4 if is better to do only once at init a MarketInfo call or just put FreezeLevel into a variable and check against it. I have no idea if Criminals change the FreezeLevel when news comes in.
I still get some errors occasionally:
2012.02.03 11:02:56 2009.05.22 15:44 Graeme EURUSD,M15: OrderModify error 1
and
2012.02.03 11:07:07 2011.11.29 11:30 Graeme EURUSD,M15: object name passed to ObjectType function cannot be an uninitialized or empty string
I may look into this errors some time... but this Empty4 doesn't have too many debug options and there just a few errors not that bad.
Re the developing your own stuff or learning mine thingy, I suggest you keep on developing your own. Mine is not going to go away. It is always available in my shell code and you can hack into it anytime. Thing is, I am a pianist not a programmer, so my stuff is the work of a reasonable well informed amateur, so the more you can do for yourself the better.
Re the freeze level thingy, I am not going to do anything with this. Basically, so long as the user has a combination of inputs that the crim allows then there is not a problem; doing so is up to the user. I have already been down the road of fixing something that was not bust in the first place here, and am not eager to do so again. If you get deeply into coding and providing code for others to use, you will find that the more idiot-proofing you do, the more idiocy people will offer up and ask you to sort out.
Re the "object name passed to ObjectType function cannot be an uninitialized or empty string" you will be doing me a favour of epic proportions if you can work out what I am doing wrong here. It will be something simple, but I am buggered if I can work out what. This is a Stealth-related thingy.
In case you have not worked this out for yourself, HiddenPips initiates Stealth management. Taking a buy trade as an example, when >0, HP adds HiddenPips to the 'hard' take profit sent with the trade, and subtracts if from the stop loss. Then the bot draws tp/sl lines that represent the 'true' tp/sl (drawn by void ReplaceMissingSlTpLines() and called from within CountOpenTrades() which itself performs a variety of functions at each tick) and closes the trade when these lines are touched/crossed.
At some point just subsequent to this, the error you describe here is triggered. This is no biggy, but if you can solve it you will save coders who follow in your footsteps some angst when they come across it for the first time, and before learning to ignore it.
Cheers
