TraderJoeForex » Sat Jul 01, 2017 9:34 pm wrote:Something I have been thinking about past few days is whether the distance price must travel between recovery stop orders should be the same regardless of timeframe.

SteveHopwood » Sat Jul 01, 2017 10:03 pm wrote:
Completely spot on. That is why there is only one MarketDistancePips inputs instead of one per time frame.

   //A check that we are not already at our pairs limit. Abort the trade if so.
   if (SendLong || SendShort)
      if (OrdersTotal() > 0)
      {
         CountCurrentlyTradingPairs();
         if (PairsWithTrades >= MaxPairsAllowed)
            return;   
      }//if (OrdersTotal() > 0)
      

• void CloseAllTrades(string symbol, int type, int magic)
• void NuclearOption()

            if (result) 
            {               
               cc++;
               OpenTrades--;
            }//(result) 

            if (result) 
            {
               FifoTicket[cc] = -1;
               cc++;
               OpenTrades--;
            }//(result) 

Hi Steve

I believe there might be the issue with the first entry in FifoTicket which is never assigned any tickets when filled from CountOpenTrades. CloseAllTrades tries to close a ticket in FifiTocket[0] which is never actually assigned any value in CountOpenTrades. I believe the simple change from CountAllTrades shown below might fix the issue? ie. FifoTicket[OpenTrades-1] = OrderTicket();

This would have been an issue for along while now so I hope I'm not missing something here. \":good:\"

Cheers

      OpenTrades++;
      //Store the latest trade sent. Most of my EA's only need this final ticket number as either they are single trade
      //bots or the last trade in the sequence is the important one. Adapt this code for your own use.
      if (TicketNo  == -1) TicketNo = OrderTicket();
      
      //Store ticket numbers for FIFO
      ArrayResize(FifoTicket, OpenTrades + 1);
      FifoTicket[OpenTrades] = OrderTicket();

      //Store the latest trade sent. Most of my EA's only need this final ticket number as either they are single trade
      //bots or the last trade in the sequence is the important one. Adapt this code for your own use.
      if (TicketNo  == -1) TicketNo = OrderTicket();
      
      //Store ticket numbers for FIFO
      ArrayResize(FifoTicket, OpenTrades + 1);
      FifoTicket[OpenTrades] = OrderTicket();
      
      OpenTrades++;

TraderJoeForex » Sat Jul 01, 2017 10:34 pm wrote: I get a load of pips upfront and then M1 is out of action for a bit while recovery sorts it all out and In the meantime I have the higher timeframes also starting to deliver. And a certain % of these losing trades will close out as losers anyway from an opposite signal when it comes.

Zool » Sun Jul 02, 2017 5:50 pm wrote:
Steve: when the close trade on opposite signal is triggered and the trade is closed, PoS will not remove the recovery stop orders placed on that timeframe. Can you make it to delete the pending orders too, when the opposite signal close happens?

Zool » Sun Jul 02, 2017 5:50 pm wrote:
Well last week on M1 was not a certain % of the losers was closed out at loss, but all of them, since the price haven't retraced for such a long time that the bottom sixths line was crawled upward constantly, and closed them out at a minor retracement while there were multiple recovery stop orders in place. I agree that M1 can make the biggest gains in account balance, but this time all the profit was eaten with those closed out losers.

TraderJoeForex » Mon Jul 03, 2017 11:36 am wrote:
I didn't have any M1 losers last week but this morning my pairs have caught up! The 4 in recovery have now closed for loss with an opposite M1 signal.

This is going to be an issue for the lower timeframes. Steve would it be possible to have an option for PoS to ignore opposite signals for any pairs that are in recovery? Then once in recovery it will either be a basket close or up to the user to pull the plug on those trades.

Using USDCAD as an example. Price is at the bottom of every chart from M5 up to H4 (in fact H4 looks like it's forming level 3 right now). This should mean there will be a decent bounce up very soon and if my M1 long trade stayed in recovery it would most likely come good this week. PoS is entering long on M5, M15, M30 so it may not make sense for M1 long recovery to be cut short by close on opposite?