SteveHopwood wrote:Shelly, I cannot see any reason for those strange part-closures. The code that calls the part-closure function is enclosed within a conditional that demands that the trade be in profit before the part=closure function is called. My live account did not take these trades because I will not sell the high-swap pairs. My demo did and has not replicated the problem.

So, no idea what caused it. Maybe the other coders can see something wrong? All the management features are called from within CountOpenTrades().

    if (OrderType() == OP_SELL && OrderStopLoss() <= OrderOpenPrice() && OrderLots() == Lot)
            {
               PartCloseThisTrade();
            }//if (OrderType() == OP_SELL)

            if (OrderType() == OP_SELL && OrderStopLoss() >= OrderOpenPrice() - (BreakEvenProfit / factor) - JumpingStopPips && OrderLots() > PartLot)
            {
               PartCloseThisTrade();
            }//if (OrderType() == OP_BUY && OrderStopLoss() >= OrderOpenPrice() 

            if (pp >= (JumpingStopPips * 2) && OrderLots() > PartLot) PartCloseThisTrade();

cosmo wrote:I have also been running G’day on another account using an alternative to 7.2.2. Stochastic, the De Mark Tendline, using the DMT I would not have taken any of the losers and would be well ahead, it is also less subjective and easy to follow, buy/sell on cross of trendline on the open of a new daily bar, see rules below.

gaheitman wrote:

SteveHopwood wrote:Shelly, I cannot see any reason for those strange part-closures. The code that calls the part-closure function is enclosed within a conditional that demands that the trade be in profit before the part=closure function is called. My live account did not take these trades because I will not sell the high-swap pairs. My demo did and has not replicated the problem.

So, no idea what caused it. Maybe the other coders can see something wrong? All the management features are called from within CountOpenTrades().

Steve,

In CountOpenTrades(), the code:

Code: Select all

    if (OrderType() == OP_SELL && OrderStopLoss() <= OrderOpenPrice() && OrderLots() == Lot)
            {
               PartCloseThisTrade();
            }//if (OrderType() == OP_SELL)

would seem to be the culprit. The only test to get here is that OrderProfit() > 0. Since there is no StopLoss, OrderStopLoss() will be <= OrderOpenPrice(), giving us the impression that we have either hit BE or moved our SL down....

There also seems to be an issue a bit further down.

Code: Select all

            if (OrderType() == OP_SELL && OrderStopLoss() >= OrderOpenPrice() - (BreakEvenProfit / factor) - JumpingStopPips && OrderLots() > PartLot)
            {
               PartCloseThisTrade();
            }//if (OrderType() == OP_BUY && OrderStopLoss() >= OrderOpenPrice() 

Don't you want it to be OrderStopLoss() <= OrderOpenPrice()... ?

Also, I can't tell if jumping stop was set or not, but I believe if it is not then this code:

Code: Select all

            if (pp >= (JumpingStopPips * 2) && OrderLots() > PartLot) PartCloseThisTrade();

will incorrectly call PartCloseThisTrade().

George

SteveHopwood wrote: A couple of really helpful spots in their George. Thanks. I am always forgetting to check that sells actually have a stop loss.

I still do not see how the code reached that point as the trade has to be in profit first and Shelley's were not. I noticed in Shelley's pic that Gday had made attempts to part-close and that this generated an invalid ticket error.

MrLong wrote:Morning Traders,

Here is a fresh M15 basket started at GMT 20:30 last night, hopfully I will upload the EA later today, you will have the option to trade any timeframe.

Best Regards
Andy