remix919 wrote:Just curious, is there any reason a lot of people use iHistory to view the results instead of just adding their account to myfxbook?

SpiderX wrote:Hi ,

not sure if this has been brought up before, but pretty sure this logic is broken or incomplete when using BASA on 1h charts.

Code: Select all

  if (AllowMainEntry)//5. Confusing, I know, but that is how bots develop
         if (Close[2] < FastTrendMaVal[2])//1
            if (Close[1] > FastTrendMaVal[1])//2
               if (RsiPinStatus == pinlow)//3
                  if (OpenTrades == 0)//4
                     if (!useMaStackForMainTrade || MaStackStatus == stacklong)//6
                     {   
                        MainEntry = true;
                        SendLong = true;
                        TradeComment = MainTradeComment;
                     }//if (!useMaStackForMainTrade || MaStackStatus == stacklong)

From Lookfortradingopportunities function....
In the 1H chart, this implies, the Close of 2 Candles(1H) must be less than the 60MA from 2 Candles(4H) ago.
My logical understanding is that this can be right or wrong depending on the time of your hourly candle.

For example:

60Ma values (4H)
0000-0400 1.01 [2]
0400-0800 1.02 [1]
0800-1200 1.03 [0]

On 1H, Relevant 60MA Values cascaded from 4H
0700-0800 1.01 cascaded from 0000-0400
0800-0900 1.02 cascaded from 0400-0800
0900-1000 1.02 cascaded from 0400-0800
1000-1100 1.02 cascaded from 0400-0800
1100-1200 1.02 cascaded from 0400-0800

Assuming Candle shift 0 on 1H is 0900-1000, then it is correct when we compare Close[2] (0700-0800) with 60Ma (0000-0400) (value 1.01) on the 4H.
However, when shift 0 is 1000-1100, then shouldnt we be comparing Close[2](0800-0900) with 60Ma (0400-0800) (1.02) on the 4H , since this is the relevant 60Ma on the higher TF ?

Proposed fix:

Code: Select all

         int OffSet=0;

         for (cc = 1; cc<= 3; cc++)
         {
            RsiTmaVal[cc] = GetRsiTma(cc);
            if (RsiTmaVal[cc] >= PinHighLevel) RsiPinStatus = pinhigh;
            if (RsiTmaVal[cc] <= PinLowLevel) RsiPinStatus = pinlow;

            if (cc < 3)
            {
	       if(Period()!=FastMaTdPeriod)
	       		OffSet=iBarShift(Symbol(), FastMaTdPeriod, Time[cc]);
	       else
			OffSet=cc;

               FastTrendMaVal[cc] = GetMa(Symbol(), FastMaTdTF, FastMaTdPeriod, FastMaTdShift, FastMaTdMethod, FastMaTdAppliedPrice, OffSet);
            }//if (cc < 3)            
         }//for (cc = 1; cc>= 3; cc++) 

Apologies if the explanations are not clear.
Well, my explanations could be wrong if that is the intended manner for BASA to work in the 1H timeframe.

Cheers

fxozgirl wrote: SpiderX...I don't really understand the coding that well, but I'm quite sure all the coding within BASA was done for the 4H timeframe which is what I designed it for. Our fellow traders have simply taken BASA in it's present form and plonked it on 1H charts and traded it as is.

SteveHopwood wrote:

remix919 wrote:Just curious, is there any reason a lot of people use iHistory to view the results instead of just adding their account to myfxbook?

Why should people link their accounts to myfxbook? Giving their live account details to a third party webpage? Hmmmmm. Wouldn't give my bank account details to a third party webpage etc

I agree with fchaman. It is the bottom line that counts and as my experiences with BASA taught me, even the pip count can be irrelevant - I have had BASA weeks with positive pips but negative cash. Trading 10.6 as I do this cannot happen; iHistory gives an accurate picture of my bottom line over the period I choose to view, and this is all I need.

SpiderX wrote:Hi,

Uploading here an edited file with the above mentioned changes for 1H timeframe.
Have edited this relatively fast without much testing, so there may be some bugs.
(but highly unlikely given the simple nature of the edit)

Cheers

SpiderX wrote:Hi,

Uploading here an edited file with the above mentioned changes for 1H timeframe.
Have edited this relatively fast without much testing, so there may be some bugs.
(but highly unlikely given the simple nature of the edit)

Cheers