SteveHopwood wrote:

remix919 wrote:Just curious, is there any reason a lot of people use iHistory to view the results instead of just adding their account to myfxbook?

Why should people link their accounts to myfxbook? Giving their live account details to a third party webpage? Hmmmmm. Wouldn't give my bank account details to a third party webpage etc

I agree with fchaman. It is the bottom line that counts and as my experiences with BASA taught me, even the pip count can be irrelevant - I have had BASA weeks with positive pips but negative cash. Trading 10.6 as I do this cannot happen; iHistory gives an accurate picture of my bottom line over the period I choose to view, and this is all I need.

SpiderX wrote:Hi,

Uploading here an edited file with the above mentioned changes for 1H timeframe.
Have edited this relatively fast without much testing, so there may be some bugs.
(but highly unlikely given the simple nature of the edit)

Cheers

fxozgirl wrote:

SteveHopwood wrote:Bloody hell, but it is scary the tricks memory can play.

I settled down to code the candle length atr thingy, to find I had already done it - and forgotten.

So I settled down to update the user guide, to find I had already done it - and forgotten.

V 2o is in post 1. From the updated user guide (formatting gets lost when I do this):
ATR candle length filter: I have used ATR to detect the average pips movement of the chart's candles, and abort a potential trade if the previous candle has spiked – as the result of a news-release, for example:
ClAtrTimeFrame: the time frame to use to calculate ATR. The zero default means the current chart time frame.
ClAtrPeriod: the ATR Period input. A zero value disables this feature.
ClAtrMultiplier: multiplies the value of ATR by this input to produce a maximum candle length for the candle that just closed. If the candle has moved by more than this number of pips, then BASA will not trade.

You will see that BASA sleeps for 5 seconds before leaping into life. My platforms tend to freeze if I have to do a restart whilst the markets are open. Tommaso mentioned that Empty4 has a lot of stuff to do in the first few seconds after startup, and I am making this worse by having about 20 instances of BASA trying to leap into life. The sleep is an attempt to overcome this.

Coders, sleep code in init(); candle length check in IsTradingAllowed()

Thanks Steve...I'll put it on some demo's and give it a whirl

fxozgirl wrote:

fxozgirl wrote:

SteveHopwood wrote:Bloody hell, but it is scary the tricks memory can play.

I settled down to code the candle length atr thingy, to find I had already done it - and forgotten.

So I settled down to update the user guide, to find I had already done it - and forgotten.

V 2o is in post 1. From the updated user guide (formatting gets lost when I do this):
ATR candle length filter: I have used ATR to detect the average pips movement of the chart's candles, and abort a potential trade if the previous candle has spiked – as the result of a news-release, for example:
ClAtrTimeFrame: the time frame to use to calculate ATR. The zero default means the current chart time frame.
ClAtrPeriod: the ATR Period input. A zero value disables this feature.
ClAtrMultiplier: multiplies the value of ATR by this input to produce a maximum candle length for the candle that just closed. If the candle has moved by more than this number of pips, then BASA will not trade.

You will see that BASA sleeps for 5 seconds before leaping into life. My platforms tend to freeze if I have to do a restart whilst the markets are open. Tommaso mentioned that Empty4 has a lot of stuff to do in the first few seconds after startup, and I am making this worse by having about 20 instances of BASA trying to leap into life. The sleep is an attempt to overcome this.

Coders, sleep code in init(); candle length check in IsTradingAllowed()

Thanks Steve...I'll put it on some demo's and give it a whirl

Steve...BASA took a CADJPY trade yesterday after the big candle which I believe the ATR filter should have prevented? Trade went to full SL

ATR was 25, then the next candle's closed at +55 pips, so using 2x ATR should have prevented the trade? In my analysis this is how I viewed each candle, so hopefully this wasn't lost in my original presentation to you

I am using version 2p

cadjpyh4_atr filter.png

  //Previous candle length. Cancel the trade if candle moved too far
  if (ClAtrPeriod > 0)
   {
      if (MathAbs(iClose(NULL, TradingTimeFrame, 1) - iOpen(NULL, TradingTimeFrame, 1)) > ClAtrVal) return(false);
   }//if (ClAtrPeriod > 0)

fxozgirl wrote:

SpiderX wrote:Hi,

Uploading here an edited file with the above mentioned changes for 1H timeframe.
Have edited this relatively fast without much testing, so there may be some bugs.
(but highly unlikely given the simple nature of the edit)

Cheers

SpiderX...would you mind editing the name of this file, by indicating that it is for H1 timeframe, so people don't get confused and download it thinking it is the original BASA strategy please?

fxozgirl wrote:
Steve...BASA took a CADJPY trade yesterday after the big candle which I believe the ATR filter should have prevented? Trade went to full SL

ATR was 25, then the next candle's closed at +55 pips, so using 2x ATR should have prevented the trade? In my analysis this is how I viewed each candle, so hopefully this wasn't lost in my original presentation to you

I am using version 2p

cadjpyh4_atr filter.png

extern int      ClAtrShift = 0;//Shift 2 should be correct to compare prev candle to prev2 atr

   //Atr for previous candle length
   if (ClAtrPeriod > 0) 
   {
      static datetime OldAtrBarTime = 0;
      if (OldAtrBarTime != iTime(NULL, ClAtrTimeFrame, 0))
      {
         OldAtrBarTime = iTime(NULL, ClAtrTimeFrame, 0);
         ClAtrVal = GetAtr(ClAtrTimeFrame, ClAtrPeriod, ClAtrShift) * ClAtrMultiplier;         
      }//if (OldAtrBarTime != iTime(NULL, ClAtrTimeFrame, 0))
   }//if (ClAtrPeriod > 0) 

• one trading BASA as originally coded on the H4.
• one trading the original BASA but on the H1.
• one trading SpiderX's version.