BigBe,
Just came across your thread and read your TSD link too, as I have struggled as a newbie...
Your insight into changing to (Bars-countedbars +1) is excellent; had come across this problem, later changing to MathMax(limit, maxBars+1) to solve one missing bar problem with the max bars set to 20, but only getting 19 bars at times !
Questions:
1. The IndicatorCounted()( problem I encountered was with trying to change Baluda's CSS single TF v1.0.8 to MTF, i.e., having indi instances showing various TFs in the SAME sub-window.
See http://www.stevehopwoodforex.com/phpBB3 ... f=45&t=629
IndicatorCounted() is only for the current TF, Period(), so this creates the question of using iBarShift() for other TFs, in which case above becomes tricky- I expanded limit to limit*TF to make sure I have enough relevant TF bars to give me shift instances equivalent to limit in M1.
2. One way of minimizing CPU load is to simply do what hanover @FF does: to define RefreshEveryXMin so that the Start() loop, instead of running with every incoming tick, will run only every X= 1 minute, 5 min, or so.
See http://www.forexfactory.com/showthread.php?t=163158
Any further thoughts?
(I later found out that using iBarShift was unnecessary with CSSv1.0.8 since the calc functions already were using shift, TF as parameters in respective TFs. I then had the problem with buffer indicator over-writes, since only the last table and currency line chart appeared if you were running a loop in the same mq4 for various TFs.)
Regards,
Athar.
Big Be wrote:Lesson 1
Mastering IndicatorCounted makes a major difference in the behavior and results of indicators. This knowledge may help you to turn a slow indicator into a fast indicator. This affects EA's as well, at least indirectly when indicators are called.
Note: “SetIndexDrawBegin” only affects the display, not the calculations.
The first lesson is that the MetaEditor's help file, etc., has a mistake that has been endlessly copied. Your ordinary indicator needs to recalculate two bars back. In theory one bar, but in practice two is safe. The maximum value of IndicatorCounted is Bars – 1.
So the help file gives the useful lines:
int counted_bars = IndicatorCounted();
counted_bars--;
But this next line from the help file:
limit = Bars - counted_bars – 1;
results, when on the current bar, in a limit of '1', NOT '2' which is what we want. Why have two lines that just take you back where you started? This calculates as:
(Bars - counted_bars) – 1
If Bars = 1000, then when on the current bar, counted_bars = 998, so you have:
(1000 – 998) – 1 = 1
So you have two choices:
counted_bars--;
limit = Bars - counted_bars;
OR just:
limit = Bars - counted_bars + 1;
You can check how all this is behaving with Comment statements, such as:
Comment(“ Bars “,Bars," counted_bars ",counted_bars, " limit ",limit);
When running, 'limit' should equal '2'.
Big Be
|
