s01 wrote:If it would not be a problem, after we fix one, I could just post the next one in this same thread instead of having 5 different threads all opened at the same time??

Thanks agin in advance, Steve / s01

s01 wrote:OK, since my last post I have sucessfully modded about 5 indicators, but I am having problems with about 5 others. So I am getting better, slowly but surely.

I have decided to break the big one in all indicator down into individual indicators, then once I get all the parts working I might or might not take a stab at making a all in one.

So next up is a SHI_Channel indicator, I have it displaying the correct numbers for the slope. If the clope of the channel is down the numbers are negative and if up the numbers are positve. But the color does not always change or display correctly. I have //'d in the problem areas with descriptions.

If it would not be a problem, after we fix one, I could just post the next one in this same thread instead of having 5 different threads all opened at the same time??

Thanks Again, Steve

    ///   if (DoubleToStr(-Step / Point,2) > 0) /// getting '>' - different types in comparison error

if (-Step / Point > 0) 

gaheitman wrote:

s01 wrote: So I am getting better, slowly but surely.

Thanks Again, Steve

To fix your initial test:

Code: Select all

    ///   if (DoubleToStr(-Step / Point,2) > 0) /// getting '>' - different types in comparison error

change it to:

Code: Select all

if (-Step / Point > 0) 

You don't need to convert it to a string which is what DoubleToStr() does, just leave it as a double.

I didn't run the code, but reading through it I'm guessing since it is going backwards through the bars, the UpDown you were using wasn't the most recent.

George

s01 wrote:EDIT-1

OK, since my last post I have sucessfully modded about 5 indicators, but I am having problems with about 5 others. So I am getting better, slowly but surely.

SHI_Channel indicator, Done!!

Next up is a Slope Direction indicator.

   if (ShowText)

   {                     

      if ( trend[0] == 1 ) 
                           
      {

         ObjectCreate   ( "54", OBJ_LABEL, 0, 0, 0 );
         ObjectSet      ( "54", OBJPROP_XDISTANCE, 1440 );
         ObjectSet      ( "54", OBJPROP_YDISTANCE, 220 );
         ObjectSet      ( "54", OBJPROP_BACK, false );
         ObjectSetText  ( "54","UP /", 10, "Arial Bold", Lime);
      }
      
     if ( trend[0] == -1 ) 
                          
      {
         ObjectCreate   ( "54", OBJ_LABEL, 0, 0, 0 );
         ObjectSet      ( "54", OBJPROP_XDISTANCE, 1440 );
         ObjectSet      ( "54", OBJPROP_YDISTANCE, 220 );
         ObjectSet      ( "54", OBJPROP_BACK, false );
         ObjectSetText  ( "54","DN /", 10, "Arial Bold", Red);

      }
   }

gaheitman wrote:
A couple of points. The value of x in your test section is always -1, since that is what causes it to drop out of the earlier loop. Generally, it's a bad idea to use the variable that drives a for loop outside of the for loop since its value is more of a side-effect of the loop processing and wasn't explicitly set. What you really want is the last value (value 0) of the array.

Also, the values are either 1 or -1, not 1 or 2, so your code should be:

Code: Select all

   if (ShowText)

   {                     

      if ( trend[0] == 1 ) 
                           
      {

         ObjectCreate   ( "54", OBJ_LABEL, 0, 0, 0 );
         ObjectSet      ( "54", OBJPROP_XDISTANCE, 1440 );
         ObjectSet      ( "54", OBJPROP_YDISTANCE, 220 );
         ObjectSet      ( "54", OBJPROP_BACK, false );
         ObjectSetText  ( "54","UP /", 10, "Arial Bold", Lime);
      }
      
     if ( trend[0] == -1 ) 
                          
      {
         ObjectCreate   ( "54", OBJ_LABEL, 0, 0, 0 );
         ObjectSet      ( "54", OBJPROP_XDISTANCE, 1440 );
         ObjectSet      ( "54", OBJPROP_YDISTANCE, 220 );
         ObjectSet      ( "54", OBJPROP_BACK, false );
         ObjectSetText  ( "54","DN /", 10, "Arial Bold", Red);

      }
   }

Also, I noticed you are trying to delete the objects named "DN /" and "UP /" in deinit(). These objects don't exist, you only need to delete the object named "55".

George

s01 wrote:Question: I'm a bit confused now, the values that are displayed on the lines on screen mean nothing then, how do you decide how to find the values if there are more than 3 or 6? Is it a progressive thing were the first two values since x is always -1 would be 1 & -1 the next would be 2 or -2?

Steve

#property indicator_buffers 2 

    IndicatorBuffers(3);                 // orig 3 
    SetIndexBuffer(0, Uptrend); 
 //   ArraySetAsSeries(Uptrend, true);   // orig was //'d out 
    SetIndexBuffer(1, Dntrend); 
 //   ArraySetAsSeries(Dntrend, true);   // orig was //'d out
    SetIndexBuffer(2, ExtMapBuffer); 
    ArraySetAsSeries(ExtMapBuffer, true); 

    double vect[], trend[]; 
    
    if(e > Bars) 
        e = Bars;    

    ArrayResize(vect, e); 
    ArraySetAsSeries(vect, true);
    ArrayResize(trend, e); 
    ArraySetAsSeries(trend, true); 

    for(x = 0; x < e; x++) 
    { 
        vect[x] = 2*WMA(x, period/2) - WMA(x, period);        
 //       Print("Bar date/time: ", TimeToStr(Time[x]), " close: ", Close[x], " vect[", x, "] = ", vect[x],  // orig  was //'d out
 //       " 2*WMA(p/2) = ", 2*WMA(x, period/2), " WMA(p) = ",  WMA(x, period));                             // orig was //'d out
    } 

    for(x = 0; x < e-period; x++)
     
        ExtMapBuffer[x] = iMAOnArray(vect, 0, p, 0, method, x);        

    for(x = e-period; x >= 0; x--)
    {     
        trend[x] = trend[x+1];
        if (ExtMapBuffer[x]> ExtMapBuffer[x+1]) trend[x] =1;
        if (ExtMapBuffer[x]< ExtMapBuffer[x+1]) trend[x] =-1;
    
    if (trend[x]>0)
    { Uptrend[x] = ExtMapBuffer[x]; 
      if (trend[x+1]<0) Uptrend[x+1]=ExtMapBuffer[x+1];
      Dntrend[x] = EMPTY_VALUE;
    }
    else              
    if (trend[x]<0)
    { 
      Dntrend[x] = ExtMapBuffer[x]; 
      if (trend[x+1]>0) Dntrend[x+1]=ExtMapBuffer[x+1];
      Uptrend[x] = EMPTY_VALUE;
    }