dietcoke wrote:ROOI wrote:
So what I want to know is if I will be able to set multiple times in the code.
For example how can I add to the code "tradehours" and "trademinutes" in the buy and sell criteria
and not have the error that the tradehour has been defined.There must be a simple way to be able for the EA to check the multiple buy/sell criteria with different values.
Can anyone help me please.... 
ROOI wrote:am I at least trying to change the correct bit of code in the EA?
The easiest, but least elegant way to do this would be to have a separate extern variable for each hour and minute you want to trade at
eg
Code: Select all extern int tradehour1 = 6;
extern int trademinute1 =45;
etc...
you then need to include the new variables in you trade open test eg:
Code: Select all if ((TradeHour==Hour()&&TradeMinutes==Minute()) || (TradeHour1==Hour()&&TradeMinutes1==Minute()) ) //Signal Buy
Obviously, this becomes an issue if you want to use lots of different possible entry times. In that case you will have to significantly rewrite your code to hold the trade times in an array which you loop through and test for each time in turn
Hi so I have added the code as follows :
Code: Select all //+------------------------------------------------------------------+
//| time trader.mq4 |
//| Copyright © 2012, www.FxAutomated.com |
//| http://www.FxAutomated.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2012, www.FxAutomated.com"
#property link "http://www.FxAutomated.com"
//---- input parameters
extern string time_trader_v2="visit www.FxAutomated.com for more!!!";
extern double Lots=0.1;
extern int TakeProfit=20;
extern int StopLoss=20;
extern int Slip=5;
extern string TradeSettings="Empty4 time(min-max): hours 0-23, minutes 0-59, seconds 0-59";
extern bool AllowBuy=true;
extern bool AllowSell=true;
extern int TradeHour= 0;
extern int TradeMinutes= 0;
extern int Tradehour1 = 0; //added here PLEASE GO DOWN TO WHERE i ADDED AGAIN
extern int Trademinute1 =0; //added here PLEASE GO DOWN TO WHERE i ADDED AGAIN
extern string MagicNumbers="To be changed in case of conflict with other EAs";
extern int BuyMagicNumber =10001;
extern int SellMagicNumber =10002;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----
Alert("Visit www.FxAutomated.com for more goodies!");
//----
return(0);
}
//+------------------------------------------------------------------+
//| expert starts |
//+------------------------------------------------------------------+
int start()
{
//----
int StopMultd,Sleeper=1;
int digits=MarketInfo("EURUSD",MODE_DIGITS);
StopMultd=10;
double TP=NormalizeDouble(TakeProfit*StopMultd,Digits);
double SL=NormalizeDouble(StopLoss*StopMultd,Digits);
int Slippage=Slip*StopMultd;
// Calculate stop loss
double slb=NormalizeDouble(Ask-SL*Point,Digits);
double sls=NormalizeDouble(Bid+SL*Point,Digits);
// Calculate take profit
double tpb=NormalizeDouble(Ask+TP*Point,Digits);
double tps=NormalizeDouble(Bid-TP*Point,Digits);
//-------------------------------------------------------------------+
//Check open orders
//-------------------------------------------------------------------+
if(OrdersTotal()>0){
for(int i=100; i<=OrdersTotal(); i++) // Cycle searching in orders
{
if (OrderSelect(i-1,SELECT_BY_POS)==true) // If the next is available
{
if(OrderMagicNumber()==BuyMagicNumber) {int halt1=1;}
if(OrderMagicNumber()==SellMagicNumber) {int halt2=1;}
}
}
}
//-------------------------------------------------------------------+
if((halt1!=1)&&(AllowBuy==true)){// halt1
// Buy criteria
if ((TradeHour==Hour())&&(TradeMinutes==Minute())) //Signal Buy
//THIS IS WHERE ADDED IT IN !!!!! Signal Buy THIS IS WHERE ADDED IT IN !!!!!
if ((TradeHour==Hour() &&(TradeMinutes==Minute()) || (TradeHour1==Hour()&&TradeMinutes1==Minute()) ) //Signal Buy
{
int openbuy=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"time trader buy order ",BuyMagicNumber,0,Blue);
if(openbuy<1){int buyfail=1;}
}
}// halt1
if((halt2!=1)&&(AllowSell==true)){// halt2
RefreshRates();
// Sell criteria
if ((TradeHour==Hour())&&(TradeMinutes==Minute())) //Signal Sell
//THIS IS WHERE ADDED IT IN !!!!! Signal Sell THIS IS WHERE ADDED IT IN !!!!!
if ((TradeHour==Hour() &&(TradeMinutes==Minute()) || (TradeHour1==Hour()&&TradeMinutes1==Minute()) ) //Signal sell
{
int opensell=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"time trader sell order ",SellMagicNumber,0,Green);
if(opensell<1){int sellfail=1;}
}
}// halt2
//-----------------------------------------------------------------------------------------------------
if(OrdersTotal()>0){
for(i=1; i<=OrdersTotal(); i++){ // Cycle searching in orders
if (OrderSelect(i-1,SELECT_BY_POS)==true){ // If the next is available
if((OrderMagicNumber()==BuyMagicNumber)&&(OrderTakeProfit()==0||OrderStopLoss()==0)) { OrderModify(OrderTicket(),0,slb,tpb,0,CLR_NONE); }
if((OrderMagicNumber()==SellMagicNumber)&&(OrderTakeProfit()==0||OrderStopLoss()==0)) { OrderModify(OrderTicket(),0,sls,tps,0,CLR_NONE); }
}
}
}
//-------------------------------------------------------------------+
// Error processing
//-------------------------------------------------------------------+
if(buyfail==1||sellfail==1){
int Error=GetLastError();
if(Error==130){Alert("Wrong stops. Retrying."); RefreshRates();}
if(Error==133){Alert("Trading prohibited.");}
if(Error==2){Alert("Common error.");}
if(Error==146){Alert("Trading subsystem is busy. Retrying."); Sleep(500); RefreshRates();}
}
//-------------------------------------------------------------------
return(0);
}
//+-----------------------------------
When I compile it gives 4 errors :
'TradeHour1' - variable not defined D:\alpri demo indice\experts\time trader.mq4 (84, 55)
'TradeMinutes1' - variable not defined D:\alpri demo indice\experts\time trader.mq4 (84, 75)
'TradeHour1' - variable not defined D:\alpri demo indice\experts\time trader.mq4 (98, 56)
'TradeMinutes1' - variable not defined D:\alpri demo indice\experts\time trader.mq4 (98, 76)
Please help as to where I can put the lines of code.
Thanks very much for your time and energy in replying to noob like me |
