Angat » Tue Dec 30, 2014 2:03 pm wrote:Yes that is definitely helpful, thank you!

Angat » Tue Dec 30, 2014 6:47 pm wrote:1. I needed the highest high identified in the lookback range. A vertical line draw across the bar with the highest high.
2. Then I need a vertical line drawn on every 10th bar for the timeframe I'm on using that initial line as the reference point.



Thank you for your efforts for both indicators. I'll try and modify and combine. I think I can do it to achieve what I need.

Much appreciated.

Angat » Tue Dec 30, 2014 10:05 pm wrote:

Angat » Tue Dec 30, 2014 6:47 pm wrote:1. I needed the highest high identified in the lookback range. A vertical line draw across the bar with the highest high.
2. Then I need a vertical line drawn on every 10th bar for the timeframe I'm on using that initial line as the reference point.



Thank you for your efforts for both indicators. I'll try and modify and combine. I think I can do it to achieve what I need.

Much appreciated.

I have managed to do number 1 by amending your code slightly and adding some extra bits. Thank you very much. I'm off the ground!

However I can't get the line to print irrespective of what timeframe I'm viewing. If I change TFs on Empty4 the line changes bars completely. This works fine in your code. I'm not sure what it could be.



It's like Timeframe is hardcoded to 0. But its set as a extern and I change it to 60 in Empty4. I have even tried hardcoding it to 60. No change. It must be to do with my highest bar code at the top.

Any help would be greatly appreciated

int highest_bar = iHighest(NULL,TimeFrame,MODE_HIGH,Lookback,0);
int lowest_bar = iLowest(NULL,TimeFrame,MODE_HIGH,Lookback,0);

void DrawVLineHigh(string name,double price,color col,int style,int width)
  {

   ObjectDelete(name);

   ObjectCreate(name,OBJ_VLINE,0,Time[highest_bar],price);
   ObjectSet(name,OBJPROP_COLOR,col);
   ObjectSet(name,OBJPROP_STYLE,style);
   ObjectSet(name,OBJPROP_WIDTH,width);

  }





void DrawVLineLow(string name,double price,color col,int style,int width)
  {

   ObjectDelete(name);

   ObjectCreate(name,OBJ_VLINE,0,Time[lowest_bar],price);
   ObjectSet(name,OBJPROP_COLOR,col);
   ObjectSet(name,OBJPROP_STYLE,style);
   ObjectSet(name,OBJPROP_WIDTH,width);

  }

milanese » Tue Dec 30, 2014 10:40 pm wrote:

Code: Select all

int highest_bar = iHighest(NULL,TimeFrame,MODE_HIGH,Lookback,0);
int lowest_bar = iLowest(NULL,TimeFrame,MODE_HIGH,Lookback,0);

makes no sense as iHighest and iLowest are double values, I have no idea what you want the indicator to show..

Code: Select all

void DrawVLineHigh(string name,double price,color col,int style,int width)
  {

   ObjectDelete(name);

   ObjectCreate(name,OBJ_VLINE,0,Time[highest_bar],price);
   ObjectSet(name,OBJPROP_COLOR,col);
   ObjectSet(name,OBJPROP_STYLE,style);
   ObjectSet(name,OBJPROP_WIDTH,width);

  }

void DrawVLineLow(string name,double price,color col,int style,int width)
  {

   ObjectDelete(name);

   ObjectCreate(name,OBJ_VLINE,0,Time[lowest_bar],price);
   ObjectSet(name,OBJPROP_COLOR,col);
   ObjectSet(name,OBJPROP_STYLE,style);
   ObjectSet(name,OBJPROP_WIDTH,width);

  }

makes too no sense...
If you could explain what exactly you want to modify on the first version, I can help you and code it..
Cheers

Tommaso

SteveHopwood » Tue Dec 30, 2014 10:49 pm wrote:Angat, you will have to forgive me for being a bit befuddled here. I am in my usual post tea state of a bit under the affluence of incohol.

I cannot provide the whole solution, is what I am saying because I cannot work it out. I can perhaps point you in the right direction.

I wrestled with a similar problem early on in SHF's days and this snippet forms a part of all my shell codes:

Code: Select all

Code from George, to detect the shift of an order open time
int shift = iBarShift(NULL,Period(),OrderOpenTime(), false);

This provides the shift on any time frame I am investigating, of the open time of a trade. So, the trade might have opened at x on the H4, but the code will provide the shift on any other time frame should I need it. The trade opened on the last H4 candle and I do not want another opening within the next x M15 candles, the iBarShift allows me to calculate whether a trade on the M15 can open.

So, you need to know the candle open time identified by your
double HH_price=iHigh(NULL, TimeFrame, iHighest(NULL, TimeFrame, MODE_HIGH,Lookback,0));

So, if datetime CandleTime = <the open time of the candle identified by your previous code> and SomeTimeFrame = your chosen time frame

then

int shift = iBarShift(NULL,SomeTimeFrame,CandleTime, false); will give you the shift you need to draw the vertical line correctly on any chart time frame.

Sorry if this does not make a lot of sense - perhaps someone unpished can step in and explain it a tad more clearly. I am still enjoying the joysh of Christshmush. hic. I hope enough of it makes sense to point you in the right direction.

I would say that I will have another look in the morning, but it would be a miracle if I even remember that I posted this.

Fantastic to see you getting your sleeves rolled up into the, um, unintricacies of crapql4. It is something that all retail forex traders should do.

Cheershh

hic