Code: Select all

extern double SubSetTargetProfit = 0;
extern double SubSetAverageProfit = 0;

Code: Select all

int SubSet[]; // Global-Scope dynamic array to hold ticket numbers of sub-set trades.

Code: Select all

void CloseTradesOnTargetProfit(int& Managed[])
{
	int SizeOfArray = 0;
	double SubSetProfit = 0;
	
	SubSetProfit = LockedInProfit(Managed);
	
	if (SubSetProfit >= SubSetTargetProfit) CloseSubSet(Managed);
	
	SizeOfArray = ArrayRange(Managed, 0);
	Alert(string(SizeOfArray), " trades closed with ", DoubleToString(SubSetProfit, 2), " total profit. Target profit is ", DoubleToString(SubSetTargetProfit, 2), ".");
	Print(string(SizeOfArray), " trades closed with ", DoubleToString(SubSetProfit, 2), " total profit. Target profit is ", DoubleToString(SubSetTargetProfit, 2), ".");
	return;
} // End void CloseTradesOnTargetProfit(int& Managed[])

void CloseTradesOnAverageProfit(int& Managed[])
{
	int SizeOfArray = 0;
	double AverageProfit = 0;
	double SubSetProfit = 0;
	
	SizeOfArray = ArrayRange(Managed, 0);
	SubSetProfit = LockedInProfit(Managed);
	AverageProfit = SubSetProfit / SizeOfArray;
	
	if (AverageProfit >= SubSetAverageProfit) CloseSubSet(Managed);
	Alert(string(SizeOfArray), " trades closed with an average profit of ", DoubleToString(AverageProfit, 2), ".");
	Print(string(SizeOfArray), " trades closed with an average profit of ", DoubleToString(AverageProfit, 2), ".");
	return;
} // End void CloseTradesOnAverageProfit(int& Managed[])

double LockedInProfit(int& Managed[])
{
   int ticket;
	int SizeOfArray = 0;
   double LotSize = 0;
   double LockedPips = 0;
   double TradeProfit = 0;
   double CashProfit = 0;
	
	// Loop through the aray
   for (int index = ArrayRange(Managed, 0) - 1 ; index >= 0 ; index--)
   {
      ticket = 0;
		ticket = Managed[index];
      if ((OrderSelect(ticket,SELECT_BY_TICKET) != true) || ((OrderSelect(ticket,SELECT_BY_TICKET) == true) && (OrderCloseTime() != 0))) continue;
      if ((OrderSelect(ticket,SELECT_BY_TICKET) == true) && (OrderCloseTime() == 0))
      if (OrderMagicNumber() == MagicNumber)
      if (OrderSymbol() == Symbol())
      {
         if (OrderType() == OP_BUY)
         {
            LockedPips = (OrderStopLoss() - OrderOpenPrice()) * factor; // Get the trade's profit/loss in Pips.
            LotSize = OrderLots();
            TradeProfit = (Pips2Cash(LockedPips) * LotSize) + OrderSwap() + OrderCommission(); // Get the trade's profit/loss in cash.
         } // End if (OrderType() == OP_BUY)

         if (OrderType() == OP_SELL)
         {
            LockedPips=(OrderOpenPrice() - OrderStopLoss()) * factor;
            LotSize=OrderLots();
            TradeProfit = (Pips2Cash(LockedPips) * LotSize) + OrderSwap() + OrderCommission();
         } // End if (OrderType() == OP_SELL)
         CashProfit = CashProfit + TradeProfit; // Get running total profit/loss in cash.
      } // End if (OrderSymbol() == Symbol())
   } // End for (int index = ArrayRange(Managed, 0) - 1 ; index >= 0 ; index--)
	return(CashProfit);
} // End LockedInProfit

double Pips2Cash(double Pips)
{
   double TickValue = 0;
   double PipsCashValue = 0;

   TickValue = MarketInfo(Symbol(), MODE_TICKVALUE);
   PipsCashValue = (TickValue  * 10) * Pips; // Since TickValue gives us the value of 1 Point, we multiply TickValue by 10 to get Pip Value.
   return(PipsCashValue);
} // End Pips2Cash

void CloseSubSet(int& Managed[])
{

   int ticket;
   int index;
   bool result = false;

   for (index = ArrayRange(Managed,0) - 1; index >= 0; index--)
   {
      ticket = 0;
		ticket = Managed[index];
      if ((OrderSelect(ticket,SELECT_BY_TICKET) != true) || ((OrderSelect(ticket,SELECT_BY_TICKET) == true)  && (OrderCloseTime() !=0))) // Gotta keep my arrays clean
      {
         Managed[index] = 0;
         continue;
      } // End if ((OrderSelect(ticket,SELECT_BY_TICKET) != true) || ((OrderSelect(ticket,SELECT_BY_TICKET) == true)  && (OrderCloseTime() !=0)))
      if (OrderMagicNumber() != MyMagicNumber) continue;
      if (OrderSymbol() != Symbol()) continue;
      if ((OrderSelect(ticket,SELECT_BY_TICKET) == true) && (OrderCloseTime() == 0))
      if (OrderMagicNumber() == MagicNumber)
      if (OrderSymbol() == Symbol())
      {
         while(IsTradeContextBusy()) Sleep(100);
         if (OrderType() == OP_BUY || OrderType() == OP_SELL)
         {
            result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 1000, CLR_NONE);
         } // End if (OrderType() == OP_BUY || OrderType() == OP_SELL)
      } // End if (OrderSymbol() == Symbol())
   }// End for (index = ArrayRange(Managed,0) - 1; index >= 0; index--)
   return;
}//End void CloseSubSet()

bool CloseEnough(double num1, double num2)
{
   /*
   This function addresses the problem of the way in which mql4 compares doubles. It often messes up the 8th
   decimal point.
   For example, if A = 1.5 and B = 1.5, then these numbers are clearly equal. Unseen by the coder, mql4 may
   actually be giving B the value of 1.50000001, and so the variable are not equal, even though they are.
   This nice little quirk explains some of the problems I have endured in the past when comparing doubles. This
   is common to a lot of program languages, so watch out for it if you program elsewhere.
   Gary (garyfritz) offered this solution, so our thanks to him.
   */
   
   if (num1 == 0 && num2 == 0) return(true); //0==0
   if (MathAbs(num1 - num2) / (MathAbs(num1) + MathAbs(num2)) < 0.00000001) return(true);
   
   //Doubles are unequal
   return(false);

}//End bool CloseEnough(double num1, double num2)

Code: Select all

int SizeOfArray = ArrayRange(SubSet, 0);
ArrayResize(SubSet, SizeOfArray + 1);
SubSet[SizeOfArray] = OrderTicket();

Code: Select all

if (!(CloseEnough(SubSetTargetProfit, 0))) CloseTradesOnTargetProfit(SubSet);
if (!(CloseEnough(SubSetAverageProfit, 0)))CloseTradesOnAverageProfit(SubSet);
ArrayResize(SubSet, 0); // Kill the array, ready for the next loop of the EA.

Code: Select all

#define INVALID_TICKET_ID -1

bool GetRealOrderProfit(double& profit, int ticketId)
{
   if (ticketId != INVALID_TICKET_ID)
   {
      if (OrderSelect(ticketId, SELECT_BY_TICKET))
      {
         profit = OrderProfit() + OrderSwap() + OrderCommission();
         return true;
      }
   }
   return false;
}

void MyFunction()
{
   int myTicketId;
   // ...

   double myProfit;
   if (GetRealOrderProfit(myProfit, myTicketId) && myProfit > 0.0)
   {
       // my order is profitable, yay !!
   }
}