It looks to me as though you have found the reason that SCB failed in the first place - and it is all my fault so do not feel bad about being unable to make your pending orders go. Using your file, look at lines 153-154:fx800 » Tue May 22, 2018 12:18 am wrote:Hi
I would be very grateful if someone can have a look at the code for SCB with pending order attached below. The codes look ok but the ea is not sending any trades even when all the conditions are fulfilled.
Code: Select all
//Long if (SendLong) { CountOpenTrades(symbol, PairIndex); if (MarketBuysCount > 0) return; if (BuyStopsCount > 0) return; type = OP_BUYSTOP; price = NormalizeDouble(Ask + (PendingOrderBuffer/factor), Digits); //if ((price - Ask) <= (PendingOrderBuffer / factor)) price = price + (PendingOrderBuffer / factor); //increase if price too close to current high if ((Ask + stopLevel) >= price ) return;//MR LONG MOD stop = CalculateStopLoss(OP_BUY, price); take = CalculateTakeProfit(OP_BUY, price); //Lot size calculated by risk if (!CloseEnough(RiskPercent, 0)) SendLots = CalculateLotSize(symbol, price, stop ); SendTrade = true; }//if (SendLong) //Short if (SendShort) { CountOpenTrades(symbol, PairIndex); if (MarketSellsCount > 0) return; if (SellStopsCount > 0) return; type = OP_SELLSTOP; price = NormalizeDouble(Bid - (PendingOrderBuffer/factor), Digits); //if ((Bid - price) <= (PendingOrderBuffer / factor)) price = price - (PendingOrderBuffer / factor); //decrease if price too close to current low if (price >= (Bid - stopLevel)) return;//MR LONG MOD stop = CalculateStopLoss(OP_SELL, price); take = CalculateTakeProfit(OP_SELL, price); //Lot size calculated by risk if (!CloseEnough(RiskPercent, 0)) SendLots = CalculateLotSize(symbol, price, stop); SendTrade = true; }//if (SendShort)Thank you in advance.Code: Select all
//Buy if (tradingStatus[PairIndex] == tradablelong) if (MarketBuysCount == 0) if (BuyStopsCount == 0) { SendTrade = true; type = OP_BUYSTOP; price = NormalizeDouble(Ask + (PendingOrderBuffer/factor), Digits); //if ((price - Ask) <= (PendingOrderBuffer / factor)) price = price + (PendingOrderBuffer / factor); //increase if price too close to current high if ((Ask + stopLevel) >= price ) return;//MR LONG MOD if (UseZeljko && !BalancedPair(symbol, OP_BUY) ) return; stop = CalculateStopLoss(OP_BUY, price); take = CalculateTakeProfit(OP_BUY, price); //Lot size calculated by risk if (!CloseEnough(RiskPercent, 0)) SendLots = CalculateLotSize(symbol, price, stop); }//if (!DoesTradeExist(symbol, OP_BUY) ) //Sell if (tradingStatus[PairIndex] == tradableshort) if (MarketSellsCount == 0) if (SellStopsCount ==0 ) { SendTrade = true; type = OP_SELLSTOP; price = NormalizeDouble(Bid - (PendingOrderBuffer/factor), Digits); //if ((Bid - price) <= (PendingOrderBuffer / factor)) price = price - (PendingOrderBuffer / factor); //decrease if price too close to current low if (price >= (Bid - stopLevel)) return;//MR LONG MOD if (UseZeljko && !BalancedPair(symbol, OP_SELL) ) return; stop = CalculateStopLoss(OP_SELL, price); take = CalculateTakeProfit(OP_SELL, price); //Lot size calculated by risk if (!CloseEnough(RiskPercent, 0)) SendLots = CalculateLotSize(symbol, price, stop); }//if (!DoesTradeExist(symbol, OP_SELL) )
peter
double ask=0, bid=0, spread=0;//Replaces Ask. Bid, Digits. factor replaces Point
int digits;//Replaces Digits.
SCB is a multi-pair trader, so ask replaces Ask and can be used throughout the program. Ditto bid for Bid etc.
Then go to line 1776 and the void GetBasics(string symbol) function. This is called whenever ask, bid, spread and digits need populating.
By the time void LookForTradingOpportunities(string symbol, int PairIndex) is called, bid, ask, spread and digits should all have the correct values.
Now look at line 3757:
price = NormalizeDouble(Ask + (PendingOrderBuffer/factor), Digits);
This should clearly be:
price = NormalizeDouble(ask + (PendingOrderBuffer/factor), digits);
Then look at line 3789:
price = NormalizeDouble(Bid - (PendingOrderBuffer/factor), Digits);
This clearly should be:
price = NormalizeDouble(bid - (PendingOrderBuffer/factor), digits);
Looking at line 3761 I see another 'Ask' that should be 'ask'. At line 3792 I see another 'Bid' that should be 'bid'.
Can you do me a favour please? It is past midnight here and I am going to bed - plus the single malt has been good tonight.
I have a busy teaching day tomorrow so the earliest I can get around to posting an updated version is Friday, so better to wait until the weekend. Could you make the changes please, and let me know if they work?Maybe SCB failed because I am an idiot. You might be responsible for his resurgence.
