Good for you for getting your hands dirty by looking under the bonnet of CrapQl4.LittleCaro » Mon Jun 08, 2020 3:35 pm wrote:Hello guys,
I'm facing a really strange thing, that's several days i'm on it, and well ...
Here is the thing : i create something really basic with Steve's shell.
I want to set pending order + x pips to the high of the previous candle, the thing it :
It's working with High[0] and High[2], BUT it's not working with High[1] the one that i'm interested in.
The expert says error 130 invalid stops, and that's the same stops used with High[0] and High[2]
Maybe some of our geniuses can look at it.
Here is the code :
And the code for calculating stoploss :Code: Select all
//Long if (SendLong) { type=OP_BUYLIMIT; stype = " Buy Limit "; price = High[1] + (PipsAdjust/factor); if (!SendAlertNotTrade) { stop = CalculateStopLoss(OP_BUYLIMIT, price); take = CalculateTakeProfit(OP_BUYLIMIT, price); //Lot size calculated by risk if (!CloseEnough(RiskPercent, 0)) SendLots = CalculateLotSize(price, NormalizeDouble(stop + (HiddenPips / factor), Digits) ); }//if (!SendAlertNotTrade) SendTrade = true;
Thanks guys !
Re this:
price = High[1] + (PipsAdjust/factor);
Supposing the market had fallen by the time your EA tries to execute this code. You could be trying to send a limit order at an impossible price because the market is already lower than your limit price. You need to check that 'price' is below the current market price so that a limit order is possible. From there, you either abort the trade or send a stop order.
Assuming you are happy to send a stop order, then the construct would be this:
type = BUYLIMIT;
price = High[1] + (PipsAdjust/factor);
if (price > Ask)//In English to follow
{
- Abort the function if you will not allow stop orders instead of limit orders.
- Adjust the type code etc if you are happy to accept stop orders.
Up an at 'em, Tiger. I hope this helps. Ask away if not.
