simple allPairBasketManager

Post by **milanese** » Sat May 02, 2015 4:16 pm

update version 1.11
may 2th 2015 fixes problems with some setting and pending orders, that caused the EA to stop working correct in case of TP/SL hit, thanks to Mike & dydynamic for their signalisations, finally I found a bug.
Now here fixed.
Please download all the fixed version 1.11, you will find it attached at the first post..

Cheers

Tommaso

Post by **dydynamic** » Sat May 02, 2015 7:13 pm

Thank you Milanese for your tireless efforts and God bless you and keep you forever shining in His Glory.

Post by **dydynamic** » Mon May 04, 2015 8:27 am

Hi,Milanese
Just to let you know that it is working well now and thanks for everything. :hi:

Post by **milanese** » Mon May 04, 2015 8:31 am

dydynamic » Mon May 04, 2015 8:27 am wrote:Hi,Milanese
Just to let you know that it is working well now and thanks for everything. :hi:

perfect!

Cheers

Tommaso

Post by **basch312** » Wed May 13, 2015 2:57 pm

Tommaso, thanks for this tool. It works perfect.

I just wanted to note a couple of things. I'm using this tool in a demo account with Zennor Piproid. In a EA like this, that is adding pending orders continuously or almost always there are pending orders, there ir something that may should be changed.

I'm talking about this:

Code: Select all

if(OrdersTotal()==0)
     {
      EquityForTP_Close=AccountBalance() *multiplerEquityForTP_Close;
      EquityForSL_Close=AccountBalance()- (AccountBalance()*InitialBalancePercentForSL_Close);
      if(doNotUseSL_Close==true)EquityForSL_Close=0;
      EquityForJS_Close=EquityForSL_Close;
      if(usePercentForSettingBE==true&& useBasketBEandJump==true)
        {
         EquityForSettingBE=AccountBalance()*multiplerEquityForSettingBE;
        }
      else EquityForSettingBE=AccountBalance()+AllOverProfitForSettingBE;

      nextJSStep=EquityForSettingBE;
      GlobalVariableDel(JSGvName);
      GlobalVariableDel(StepGvName);
      
}

It wouldn't be better if it recalculates the "EquityForXXX" when there are 0 OPENED orders... instead of 0 TOTAL orders (opened and pending included) ?

I'm going to tweak it myself, just wanted to ask if that has any sense.

Anddd... what about adding a magic number input, so the EA only acts over one kind of trade? Would it complicate too much the code?

Regards,
Adrián.

Post by **milanese** » Wed May 13, 2015 3:34 pm

basch312 » Wed May 13, 2015 2:57 pm wrote:Tommaso, thanks for this tool. It works perfect.

I just wanted to note a couple of things. I'm using this tool in a demo account with Zennor Piproid. In a EA like this, that is adding pending orders continuously or almost always there are pending orders, there ir something that may should be changed.

I'm talking about this:
Code: Select all
if(OrdersTotal()==0)
     {
      EquityForTP_Close=AccountBalance() *multiplerEquityForTP_Close;
      EquityForSL_Close=AccountBalance()- (AccountBalance()*InitialBalancePercentForSL_Close);
      if(doNotUseSL_Close==true)EquityForSL_Close=0;
      EquityForJS_Close=EquityForSL_Close;
      if(usePercentForSettingBE==true&& useBasketBEandJump==true)
        {
         EquityForSettingBE=AccountBalance()*multiplerEquityForSettingBE;
        }
      else EquityForSettingBE=AccountBalance()+AllOverProfitForSettingBE;

      nextJSStep=EquityForSettingBE;
      GlobalVariableDel(JSGvName);
      GlobalVariableDel(StepGvName);
      
}
It wouldn't be better if it recalculates the "EquityForXXX" when there are 0 OPENED orders... instead of 0 TOTAL orders (opened and pending included) ?

I'm going to tweak it myself, just wanted to ask if that has any sense.

Anddd... what about adding a magic number input, so the EA only acts over one kind of trade? Would it complicate too much the code?

Regards,
Adrián.

Hi Adrian,

thanks for your post, when the first version was released I did not think about pending orders, because the first version did always delete with a basket close in every case all pending orders, than someone asked for the possibility of not deleting pending orders..
I will change this with the next update, thanks for the spot.
About the magic number, yes this would be possible and will maybe in future versions be integrated...

Cheers

Tommaso

Post by **milanese** » Wed May 13, 2015 3:46 pm

update version 1.12
may 13th 2015
fixed some eventual reinitializing problems, if pending orders are not deleted with basket close..

Thanks Adrian for this spot, the update is as always at the bottom of the first post to find..

Cheers

Tommaso

Post by **basch312** » Wed May 13, 2015 3:51 pm

milanese » Wed May 13, 2015 4:46 pm wrote: update version 1.12
may 13th 2015
fixed some eventual reinitializing problems, if pending orders are not deleted with basket close..

Thanks Adrian for this spot, the update is as always at the bottom of the first post to find..

Cheers

Tommaso

Thanks Tommaso for your work!!

Regards!
Adrián.

Post by **milanese** » Sun May 17, 2015 8:27 am

update version 1.13
may 17th 2015
fixed a glitch in basketclose counter, sometimes giving wrong values..
too a rare problem fixed when not deletingPending orders with basketclose, that caused wrong basketcloses..
You find version 1.13 attached to the first post, as always...

Cheers

Tommaso

JRforex · Post by **JRforex** » Tue May 19, 2015 4:40 pm

Hi Tomasso

Thank you very much for this amazing manager. I have a feature on my wish list. Is there a possibility that you could add a function to enable or disable EAs at a specific time? This would be very handy when you want to disable EAs during NFP or other high impact news.

:hi: