Scalp the Little Gits, dsu

[SteveHopwood]

The current code put a ban on taking trades at 90/00 for longs and 10/00 for shorts

I modified the code here:

if (PriceCeiling100 - dPriceCeiling != (10 / factor)) (Long order)

if (dPriceFloor - PriceFloor100 != (10 / factor)) (Short order)

It suppose not to take short at 10 level (but it does at the moment, probably the operator is not correct) but it does take 00 and 90 level for short as required)

The long orders are find taking orders at 00 and 10 level (so far).



Edit: Use with caution this modification during Asian market, the big round numbers are not penetrable and usually bounce. I delete the orders if there are no news coming up within that hour.

In that case I shall leave the code as it is. I coded my understanding of what you sent me originally, and this appears to be working fine.

[SteveHopwood]

My charts continued to show the daily target hit message after the open of a new D1 candle. I have looked at the code and think we need a new line in void CanWeStopTrading() because DailyTargetHit is only reset if there are no trades in the history tab - and they are showing in mine even though it is a new D1 candle and my tab is set to show only trades taken today.

I will fix this in the morning. In the meantime, anyone experiencing the same just close down and restart your platform.

[dsugums]

I am getting a lot personal pms' for my set file and my codes. The code here is perfect in the first post here. I share almost all the setting here. Only thing missing from the code is the big round number trading (which I personally wont recommend).

The original thread in FF aims for 10% weekly target (or 2% daily). With this code here, we can achieve that within a day or two trading. Question is, have you all got the will power to set a reasonable target for the week and quit?

My weekly target is 15% at the moment. I did not expect to hit that limit within 2 hrs of London on Monday. Now, I need to ask myself whether I should stop or continue to bugger up my 21% gain to -30%.



Hard question to answer

[rapple]

Hi all

I am running this EA as per Dsu recommendations in post 1 but also included first 2 hours on US pairs (USDJPY, USDCAD,GBPCAD,CADCHF)

Yesterday (20140715) showed good results with:

Asian: 1 x BE, 2 x TP
UK: 1 x SL, 2 x TP
US: 2 x BE, 1 x TP

[dsugums]

London open two losses today. Should have deleted GU pending short when GY hit sl.

Part of trading to accept losses. 9am London no trades taken bcos of massive news for GBP.

-6% for today.

Asian trade AU BE after moving +7pips.

Will wait for US open for the last trades if any.

Jus stick to minimal number of pairs for trading. I analysed all my trades and now only trading

AU, AY (Asia)

GU,GY,EU,EY (London & US)

[rapple]

Also struggled

Asia: 1 x TP, 3 x BE
London: 4 x SL

[dsugums]

Been naughty and took the EU short trade at 00 level right after the news. Managed to get +3% for this trade.

GBP news trades always go into losses from experience. AUD and EUR at least will break even before moving against and very less slippage.

If we stick to EU,EY,GU,GY for London & US (minus the news time), I think we should make a decent returns weekly. Unfortunately today been bad with losses but still up for the week because Monday trades were good.

Still another 3 trading days to go. Anything goes

[casapips]

Bonjour Dsugums and Steve,

Many thanks for sharing your approach and recommendations..

One question: Would it feasible to code a filter in the EA "No trading < 1 hour before red news " and "No trading < 30 min after red news" ?

Merci

[SteveHopwood]

V 1n is in post 1. There is a basic logic bloop in V 1m, which would result in not always canceling the 'trading done for today' flag at the open of a new D1 candle.

Those of you who can (and if there is still anyone here who cannot then be ashamed of yourself) make the change yourself and conserve your hard-wired settings:

• load the file into your Crapql4 editor.
• shut down your platform.
• go to void CanWeStopTrading() in the Crapql4 editor
• find the first line of code which is AllAccountProfitToday = 0;
• just before or after this line, insert DailyTargetHit = false;
• recompile and restart your platform.

Here is the entire function if you are feeling insecure and just want to copy this over the top of the original:

Code: Select all

void CanWeStopTrading()
{

   DailyTargetHit = false;
   AllAccountProfitToday = 0;
   ProfitPercentToday = 0;
   if (OrdersHistoryTotal() == 0)
   {
      DailyTargetHit = false;
      return;
   }//if (OrdersHistoryTotal() == 0)
   
   datetime DayOpenTime = iTime(Symbol(),PERIOD_D1,0);
   
   for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
   {
      if (!OrderSelect(cc, SELECT_BY_POS, MODE_HISTORY) )
         continue;
      if (TimeDayOfWeek(OrderCloseTime()) != TimeDayOfWeek(TimeCurrent()) )
         continue;
      if(OrderOpenTime() < DayOpenTime)//Ignores trades that opened yesterday and closed today, but how likely is this to happen?
         continue;      
      if (OrderComment() == "Deposit")
         continue;
         
      AllAccountProfitToday+= (OrderProfit() + OrderSwap() + OrderCommission());   
   }//for (int cc = OrdersHistoryTotal() - 1; cc>= 0; cc++)
   
   StartBalance = AccountBalance() - AllAccountProfitToday;
   if (!CloseEnough(StartBalance, 0) )
      ProfitPercentToday = (AllAccountProfitToday / StartBalance) * 100;
   if (ProfitPercentToday >= DailyPercentOfBalanceTarget)
      DailyTargetHit = true;

}//void CanWeStopTrading()

[SpiderX]

Been naughty and took the EU short trade at 00 level right after the news. Managed to get +3% for this trade.

GBP news trades always go into losses from experience. AUD and EUR at least will break even before moving against and very less slippage.

If we stick to EU,EY,GU,GY for London & US (minus the news time), I think we should make a decent returns weekly. Unfortunately today been bad with losses but still up for the week because Monday trades were good.

Still another 3 trading days to go. Anything goes

Hi dsugums,

A suggestion...maybe you can check out how long it takes for a trade typically to hit tp.
Probably good to have a filter:
1. If trade time > 55 minutes (example)
2. Trade profit > 1 pip
Close the trade.

Might be nice to close off trades which are dragging out too long.

Cheers