Pipcruiser's Pipmasher

Post by **SteveHopwood** » Wed Oct 15, 2014 8:23 am

Niels just emailed to say the latest version would not download again. Those extra '+' signs are back again. Unbesmegginglievable. I didn't put the damn things there.

Fix in post 1. Remove the blasted things yourselves in lines 485 and 493 if you prefer.

Post by **SteveHopwood** » Wed Oct 15, 2014 10:21 pm

This will appear strange to some of you, but the individual it is aimed at will understand.

Questions about telling the time are not allowed in my threads. Work it out for yourself.

Post by **spotdespot** » Thu Oct 16, 2014 10:55 am

Steve - I think the EA might need a pending order expiry time or another mechanism to cope with what happened last night. At yesterday's close the previous day's pending orders that had not been filled happened to be valid trades again so the EA tried to set new pendings whilst the old ones were still present, got a bit confused and thought there was some rogue trading, closed the new pendings and left the old ones behind and, of course, disabled the EA on those charts.

Cheers,
Dave.

Post by **SteveHopwood** » Thu Oct 16, 2014 11:36 am

spotdespot » Thu Oct 16, 2014 10:55 am wrote:Steve - I think the EA might need a pending order expiry time or another mechanism to cope with what happened last night. At yesterday's close the previous day's pending orders that had not been filled happened to be valid trades again so the EA tried to set new pendings whilst the old ones were still present, got a bit confused and thought there was some rogue trading, closed the new pendings and left the old ones behind and, of course, disabled the EA on those charts.

Cheers,
Dave.

Actually, this is a classic case of fixing one problem creating a different one.

The Cretins at CrapperQuotes have gone a long way towards breaking Matt's OR code in Jerrybuile 7xx. Niels was seeing the occasional duplicate pending being sent, so I added code to delete duplicates - PP is only ever supposed to have one open pending.

When I forgot to add code to test for an already existing pending, PP dutifully sent the second one. Next tick, it equally dutifully discovered a duplicate and deleted it, then hung up its hat to avoid repeating the process. My robots do what they are told to do very nicely.

The fix is a single extra line of code, but here his the whole of the 'trading' bit of OnTick()

Code: Select all

//Trading
   if (EveryTickMode) OldBarsTime = 0;   
   if (OldBarsTime != iTime(NULL, TradingTF, 0) )
   {
      OldBarsTime = iTime(NULL, TradingTF, 0);
      if (!PendingOrder || PendingTradesCount == 0)
         if (TradingDayStatus != nottradingday)
            if (!AlreadyTradedToday)
               if (OpenTrades < MaxTradesAllowed)
                  if (!StopTrading) 
                  {
                     BriefSleep();//Generates a random period of sleep. Initialised in OnInit
                     LookForTradingOpportunities();
                  }//if (!StopTrading) 
                     
   }

Copy it over the top of the existing snippet and recompile.

For the peasants, V 1j is in post 1 with the fix - you don't need it if you have MaxTradesAllowed set to 1, but best to get it at some stage.

Post by **spotdespot** » Thu Oct 16, 2014 1:09 pm

Thanks Steve.

Post by **matt_32** » Fri Oct 31, 2014 9:25 am

Now we are rolling !!!!!!!!

The whole month was in DD and in the last few days things have come around. (+2000 pips)
What a strategy !!!!!

Thank you Pipmasher & thank you Steve (for coding it)

Matt

Post by **pipcruiser** » Fri Oct 31, 2014 9:53 am

Good to see matt

Yes, the strategy can sometimes be a bit "boring" but once the trends kicks in, its raining pips :!!:

Have a great weekend.

PC

PS: Steve congrats with the grandchild

Post by **matt_32** » Fri Oct 31, 2014 10:35 am

@pipcruiser

By the way are you in the process of testing your strategy in other Tf's ? If yes what are your conclusions?

Matt

AGT · Post by **AGT** » Fri Oct 31, 2014 10:46 am

Hmm ... we had a considerable move the last two days bcz of US/JPY news. So these changes providing the pretty good gains are based on fundamental changes in the price action ... SO: I think these fundamental causes aren't included neither in the strategy nor in the code !

Or can the technical code predict the future J.Y.'s speech directed yesterday ... ?

Or in words ... in fact it was more luck wasn't it ?

Post by **matt_32** » Fri Oct 31, 2014 11:26 am

AGT » Fri Oct 31, 2014 12:46 pm wrote:Hmm ... we had a considerable move the last two days bcz of US/JPY news. So these changes providing the pretty good gains are based on fundamental changes in the price action ... SO: I think these fundamental causes aren't included neither in the strategy nor in the code !

Or can the technical code predict the future J.Y.'s speech directed yesterday ... ?
Or in words ... in fact it was more luck wasn't it ?

OK the sudden move itself was lucky but .....the truth is that this strategy follows the big trends (monthly & weekly) which in my opinion encapsulate the long term sentiment of the market (fundamentals inluded).

So in other words if you stick to long term the moves sooner or later will come and then ......

Party time
:!!:

Matt