Old and defunct Holy Graily Bob

[BobbyT]

Renexxxx, trades are now being placed for range and rad trades. However there is no TP or SL being set.
This level of coding is way, way, way beyond what I am even remotely capable of, so it's possible I broke something in the copy paste

[PipPoppy]

Thank you Bob, Steve, Elixe, Milanese and Baluda for the years of knowledge and effort that has gone into producing what appears to be a magnificent indicator

I am struggling with the EA however - it opens a Trend trade on almost every chart that it is placed on, regardless of whether there is actually a trend signal or not. All of those trades are buys.
I currently have 2 open Trend buys on AUDUSD where no signals have fired for the TF it is set on (60)

The indicator gave a Trend sell signal on NZDUSD at 0744 GMT and the EA placed a buy order instead.

The EA is also not closing trades when a CSS alert is given even though it has been activated.
A Trend buy was correctly taken on USDCAD but there have been 3 CSS alerts since then but the trade remains open.

I have checked and double checked the inputs so as not to incur Steve's wrath

[KingOfCoolville]

Thank you Bob, Steve, Elixe, Milanese and Baluda for the years of knowledge and effort that has gone into producing what appears to be a magnificent indicator

I am struggling with the EA however - it opens a Trend trade on almost every chart that it is placed on, regardless of whether there is actually a trend signal or not. All of those trades are buys.
I currently have 2 open Trend buys on AUDUSD where no signals have fired for the TF it is set on (60)

The indicator gave a Trend sell signal on NZDUSD at 0744 GMT and the EA placed a buy order instead.

The EA is also not closing trades when a CSS alert is given even though it has been activated.
A Trend buy was correctly taken on USDCAD but there have been 3 CSS alerts since then but the trade remains open.

I have checked and double checked the inputs so as not to incur Steve's wrath

Steve,

On my demo I'm having the same problem also.

All trades are trend buy trades regardless of the signals given on the template.

Looking at the CADJPY the signal is currently a definate sell on H4, currently the EA has 3 buy trades open which are all obviously losers.

Cheers

[SteveHopwood]

V 1a is in post 1.

Thanks for the fixes Rene.

I coded the Trend stuff whilst the markets were open on Friday and so was able to test it. The Range and RAD stuff I did over the weekend, and forgot to add code to deal with sending the actual trades - those are the fixes that Rene posted.

Remember to download the zero-divide fixes version of the HGI from Bob's post then change the name of the indi in HGB's input.

Those of you who have added Rene's fixes for yourselves might want to add another cpu stress-reliever. We only need the wavy line component of HGI reading at the open of a new candle, so go to void ReadIndicatorValues() and find the code snippet that begins with this comment:
//Read the TMA component

Delete the snippet

A little higher up you will see this comment:
//shift = 3;

Directly underneath that comment, insert this:

Code: Select all

//We only need to read the TMA component at the start of a new candle
   static datetime OldReadTmaTime = 0;
   if (OldReadTmaTime != iTime(Symbol(), TradingTimeFrame, 0) )
   {
      OldReadTmaTime = iTime(Symbol(), TradingTimeFrame, 0);
      //Read the TMA component
      TmaStatus = Tmanosignal;
      //Buffer 7 holds a low signal. Wavy line signals are placed on the chart at the candle close.
      val = GetHGI(Symbol(), TradingTimeFrame, 7, 1);
      if (!CloseEnough(val, EMPTY_VALUE) )
      {
         TmaStatus = Tmalowsignal;
      }//if (!CloseEnough(val 0) )
      else
      {
         //Buffer 6 holds a high signal. Wavy line signals are placed on the chart at the candle close.
         val = GetHGI(Symbol(), TradingTimeFrame, 6, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            TmaStatus = Tmahighsignal;
         }//if (!CloseEnough(val 0) )
      }//else
      
   }//if (OldReadTmaTime != iTime(Symbol(), TradingTimeFrame, 0) )
   

and recompile.

[BobbyT]

Thanks for the updates. I won't be able to test this until tomorrow as I'm running the EA on my work PC.
I'll leave it to the Euro/US crew.

[SteveHopwood]

And in the blink of an eye, V 1b is in post 1. You guys will find your stop losses and take profits magically appearing.

I forgot some doubles conversions. Go to int OnInit() and add these to the list of conversions:

Code: Select all

TrendStopLoss = TrendStopLossPips;
   RangeStopLoss = RangeStopLossPips;
   RadStopLoss = RadStopLossPips;
   TrendTakeProfit = TrendTakeProfitPips;
   RangeTakeProfit = RangeTakeProfitPips;
   RadTakeProfit = RadTakeProfitPips;

[Gertje]

And we're off!
7 orders opened immediately after loading v1a, looking forward in exitement!



EDIT:

WICKED!!!

The EA 'reads' the small diagonal arrows, and fires a trade when PA reaches that point instead of firing pendings when arrows are printed.

[SteveHopwood]

Things are looking good with the initial teething problems out of the way.

Don't go putting this on any live accounts just yet folks, in case any more bugs crawl out of the woodwork. We will have to use the anti-overtrading filters once we do - this beast is a trading tart.

[retireme]

69 open and 83 closed, I think you could be right Steve...

Things are looking good with the initial teething problems out of the way.

Don't go putting this on any live accounts just yet folks, in case any more bugs crawl out of the woodwork. We will have to use the anti-overtrading filters once we do - this beast is a trading tart.

[Gertje]

69 open and 83 closed, I think you could be right Steve...

Want to share pre-liminairy results?