Steve and/or any other proper coders out there could you look at something for me please?
taggie11 pointed out to me that she had no pending trades set last night and I replied something along the lines of well that because it was Monday. I then engaged a brain cell and realised she was correct - if Monday's candle was a pullback from the weekly/monthly then pendings should have been set (as per the intro from you Steve). Do not trade Mondays means just that - but after Monday NYC close (for Global Prime people anyway) - we are actually on "Tuesday" as far as trading days go. Do not trade Monday is designed to prevent trades opening at market opening based on Friday's candle.
taggie11 also pointed out that xfactornos had 10 pending trades on his FXCM account and I noticed he had none on the FinFx account. Now different D1 candles different results - no doubt BUT 10 seemed a bit high for that to be the explanation, given the 2 hour difference. So I had a look at the code and I think at line 3751:
Code: Select all
//Today's trading status
int day = TimeDayOfWeek(TimeLocal() );
TradingDayStatus = nottradingday;//default
if (day > 1 && day < 6)//We trade Tues - Friday
{
TradingDayStatus = tradingday;
}//if (day > 1 && day is < 6)
else
if (day == 1)
if (TradeMonday)
TradingDayStatus = tradingday;
Should read:
Code: Select all
//Today's trading status
int day = TimeDayOfWeek(TimeCurrent() );
TradingDayStatus = nottradingday;//default
if (day > 1 && day < 6)//We trade Tues - Friday
{
TradingDayStatus = tradingday;
}//if (day > 1 && day is < 6)
else
if (day == 1)
if (TradeMonday)
TradingDayStatus = tradingday;
As we actually want the server time to determine trading day. TimeDayOfWeek(TimeCurrent() ) is used elsewhere in the code for this check but not here. Could someone who knows what they are doing (as opposed to me
) confirm please?
I also noticed that there is a function: "int DayOfWeek();" that returns server day but I have no idea if this has issues or isn't used for some other reason but I thought I would point it out in case it is new.
Cheers,
Dave.
