Fratelli EA by Dragos and magft

[garyfritz]

I downloaded 2.5. It placed orders on AUDUSD and EURUSD, but EURJPY produced continuous "invalid trade volume" errors. Lot = 0.1 on all 3. Other than that and trading times, everything is OOTB.

[gaheitman]

Mike,

I think the issue is with your error filter. You currently have:

Code: Select all

            if (err!=0||err!=1)

With this, if err = 1, the err!=0 side will evaluate to true, which makes the whole statement true.

I think you want to say:

Code: Select all

            if (err!=0 && err!=1)

Or you could say:

Code: Select all

            if (!(err==0||err==1))

But that's not exactly easier to read. :> Perhaps a simple:

Code: Select all

            if (err>2)

I saw it quite a few times before the switch went off.

George

But all this back testing is done with the same rules . tp and sl might be different because we have some high volatility pairs, and low volatility pairs ,

Why don't you use volatility-based stop calculations? Maybe for hand-executing Fratelli with indicators, you need to give people fixed values. But I always base stops on a volatility measure, such as ADR. That way you use the same rule for all pairs.

I think using a SL/TP based on volatility is a good idea. The EA has the option to set these already.

Currently doing some final checking before releasing v2.5. Dragos has been doing checking and updating for me as i have been busy this weekend. I have done some more mods like updating the times routine to allow mins and hrs to be set so now we can follow rules of 5:50-18:30 GMT. I have fixed logic fo re-entries and added the SAR entry. Fixed a few bugs that had been raised though i still cannot get rid of error 1! I have put in error checking but it still gets through, so if anyone knows how to overcome this let me know please as i am stumped at the moment.

Mike

[gaheitman]

I downloaded 2.5. It placed orders on AUDUSD and EURUSD, but EURJPY produced continuous "invalid trade volume" errors. Lot = 0.1 on all 3. Other than that and trading times, everything is OOTB.

This version has auto lot size calculation on by default. Did you leave UseMoneyMgmt set to true?

That being said, I don't see anything wrong with that bit of code.

George

[garyfritz]

Yes, I only changed lotsize and market hours.

I can't check it now, unfortunately. I put another Fratelli indicator on my chart and Empty4 crashed, and now it exits as soon as I start it. I found terminal.ini in C:\Users\Gary\AppDataLocal\VirtualStore\Program Files (x86)\Trading\Best Direct Empty4\config and tried removing the xFratelli-Signals v0.96 line -- no change.

Anyone know how I can remove this indy from my chart if I can't run Empty4??

[gaheitman]

Yes, I only changed lotsize and market hours.

I can't check it now, unfortunately. I put another Fratelli indicator on my chart and Empty4 crashed, and now it exits as soon as I start it. I found terminal.ini in C:\Users\Gary\AppDataLocal\VirtualStore\Program Files (x86)\Trading\Best Direct Empty4\config and tried removing the xFratelli-Signals v0.96 line -- no change.

Anyone know how I can remove this indy from my chart if I can't run Empty4??

You should be able to modify the *.chr file in your C:\Users\Gary\AppDataLocal\VirtualStore\Program Files (x86)\Trading\Best Direct Empty4\Profiles\<whatever your active profile was> directory. Just search for "name=Custom Indicator" and delete the section that contains the badly behaved indicator. Or, you can rename the whole directory and start building your workspace from scratch.

When I have this problem, usually Empty4 hasn't written the changes to disk and I can restart without the new indicator on the chart yet.

George

[DragosDanescu]

Yes, I only changed lotsize and market hours.

I can't check it now, unfortunately. I put another Fratelli indicator on my chart and Empty4 crashed, and now it exits as soon as I start it. I found terminal.ini in C:\Users\Gary\AppDataLocal\VirtualStore\Program Files (x86)\Trading\Best Direct Empty4\config and tried removing the xFratelli-Signals v0.96 line -- no change.

Anyone know how I can remove this indy from my chart if I can't run Empty4??

Why not removing indicator from indicators folder and restart?

[gaheitman]

Yes, I only changed lotsize and market hours.

I can't check it now, unfortunately. I put another Fratelli indicator on my chart and Empty4 crashed, and now it exits as soon as I start it. I found terminal.ini in C:\Users\Gary\AppDataLocal\VirtualStore\Program Files (x86)\Trading\Best Direct Empty4\config and tried removing the xFratelli-Signals v0.96 line -- no change.

Anyone know how I can remove this indy from my chart if I can't run Empty4??

Why not removing indicator from indicators folder and restart?

That's a much better solution. Obviously time for me to make some coffee! -George

[tex]

Dragos, Mike,

i think theres a bug in the new 2.5 EA. Look at screenshots. In my EU trade i set the TP=20 and SL=25 acording to the rules. The EA opened a trade but the TP was set to about 14,9P only. Same in the recent EJ trade.
I set the EA to Tp=20, SL = 20. But the EA opened the trade with TP = 15,6p, SL = 32,4p ??

Can u check this please.

thanks

[DragosDanescu]

Dragos, Mike,

i think theres a bug in the new 2.5 EA. Look at screenshots. In my EU trade i set the TP=20 and SL=25 acording to the rules. The EA opened a trade but the TP was set to about 14,9P only. Same in the recent EJ trade.
I set the EA to Tp=20, SL = 20. But the EA opened the trade with TP = 15,6p, SL = 32,4p ??

Can u check this please.

thanks

Hahahahaha!
Hi, Tex, obviously, Mike had stolen your pips! There's a hidden code somewhere, so the pips difference goes to him
We gonna have a look...

[tex]

hahaha, well then i hope the negative pips in case of a loss go to him too

Dragos, Mike,

i think theres a bug in the new 2.5 EA. Look at screenshots. In my EU trade i set the TP=20 and SL=25 acording to the rules. The EA opened a trade but the TP was set to about 14,9P only. Same in the recent EJ trade.
I set the EA to Tp=20, SL = 20. But the EA opened the trade with TP = 15,6p, SL = 32,4p ??

Can u check this please.

thanks

Hahahahaha!
Hi, Tex, obviously, Mike had stolen your pips! There's a hidden code somewhere, so the pips difference goes to him
We gonna have a look...