Old and defunct Holy Graily Bob

EA's inspired by nanningbob's work here, especially those based on his 240 Moving Average trend detection filter.
Locked
User avatar
SteveHopwood
Owner
Posts: 9904
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Holy Graily Bob

Post by SteveHopwood »

ecodesign » Fri Jan 16, 2015 3:15 am wrote: **********************************************************************************
I was checking out the code in v2m for RAD trades within the function called:

CalculateTakeProfit(int type, double price, string comment). There may be a bug....check it out here

//Rad trades <----------------------------------------line 1879
if (comment == RadTradeComment)
{
//Atr take profit
if (RadAtrPeriod > 0)
{
RadTakeProfit = (GetAtr(Symbol(), RadAtrTimeFrame, RadAtrPeriod, 0) * factor) *RadAtrTpMultiplier;
}//if (RadAtrPeriod > 0)

if (!CloseEnough(RadTakeProfit, 0) )
{
take = price + (RadTakeProfit / factor);
HiddenTakeProfit = take;
}//if (!CloseEnough(RadTakeProfit, 0) )
}//if (comment == RadTradeComment)

//Rad trades <-----------------------------appears a second time
if (comment == RadTradeComment)
if (!CloseEnough(RadTakeProfit, 0) )
{
take = price + (RadTakeProfit / factor);
HiddenTakeProfit = take;
}//if (!CloseEnough(RadTakeProfit, 0) )

//Rad Multi trades <---------------------------------------- I think it should be rad multi (like this)
if (comment == RadMultiTradeComment)
if (!CloseEnough(RadMultiTakeProfit, 0) )
{
take = price + (RadMultiTakeProfit / factor);
HiddenTakeProfit = take;
}//if (!CloseEnough(RadMultiTakeProfit, 0) )



Hope this helps...
Wayne
Nice spot Wayne. Thanks. :clap:

This must be something I balsed up when making the most recent changes. Fix in post 1 (2n) but you do not need it if your rad multi-trades are going out with the correct take profit.

:xm:
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. pianodoodler@hotmail.com is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
feucht
Trader
Posts: 101
Joined: Thu May 03, 2012 3:16 pm

Holy Graily Bob

Post by feucht »

The real consequences of yesterday might be at the broker end. Alpari has gone bust (boohoo), and FXCM is in some serious trouble. Would be nice to hear from Jem how GP weathered the storm...
User avatar
boinvest
Trader
Posts: 142
Joined: Wed May 28, 2014 6:56 am
Location: Netherlands

Holy Graily Bob

Post by boinvest »

SteveHopwood » Thu Jan 15, 2015 10:47 pm wrote: Thanks. :clap: :clap: :clap: Added to post 1.

bo, you do understand that I consider you to be a genius sort of bloke, don't you, and merely accept your updates without question?

No pressure, but don't fuck anything up will you? I don't guarantee to be able to sort out any resulting mess.

:xm:
Well, I only changed 5 Characters.
Didn't even bother, to test it myself :oops:
But 1 wrong character could be enough to mock up an EA.
8-)
feucht wrote:The real consequences of yesterday might be at the broker end. Alpari has gone bust (boohoo), and FXCM is in some serious trouble. Would be nice to hear from Jem how GP weathered the storm...
Yes, we could expect more brokerages t close the doors.
is there already a topic about this on SHF?
User avatar
tonyharmony
Trader
Posts: 148
Joined: Sat Dec 20, 2014 10:54 pm
Location: Ipswich, Queensland Australia

Holy Graily Bob

Post by tonyharmony »

feucht » Fri Jan 16, 2015 9:42 pm wrote:The real consequences of yesterday might be at the broker end. Alpari has gone bust (boohoo), and FXCM is in some serious trouble. Would be nice to hear from Jem how GP weathered the storm...
I actually contacted Jeremy at GP today and apparently they covered themselves quite well. As for Axitrader they have increased swap substantially, and Think Forex have reduced their leverage to a maximum of 50:1 for all CHF crosses...

Jeremy said they aren't sure what is going to happen with GP, but at this stage everything is ok....

Just thought I'd give you the heads up.

Kind regards
Tony
One can't learn from one's success, but one can learn an enormous amount from one's failures! Determination to succeed is the only goal....
trendinator
Trader
Posts: 156
Joined: Sat Dec 06, 2014 12:22 am

Holy Graily Bob

Post by trendinator »

my 2i didn't fair very well through all that.

Image
User avatar
Wiggy1965
Trader
Posts: 326
Joined: Fri Jan 04, 2013 11:58 am
Location: Melbourne - Australia

Holy Graily Bob

Post by Wiggy1965 »

boinvest,

what should the EA output display for "Next indi read time:" ...?

should it be pc clock time "X" number of second from current time, or server time...?

the only reason i ask, i just dropped 2n onto a chart and was looking for any change in the out-put and noticed the "Next indi read time:" was 14:02 may server time is 14:36 and pc time is 11:28..

I compared this to the version 2k chart and it has Next indi read time: 12:03

The only change i have made to the EA is "HgiReadDelaySeconds = 180 to try and reduce processor utilization...

Regards
Wiggy
feucht
Trader
Posts: 101
Joined: Thu May 03, 2012 3:16 pm

Holy Graily Bob

Post by feucht »

Thanks for the update
tonyharmony » Fri Jan 16, 2015 12:30 pm wrote:
feucht » Fri Jan 16, 2015 9:42 pm wrote:The real consequences of yesterday might be at the broker end. Alpari has gone bust (boohoo), and FXCM is in some serious trouble. Would be nice to hear from Jem how GP weathered the storm...
I actually contacted Jeremy at GP today and apparently they covered themselves quite well. As for Axitrader they have increased swap substantially, and Think Forex have reduced their leverage to a maximum of 50:1 for all CHF crosses...

Jeremy said they aren't sure what is going to happen with GP, but at this stage everything is ok....

Just thought I'd give you the heads up.

Kind regards
Tony
Leslie
Trader
Posts: 46
Joined: Thu Dec 04, 2014 12:58 am

Holy Graily Bob

Post by Leslie »

Anyone with suggestions for a US broker that fits with HGB (or non-US broker that accepts US clients), I'll certainly investigate making a change. Thanks.

Leslie
The recommendation I kindly received here limits minimum trade size to 10K- beyond my risk appetite. Any other recommendations would be gladly received. Thanks.

Leslie
User avatar
boinvest
Trader
Posts: 142
Joined: Wed May 28, 2014 6:56 am
Location: Netherlands

Holy Graily Bob

Post by boinvest »

Wiggy1965 » Fri Jan 16, 2015 12:44 pm wrote:boinvest,

what should the EA output display for "Next indi read time:" ...?

should it be pc clock time "X" number of second from current time, or server time...?

the only reason i ask, i just dropped 2n onto a chart and was looking for any change in the out-put and noticed the "Next indi read time:" was 14:02 may server time is 14:36 and pc time is 11:28..

I compared this to the version 2k chart and it has Next indi read time: 12:03

The only change i have made to the EA is "HgiReadDelaySeconds = 180 to try and reduce processor utilization...

Regards
Wiggy
It is server time + Read delay in seconds.
Maybe the "ChartRefreshDelaySeconds" is causing the next indi read time to be lower then actual server time.
Bacause when the next indi read time is before the current time.. the EA should automatically set the next read time to the current time + the Read delay in seconds.
fchaman
Trader
Posts: 119
Joined: Sat Nov 19, 2011 1:13 pm
Location: End of the world

Holy Graily Bob

Post by fchaman »

feucht » Fri Jan 16, 2015 6:42 am wrote:The real consequences of yesterday might be at the broker end. Alpari has gone bust (boohoo), and FXCM is in some serious trouble. Would be nice to hear from Jem how GP weathered the storm...
Thanks feucht for the update....regarding FXCM, where did you hear that FXCM is in trouble?
Locked

Return to “Thingy Bob EA's”