Old and defunct Holy Graily Bob

[forexsam]

I believe that there is a typo ... line 3995

Code: Select all

   if (WaveStatus == TmaYellowWave)

should be

Code: Select all

   if (WaveStatus == WaveSell)

However, I think this closure will fail if WaveTradeBlueToYellowOnly = true

SAM

[SteveHopwood]

I believe that there is a typo ... line 3995

Code: Select all

   if (WaveStatus == TmaYellowWave)

should be

Code: Select all

   if (WaveStatus == WaveSell)

However, I think this closure will fail if WaveTradeBlueToYellowOnly = true

SAM

Thanks for pointing this out Sam.

The way I recoded the definition of WaveStatus was intended to take care of all eventualities. No guarantee I succeeded of course, but that was my intention, so it should. be ok. On a good day. In a month with an 'x' in it.

Either way, Sam is correct. V 2z is in post 1 for the codaphobes. The rest of you go to line 3995 and replace it with
if (WaveStatus == Wavesell)

The highlighted lower case 's' is just to remind you not to use the upper case 'S'.

Thanks Sam.

[forexsam]

Sorry to be a pain, but I can't wrap my head around this Close.

Assuming WaveTradeBlueToYellowOnly = true

1. Low Blue Wave is Signaled, then WaveStatus == Wavebuy, tmaStatus == TmaBlueWave (All Good)
2. High Yellow is Signaled for Close, TmaStatus == TmaYellowWave, but WaveStatus == Wavebuy because the change of WaveStatus == Wavesell was bypassed because "if (!WaveTradeBlueToYellowOnly)" fails

Code: Select all

 if (!WaveTradeBlueToYellowOnly)
               {
                  if (Bid < val)
                     WaveStatus = Wavesell;//High wavy gold line so sell below it
                  else
                     WaveStatus = Wavebuy;//Low wavy gold line so buy above it

So, WaveStatus needs to be Wavesell to close, and I don't think that it is doing that for WaveTradeBlueToYellowOnly = True


If you delete the message, I will assume that I am an idiot, and I will just trust you :hi:
Sam

[forexsam]

Please understand that HGB is amazing and very profitable. I don't want to make more work for Steve or any other coder. I simply feel that they would fix issues more elegantly and certainly more logically than I would.

Here is what I have seen, and was able to capture today. I think that both these issues are related. First, HGB did a double buy, and later, it only closed 1 of 3 trades on a yellow wave. Earlier I saw this happen live. The Yellow Close triggered essentially at the close of a bar and assigned the signal to the bar that just closed, which is now the previous bar. So, the trade remained open. Today, as seen In the image I attached the double buy actually occurs on 2 different bars, and it is ignoring the difference of 30 pips rule. Also, the closing sequence started on the first bar, but then the bar advanced and the signal was now in the past leaving 2 trades open.

To further complicate things, I hacked the code to look at the previous bar for a close signal as well. Sadly, I ran into a situation where a Blue Wave occured on the 2nd Bar. Looking back gave the close, while the current bar gave the open...you can see where that went

I personally don't need these changes, and HGB does everything I could ask for, I just like to see things acting weird like this... and I hope this helps someone.

Thanks again,
SAM

P.S. Steve, if you want me to find the specific logic, let me know, I actually have some time available.

[SteveHopwood]

P.S. Steve, if you want me to find the specific logic, let me know, I actually have some time available.

Feel free Sam. Today is a teaching day for me, so I have no time available. Thanks.

[forexsam]

I Need help. Here is what it is doing. When a 2nd signal is given, but it fails correctly because either we have an OPEN/CLOSE or just an OPEN on that bar, It holds on to that signal, OR HGI isn't re-read at the open of the next bar. Either way, when the next bar opens it fires that signal/trade AND ignores the MinDistancePip Rule. Therefore, Double Trade.

I forced it to happen by manually closing a trade while the signal was still valid. There was no reason to trigger the trade on that next bar ... I'm tired This is a BUNCH of code

Steve I commend you on this effort...I'll get back to it after dinner.

[SteveHopwood]

I Need help. Here is what it is doing. When a 2nd signal is given, but it fails correctly because either we have an OPEN/CLOSE or just an OPEN on that bar, It holds on to that signal, OR HGI isn't re-read at the open of the next bar. Either way, when the next bar opens it fires that signal/trade AND ignores the MinDistancePip Rule. Therefore, Double Trade.

I forced it to happen by manually closing a trade while the signal was still valid. There was no reason to trigger the trade on that next bar ... I'm tired This is a BUNCH of code

Steve I commend you on this effort...I'll get back to it after dinner.

Sam, bear in mind that it is nearly 23.00 here in the uk and have imbibed a bit, and so could be talking my usual post 18.00 rubbish.

Look at 3601 if (TimeCurrent() >= NextReadTime)

which stops the ea calling the indi every micro second on 27 different charts and buggering up every computer not actually owned by NASA.

The look at 3608 NextReadTime = TimeCurrent() + HgiReadDelaySeconds;

Could this cause HGB to miss a candle change or something?

I haven't a clue. I am pissed. An olcohol, I mean, not yissed at pou.

[droland]

Not yissed at pou.

Now that's funny.

[getdown71]

Golden Hopwood spoonerism.......burp (single malt smell) from this neck of the woods.

[admcd24]

Here are my results for last week.

1Hr TF

Trades2-8.png

Way too many trades for me so perhaps I will run the EA during the London session only this week.

4Hr TF

Trades4hr2-8.png

Started off great from Sun to Mon with +326 pips on the 4Hr TF, unfortunately they were all given back.
Will see what this week brings