Fratelli EA by Dragos and magft

[gaheitman]

My understanding is it's on the first bar where all conditions are met. So e.g. if you get a down arrow but the candle is green, you wait until the candle turns red -- then you calculate your PO off the low of the first red candle.

Then I think the references in LookForTradingOpportunities() to

Code: Select all

iBarShift(NULL,0,ArrowBar)

should be replaced with the number "1" to designate the previous bar.

Let's wait for the original authors to chime in and make sure I am reading everything correctly.

George

[musky]

I stopped this after it lost 40% of a $1000 demo overnight, 3 times. (On the ten min chart with the set file in the second post. ) Thanks

[SWG123]

I stopped this after it lost 40% of a $1000 demo overnight, 3 times. (On the ten min chart with the set file in the second post. ) Thanks

Something not quite right there methinks.

[musky]

Yeah I was hoping to see some errors or something, nothing just steady losses.

[SWG123]

Mike or Dragos,

The scripts P4L PeriodCon.mq4, Period_Converter_Opt.mq4 and Period_Converter_Opt_mod.mq4 all stubbornly refuse to execute on my Oanda Empty4. Have tried compiling, doesn't help.

Is there any reason not to use Empty4's built-in period converter? It seems to work fine but if so, I'm wondering why the alternative scripts were posted. Apologies if this has been dealt with already.

[musky]

I have that on a Oanda Empty4 that script works fine .

[garyfritz]

I had v2.5 set to 24h trading, and I got a couple of orders when the market gapped up last night, so I set it to run 5:00-24:00. But nothing since then -- no orders in AU, EU, EJ, or GU. All 4 charts show the "Fratelli v2-5" smiley face, but only EJ is displaying the Comment() on the chart. EJ was set to run 5:50-18:30 local.

I set all charts back to 24h and the Comment() started displaying. Something wrong with the trading-hours code? Maybe now it will start trading.

EDIT: Nuts. Now I'm getting "invalid trade volume" on GU. Guess I'd better set it to a fixed 0.1 lot too. I think the problem is that it's trying to trade 2.48, and my broker is limited to 0.1 lots. So it should be using 2.4 or 2.5.

[gaheitman]

I had v2.5 set to 24h trading, and I got a couple of orders when the market gapped up last night, so I set it to run 5:00-24:00. But nothing since then -- no orders in AU, EU, EJ, or GU. All 4 charts show the "Fratelli v2-5" smiley face, but only EJ is displaying the Comment() on the chart. EJ was set to run 5:50-18:30 local.

I set all charts back to 24h and the Comment() started displaying. Something wrong with the trading-hours code? Maybe now it will start trading.

EDIT: Nuts. Now I'm getting "invalid trade volume" on GU. Guess I'd better set it to a fixed 0.1 lot too. I think the problem is that it's trying to trade 2.48, and my broker is limited to 0.1 lots. So it should be using 2.4 or 2.5.

Are your charts getting new data? Also, which script are you using to make the 10 min chart, I'm not sure all of them support running EAs on the offline chart.

For the lot size issue, I think they should replace the existing lot size calculation with Mike's code in Jiva's 5 min OpenClose EA since it includes error checking. (very nice bit of code, like all of Mike's code...)

George

[garyfritz]

Yes, I'm getting new data. I'm using Period_Converter_Opt_mod with PeriodMultiplier = 2 on 5min charts.

[garyfritz]

New error: "Setting of SL EURUSD ticket no XXXXXXX failed with error (1): no error"

Also happens with breakeven SLs.