Wide Range Body Holy Graily Bob

[figgir]

Hello again,

I do not want to be annoying, I read hours many posts on this forum about the HGI (HGB), I also read that the Wide Range Body Holy Grail Bob strategy will no longer be modified, but it seems to me to be essential thing within the runtime of strategy.

I have a remark regarding to correct closing trades on the yellow range waves in Wide Range Body Holy Graily Bob strategy (1b version)

I noticed that checking for wavy yellow range signal si mostly activated ONLY if was found any other signal, (eg. small diagonal green up, etc.). At the same time (in millisecond precision) is activated yellow range waves checking, which starts on row 2152 (GetHGI function).

I think that a checking function for yellow range wawes, which is on the line in 2152, should be included in the cycle "while (! SignalFound)" which starts at row 2029. It seems that the program runs only in this cycle for finding the occurrence of arrows except yellow range waves (buffer 6) which is not defined in the cycle. At moment of "Break" (row no 2143), when is found any other signal, is activated continuously also the yellow wave range checkign function, which is out of cycle.

Then it happens that if the yellow range wave appears on previous candle during rendering of actual candle, yellow wave on previous candle is not detected.

(Function GetHGI which is checking for buffer 6 occurence, seems to be properly activated only at the moment of very first start with new H4 candle, maybe because at this moment, the run of program is not closed in cycle "while (! SignalFound)" yet.).

Correct me if I'm wrong, and something I've overlooked.

Have a nice day.

figgir

[figgir]

back to trading from crazy regular job.

how to fix the yellow waves thing:

ad1:
row 821 needs to be changed
from "ArrayResize(CandleBodySize, WrbCandlesLookBack + 1);"
to "ArrayResize(CandleBodySize, WrbCandlesLookBack + 2);"

otherwise function GetBodySize returning "Array out of range" error when CandleBodySize[3] is compared to CandleBodySize[1] (this comparison is inside of WrongWRB function)

ad2:
block of commands (rows 2152-2158) is good to be copied before "if (WrongWRB(Symbol(), TradingTimeFrame, cc))" actually before the IF statement on the row 2036. (issue is described in my previous post from Oct. 22nd)

--------
These two changes have proved in real-time testing on open trades during last two weeks where EA reacts on all yellow waves calculations on closed candles.

If it helps someone, I can attach repaired version here (I call it for my purposes as version 1c).

I have to say that the entire EA is nicely and intuitively written. It is nice to work with.

figgir

[pancherupula]

Please attache revised EA 1C. Thank you for good work.